All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.gsc@gmail.com>
To: Kshitiz Varshney <kshitiz.varshney@nxp.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Varun Sethi <V.Sethi@nxp.com>, Gaurav Jain <gaurav.jain@nxp.com>,
	Pankaj Gupta <pankaj.gupta@nxp.com>,
	Sahil Malhotra <sahil.malhotra@nxp.com>,
	Vabhav Sharma <vabhav.sharma@nxp.com>,
	Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
	Rahul Kumar Yadav <rahulkumar.yadav@nxp.com>,
	Nikhil Singla <nikhil.singla@nxp.com>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] imx_v6_v7_defconfig: Enable sm3, sm4, polyval, xctr cipher test support
Date: Sat, 3 Feb 2024 22:21:49 +0800	[thread overview]
Message-ID: <20240203142149.GI463595@dragon> (raw)
In-Reply-To: <20231220113857.1127598-1-kshitiz.varshney@nxp.com>

On Wed, Dec 20, 2023 at 12:38:57PM +0100, Kshitiz Varshney wrote:
>     Enable config for sm3, sm4, polyval, xctr cipher test as built in module.
> 
>     Issue:-
>     Multiple crypto tests like sm3, sm4 xctr and polyval failing.
> 
>     skcipher: failed to allocate transform for xctr(aes): -2
>     alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2)
>     alg: self-tests for sm3 using sm3 failed (rc=-2)
>     tcrypt: failed to load transform for sm3: -2
>     alg: hash: failed to allocate transform for polyval: -2
>     alg: self-tests for polyval using polyval failed (rc=-2)
> 
>     Resolution:-
>     Enabling CONFIG_CRYPTO_SM3_GENERIC, CONFIG_CRYPTO_SM4_GENERIC,
>     CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables support of
>     sm3, sm4, aria, polyval & xctr.
> 
>     Signed-off-by: Kshitiz Varshney <kshitiz.varshney@nxp.com>

The commit log and Signed-off-by lines shouldn't have leading
spaces/indent.

> ---
>  arch/arm/configs/imx_v6_v7_defconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> index 0a90583f9f01..627f57da9d5b 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -484,3 +484,7 @@ CONFIG_DEBUG_FS=y
>  # CONFIG_SLUB_DEBUG is not set
>  # CONFIG_SCHED_DEBUG is not set
>  # CONFIG_FTRACE is not set
> +CONFIG_CRYPTO_HCTR2=m
> +CONFIG_CRYPTO_SM3_GENERIC=m
> +CONFIG_CRYPTO_SM4_GENERIC=m
> +CONFIG_CRYPTO_ARIA=m

Instead of adding lines at the end of file, please use help from
'make savedefconfig' to get them appear at the correct places.

Shawn

  parent reply	other threads:[~2024-02-03 14:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-20 11:38 [PATCH v1] imx_v6_v7_defconfig: Enable sm3, sm4, polyval, xctr cipher test support Kshitiz Varshney
2024-01-03  9:43 ` Gaurav Jain
2024-01-16  9:59 ` Kshitiz Varshney
2024-01-16 10:05   ` Fabio Estevam
2024-02-03 14:21 ` Shawn Guo [this message]
2024-02-05 11:42   ` [EXT] " Kshitiz Varshney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240203142149.GI463595@dragon \
    --to=shawn.gsc@gmail.com \
    --cc=V.Sethi@nxp.com \
    --cc=festevam@gmail.com \
    --cc=gaurav.jain@nxp.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kernel@pengutronix.de \
    --cc=kshitiz.varshney@nxp.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=meenakshi.aggarwal@nxp.com \
    --cc=nikhil.singla@nxp.com \
    --cc=pankaj.gupta@nxp.com \
    --cc=rahulkumar.yadav@nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sahil.malhotra@nxp.com \
    --cc=shawnguo@kernel.org \
    --cc=vabhav.sharma@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.