From: Simon Horman <horms@kernel.org>
To: Ravi Gunasekaran <r-gunasekaran@ti.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew@lunn.ch, rogerq@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
s-vadapalli@ti.com, srk@ti.com
Subject: Re: [RFC PATCH net-next 2/2] net: ethernet: ti: inter-core-virt-eth: Register as network device
Date: Sat, 3 Feb 2024 19:38:09 +0000 [thread overview]
Message-ID: <20240203193809.GA706477@kernel.org> (raw)
In-Reply-To: <32f49a1d-7974-4dc6-be20-f21f5aabc264@ti.com>
On Thu, Feb 01, 2024 at 07:54:24PM +0530, Ravi Gunasekaran wrote:
...
> Thanks for taking time to review the patches.
>
> The primary intention of this series was to know if the RPMsg based approach
> would be upstream friendly or not. But I would not like to use that as an excuse
> for not fixing checks/warnings/errors reported by checkpatch completely.
> Even though if its RFC, I will treat it as an actual upstream patch and address the
> checkpatch/smatch/sparse findings or atleast mention in the cover letter that the
> findings have not been fully addressed.
Understood. TBH, I am unsure of the value of this kind of review for an RFC
- I understand it is important to get the bigger picture questions out of
the way at this point.
...
prev parent reply other threads:[~2024-02-03 19:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 11:09 [RFC PATCH net-next 0/2] RPMsg based shared memory ethernet driver Ravi Gunasekaran
2024-01-30 11:09 ` [RFC PATCH net-next 1/2] net: ethernet: ti: Introduce inter-core-virt-eth as RPMsg driver Ravi Gunasekaran
2024-02-01 13:30 ` Simon Horman
2024-02-01 14:15 ` Ravi Gunasekaran
2024-02-01 14:20 ` Ravi Gunasekaran
2024-01-30 11:09 ` [RFC PATCH net-next 2/2] net: ethernet: ti: inter-core-virt-eth: Register as network device Ravi Gunasekaran
2024-02-01 13:19 ` Simon Horman
2024-02-01 14:24 ` Ravi Gunasekaran
2024-02-03 19:38 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240203193809.GA706477@kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=r-gunasekaran@ti.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.