From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Antoine Tenart <atenart@kernel.org>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH v2 net-next 15/16] bridge: use exit_batch_rtnl() method
Date: Sat, 3 Feb 2024 21:10:52 -0800 [thread overview]
Message-ID: <20240203211052.30905ae4@kernel.org> (raw)
In-Reply-To: <20240202174001.3328528-16-edumazet@google.com>
On Fri, 2 Feb 2024 17:40:00 +0000 Eric Dumazet wrote:
> exit_batch_rtnl() is called while RTNL is held,
> and devices to be unregistered can be queued in the dev_kill_list.
>
> This saves one rtnl_lock()/rtnl_unlock() pair per netns
> and one unregister_netdevice_many() call.
This one appears to cause a lot of crashes in the selftests:
https://netdev.bots.linux.dev/contest.html?branch=net-next-2024-02-03--21-00&pw-n=0&pass=0
Example crash:
https://netdev-2.bots.linux.dev/vmksft-bonding/results/449900/vm-crash-thr0-2
--
pw-bot: cr
next prev parent reply other threads:[~2024-02-04 5:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 17:39 [PATCH v2 net-next 00/16] net: more factorization in cleanup_net() paths Eric Dumazet
2024-02-02 17:39 ` [PATCH v2 net-next 01/16] net: add exit_batch_rtnl() method Eric Dumazet
2024-02-02 17:39 ` [PATCH v2 net-next 02/16] nexthop: convert nexthop_net_exit_batch to exit_batch_rtnl method Eric Dumazet
2024-02-02 17:39 ` [PATCH v2 net-next 03/16] net: convert default_device_exit_batch() " Eric Dumazet
2024-02-02 17:39 ` [PATCH v2 net-next 04/16] bareudp: use exit_batch_rtnl() method Eric Dumazet
2024-02-02 17:39 ` [PATCH v2 net-next 05/16] bonding: " Eric Dumazet
2024-02-02 19:34 ` Jay Vosburgh
2024-02-02 17:39 ` [PATCH v2 net-next 06/16] geneve: " Eric Dumazet
2024-02-02 17:39 ` [PATCH v2 net-next 07/16] gtp: " Eric Dumazet
2024-02-02 17:39 ` [PATCH v2 net-next 08/16] ipv4: add __unregister_nexthop_notifier() Eric Dumazet
2024-02-02 17:39 ` [PATCH v2 net-next 09/16] vxlan: use exit_batch_rtnl() method Eric Dumazet
2024-02-02 17:39 ` [PATCH v2 net-next 10/16] ip6_gre: " Eric Dumazet
2024-02-02 17:39 ` [PATCH v2 net-next 11/16] ip6_tunnel: " Eric Dumazet
2024-02-02 17:39 ` [PATCH v2 net-next 12/16] ip6_vti: " Eric Dumazet
2024-02-02 17:39 ` [PATCH v2 net-next 13/16] sit: " Eric Dumazet
2024-02-02 17:39 ` [PATCH v2 net-next 14/16] ip_tunnel: " Eric Dumazet
2024-02-02 17:40 ` [PATCH v2 net-next 15/16] bridge: " Eric Dumazet
2024-02-04 5:10 ` Jakub Kicinski [this message]
2024-02-04 10:15 ` Eric Dumazet
2024-02-02 17:40 ` [PATCH v2 net-next 16/16] xfrm: interface: " Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240203211052.30905ae4@kernel.org \
--to=kuba@kernel.org \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.