From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83FE0C133 for ; Mon, 5 Feb 2024 06:48:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707115712; cv=none; b=jj/VikMHYA0DUkLIyrl5w0a1ZApdBnAag63NBssjWfrKhpojk+9rDFZ0m5QUkLW10eWaBkHjQnn8bAeFZP96TUJjv31wkKgD39h63GAano+LoRUHnz1HwyRBdxlohThNqb5xw3I3xc0fQySMOax++Uq9SoYEQXMIgJxVK2KMX3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707115712; c=relaxed/simple; bh=1oG2K/BK5HBeoXuhf+478t+dkokO6s9sdayttYscpgQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YwTHeIvCXJFfsJXweoncwRIKImEOLwhvT4saDAm81iePyt9wFWLunsHw0nbsxJ1AitCweOOgUKUcupj/goZFnvkAtwaoB8t1NMslwQitN6DsKx8nrsnpAop2CNBaCbcADQgjSIYT35hEddb5uPCEVV7Tcj5tJD1BOth6CfxoXuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=beqkxcnQ; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="beqkxcnQ" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1d95d67ff45so25343055ad.2 for ; Sun, 04 Feb 2024 22:48:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707115710; x=1707720510; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=fZp49LWrBZvAva4h4qGlP855Yooh9hLpm+qn5WZrEI8=; b=beqkxcnQlwGJ77tElJL3w9cISU0GcgIYKENzc1v2xd3RShRLSCl+JrAHjpKeRtnPoV P1MlYe0S3jVmt3te63FiQtT3y3F9Hk4nSmrujGiTc2B80fd7cF0aMNdZluZwYjEEIn3+ AvjrCrJMOpRvcj6Pz3ci5AUolgxxllSy3sR58= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707115710; x=1707720510; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fZp49LWrBZvAva4h4qGlP855Yooh9hLpm+qn5WZrEI8=; b=tYK7xfVzJTHaQEKaPZPno89rSifIFA5iq+8H4I1KyOxHBi+NGcHcRwA8KFQlkZ7D+f Pdq6UwCxYnz4ZE6XvSF2JhAbgYOrl0v4LiANz9mKN5Sw4+BAhNYYyJLtyCctPZ1Givs6 LznaNuDd8wc49fxuPfBC+CopJ8Cc18qTz1/98DefBWX6RfTKeJmsi6Gzf2CmVS+WDSBV kKZ6fSRW3c9186prOa1pDJooDRCNqS/ZxtMG9zQwe/xYSKg9RdO+uhIR2rfv2/zmz27X /3RKSVrFhV0TeI7EJby53IXVBBRUSS4lebNj3QsBFLvsrRkLAqROdrry9Q7EIRvTXrBQ brOQ== X-Gm-Message-State: AOJu0YzGGtePTU4xDNs319Cmnx9wBtDXU75LMnVXUsrg+d49Ywar4pfh +IEhggIfpg3JzpvKrFDeyifs3NYpwENtywWZOhumE4bKDPd74giGQaeDCixQvA== X-Google-Smtp-Source: AGHT+IGnfOZtMxNg8h1qTb6hrvn7hMA+At3kcSMYu7DYozE4dM5cbZdvfqk/85wgP7frdmqklRop+Q== X-Received: by 2002:a17:902:e5ce:b0:1d9:a131:47a7 with SMTP id u14-20020a170902e5ce00b001d9a13147a7mr3301516plf.63.1707115710138; Sun, 04 Feb 2024 22:48:30 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXOlCQz0uICl2FN0MaWHy6oIw/UgIftw47P26HRWIH3JdDUdg+UBJ+ImwJVTtxPYBr50hnx8p1o1MI1qaBg53Seg3BIkhasGQv7pIOAMyDtk9CntBZOcYZlrdQ/hwmqgrnvd5PA27v7r5TCUEEYvLCzURBwxs/OE1UYcFphCuuv2F3lrRg7cKrTOOif3Z/ujshO9eTCYhlmH6ehN5JzDt0NxiHwSOlj9qI0seQG1Bca0M5l+DV7+ST72ntbVks07+entvdxvveqEeBDAWmtJ/K59JTKQ2o17IUSmQxKaCwKItzj9dsEFi27ERwU38tmH94wLRxG8/l7OH7GY+UI5cn6GpVFVBrIb0bJzSG+nP6qzGbHpuqy+qtmlRpOVxcmzDk6cDQuge7BTrddQVauCyiEqQ== Received: from google.com (KD124209171220.ppp-bb.dion.ne.jp. [124.209.171.220]) by smtp.gmail.com with ESMTPSA id ja11-20020a170902efcb00b001d8921f2058sm5523180plb.205.2024.02.04.22.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Feb 2024 22:48:29 -0800 (PST) Date: Mon, 5 Feb 2024 15:48:25 +0900 From: Sergey Senozhatsky To: Mark-PK Tsai =?utf-8?B?KOiUoeaym+WJmyk=?= Cc: "senozhatsky@chromium.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "axboe@kernel.dk" , "minchan@kernel.org" , "linux-arm-kernel@lists.infradead.org" , YJ Chiang =?utf-8?B?KOaxn+iLseadsCk=?= , "matthias.bgg@gmail.com" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH] zram: use copy_page for full page copy Message-ID: <20240205064825.GD69174@google.com> References: <20231007070554.8657-1-mark-pk.tsai@mediatek.com> <20231008043855.GA2738554@google.com> <99a493e1e906637a179a80b1f27a4b6bd2a0a671.camel@mediatek.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <99a493e1e906637a179a80b1f27a4b6bd2a0a671.camel@mediatek.com> On (24/02/05 06:43), Mark-PK Tsai (蔡沛剛) wrote: > On Sun, 2023-10-08 at 13:38 +0900, Sergey Senozhatsky wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > On (23/10/07 15:05), Mark-PK Tsai wrote: > > > > > > Some architectures, such as arm, have implemented > > > optimized copy_page for full page copying. > > > > > > Replace the full page memcpy with copy_page to > > > take advantage of the optimization. > > > > > > Signed-off-by: Mark-PK Tsai > > > > Reviewed-by: Sergey Senozhatsky > > I guess this patch may have been overlooked. > Could someone please help to review it? Oh, yes. Let me take care of that. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC47FC48291 for ; Mon, 5 Feb 2024 06:48:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JdDS+A5F1FugmIkmljt6476gPWfbaPib68o1gioUHY8=; b=yFgJVQz1smrV0J WxRiOJEU86dfNFcEYCp8Si2SveNzA4+qp4W3T3lJYB1HdHyPNHnEvUR81ZDUwpzWaqUVlrOEPb+Ik aDM87ix+UVG7lm3vB2eTuBiscCIXzF0TfjwXX3bIj2SGQ7U2V5ScLHqsnIEeOEnQ71CSf5qubKATQ SmoG8o0HN/wfLuLhspkhA/hAUqyW9eG5sy3eHjBqZRqPA34kw54DpKWOwtlaenf645fChmqEKy9xe kBE3y2F2OlLsOsNKkSq1AWXEzyprx0IB2SOY4EOdAwKWXHo1DyxKhTthkold0582IeOXEl43/qPrw HUOhnFu6eygYGX50KnvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWsmR-00000002CL9-3JRs; Mon, 05 Feb 2024 06:48:35 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWsmO-00000002CK0-2tEA for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 06:48:34 +0000 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1d95d67ff45so25343075ad.2 for ; Sun, 04 Feb 2024 22:48:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707115710; x=1707720510; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=fZp49LWrBZvAva4h4qGlP855Yooh9hLpm+qn5WZrEI8=; b=kk3B+HHGUaLSkHzKVDgcmJ4LNdhZlr4sbqRdXnBzU/Oav9Av3+yLtXyKdZab498UuA Dl58y42z6/vaprxlNPvJ0hc98ByUxhVSsnDSl4rJuFIueztvC5ysCuKuqo3kC0C01hkY dsJpxBuXug7hMbgXD5/q5aQ7jfOI5xkrfwK+M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707115710; x=1707720510; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fZp49LWrBZvAva4h4qGlP855Yooh9hLpm+qn5WZrEI8=; b=AkarkrOQ8bYhtkfO9T3nteeadwVPpbVCXl5OGkDK+GRK0BmLXHHoJDhOP4mIAfhvvN YF1KlQjjLP3mR0HLJ07aCnWBseXR9yW9PNfdFwJD9XHhX6lbzOoEcswlMUYcTUHeR2QI p2nmVD4WmvoNXT44sHDBGzMHKxt2mBPo36/kAZRk/bUHmL7ohbik/PPAV0i4RG0mky5f zEaUmVI2NYrXRZ6n7nYbfIlbjJryNwwIOjmSmMfoj+nMd2sBEqXMti4CIjOxYAFwuj8H DS/2KZOIZAoqPFamu6qurH9YkjJIDkxj3g9VjkhvsiUQG5EvsqXwIPJnuj3LA8rXseFI HRXg== X-Gm-Message-State: AOJu0YzFV1Py915+hP+dEqPlXBjWQsm0moG834eNmCquEiYWlo5QFtRQ eHGkFOAvcWbY9d28govL/otfN6G87WmAAO97ODstoBuOevRVkNN03cV0YwtRAQ== X-Google-Smtp-Source: AGHT+IGnfOZtMxNg8h1qTb6hrvn7hMA+At3kcSMYu7DYozE4dM5cbZdvfqk/85wgP7frdmqklRop+Q== X-Received: by 2002:a17:902:e5ce:b0:1d9:a131:47a7 with SMTP id u14-20020a170902e5ce00b001d9a13147a7mr3301516plf.63.1707115710138; Sun, 04 Feb 2024 22:48:30 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXOlCQz0uICl2FN0MaWHy6oIw/UgIftw47P26HRWIH3JdDUdg+UBJ+ImwJVTtxPYBr50hnx8p1o1MI1qaBg53Seg3BIkhasGQv7pIOAMyDtk9CntBZOcYZlrdQ/hwmqgrnvd5PA27v7r5TCUEEYvLCzURBwxs/OE1UYcFphCuuv2F3lrRg7cKrTOOif3Z/ujshO9eTCYhlmH6ehN5JzDt0NxiHwSOlj9qI0seQG1Bca0M5l+DV7+ST72ntbVks07+entvdxvveqEeBDAWmtJ/K59JTKQ2o17IUSmQxKaCwKItzj9dsEFi27ERwU38tmH94wLRxG8/l7OH7GY+UI5cn6GpVFVBrIb0bJzSG+nP6qzGbHpuqy+qtmlRpOVxcmzDk6cDQuge7BTrddQVauCyiEqQ== Received: from google.com (KD124209171220.ppp-bb.dion.ne.jp. [124.209.171.220]) by smtp.gmail.com with ESMTPSA id ja11-20020a170902efcb00b001d8921f2058sm5523180plb.205.2024.02.04.22.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Feb 2024 22:48:29 -0800 (PST) Date: Mon, 5 Feb 2024 15:48:25 +0900 From: Sergey Senozhatsky To: Mark-PK Tsai =?utf-8?B?KOiUoeaym+WJmyk=?= Cc: "senozhatsky@chromium.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "axboe@kernel.dk" , "minchan@kernel.org" , "linux-arm-kernel@lists.infradead.org" , YJ Chiang =?utf-8?B?KOaxn+iLseadsCk=?= , "matthias.bgg@gmail.com" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH] zram: use copy_page for full page copy Message-ID: <20240205064825.GD69174@google.com> References: <20231007070554.8657-1-mark-pk.tsai@mediatek.com> <20231008043855.GA2738554@google.com> <99a493e1e906637a179a80b1f27a4b6bd2a0a671.camel@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <99a493e1e906637a179a80b1f27a4b6bd2a0a671.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240204_224832_751877_498D4054 X-CRM114-Status: GOOD ( 14.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gKDI0LzAyLzA1IDA2OjQzKSwgTWFyay1QSyBUc2FpICjolKHmspvliZspIHdyb3RlOgo+IE9u IFN1biwgMjAyMy0xMC0wOCBhdCAxMzozOCArMDkwMCwgU2VyZ2V5IFNlbm96aGF0c2t5IHdyb3Rl Ogo+ID4gIAkgCj4gPiBFeHRlcm5hbCBlbWFpbCA6IFBsZWFzZSBkbyBub3QgY2xpY2sgbGlua3Mg b3Igb3BlbiBhdHRhY2htZW50cyB1bnRpbAo+ID4geW91IGhhdmUgdmVyaWZpZWQgdGhlIHNlbmRl ciBvciB0aGUgY29udGVudC4KPiA+ICBPbiAoMjMvMTAvMDcgMTU6MDUpLCBNYXJrLVBLIFRzYWkg d3JvdGU6Cj4gPiA+IAo+ID4gPiBTb21lIGFyY2hpdGVjdHVyZXMsIHN1Y2ggYXMgYXJtLCBoYXZl IGltcGxlbWVudGVkCj4gPiA+IG9wdGltaXplZCBjb3B5X3BhZ2UgZm9yIGZ1bGwgcGFnZSBjb3B5 aW5nLgo+ID4gPiAKPiA+ID4gUmVwbGFjZSB0aGUgZnVsbCBwYWdlIG1lbWNweSB3aXRoIGNvcHlf cGFnZSB0bwo+ID4gPiB0YWtlIGFkdmFudGFnZSBvZiB0aGUgb3B0aW1pemF0aW9uLgo+ID4gPiAK PiA+ID4gU2lnbmVkLW9mZi1ieTogTWFyay1QSyBUc2FpIDxtYXJrLXBrLnRzYWlAbWVkaWF0ZWsu Y29tPgo+ID4gCj4gPiBSZXZpZXdlZC1ieTogU2VyZ2V5IFNlbm96aGF0c2t5IDxzZW5vemhhdHNr eUBjaHJvbWl1bS5vcmc+Cj4gCj4gSSBndWVzcyB0aGlzIHBhdGNoIG1heSBoYXZlIGJlZW4gb3Zl cmxvb2tlZC4KPiBDb3VsZCBzb21lb25lIHBsZWFzZSBoZWxwIHRvIHJldmlldyBpdD8KCk9oLCB5 ZXMuIExldCBtZSB0YWtlIGNhcmUgb2YgdGhhdC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK