From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/gst1-plugins-bad: fix webrtcdsp plugin build
Date: Mon, 5 Feb 2024 11:57:37 +0100 [thread overview]
Message-ID: <20240205115737.74590ae9@windsurf> (raw)
In-Reply-To: <20240130192932.888169-1-james.hilliard1@gmail.com>
On Tue, 30 Jan 2024 12:29:32 -0700
James Hilliard <james.hilliard1@gmail.com> wrote:
> The webrtc-audio-processing package was bumped from version 0.3.1 to
> version 1.3 in commit ef0fa986eb7ff25c0a5db70ec0b62032e2d71538 which
> broke compatibility with the gst1-plugins-bad webrtcdsp plugin.
>
> To fix this backport a commit from upstream adding support for
> webrtc-audio-processing version 1.3 to gst1-plugins-bad.
>
> Fixes:
> output/build/gst1-plugins-bad-1.22.9/ext/webrtcdsp/meson.build:7:13: ERROR: Dependency "webrtc-audio-processing" not found, tried pkgconfig and cmake
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> ...e-code-for-webrtc-audio-processing-1.patch | 884 ++++++++++++++++++
> 1 file changed, 884 insertions(+)
> create mode 100644 package/gstreamer1/gst1-plugins-bad/0001-webrtcdsp-Update-code-for-webrtc-audio-processing-1.patch
Thanks for the investigation and fixing! The patch added was missing an
"Upstream:" tag, so I added that by slightly updating the reference to
the commit being backported. It's now applied to master. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-02-05 10:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 19:29 [Buildroot] [PATCH 1/1] package/gst1-plugins-bad: fix webrtcdsp plugin build James Hilliard
2024-02-05 10:57 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205115737.74590ae9@windsurf \
--to=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.