From: David Disseldorp <ddiss@suse.de>
To: fdmanana@kernel.org
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
Filipe Manana <fdmanana@suse.com>
Subject: Re: [PATCH 0/4] btrfs: make test pass or skip them when using nodatacow
Date: Mon, 5 Feb 2024 23:29:46 +1100 [thread overview]
Message-ID: <20240205232946.36d91920@echidna> (raw)
In-Reply-To: <cover.1706810184.git.fdmanana@suse.com>
On Thu, 1 Feb 2024 18:03:46 +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> Several test btrfs test cases fail when using "-o nodatacow" in MOUNT_OPTIONS.
> So fix that by either adapting the tests to pass or skip them if there's no
> way for them to succeed in nodatacow mode.
>
> Filipe Manana (4):
> btrfs: require no nodatacow for tests that exercise compression
> btrfs/173: make the test work when mounting with nodatacow
> btrfs/299: skip test if we were mounted with nodatacow
> btrfs: require no nodatacow for tests that exercise read repair
The double negative hurts my eyes, but these all look fine to me (one
minor nit in 2/4).
Reviewed-by: David Disseldorp <ddiss@suse.de>
prev parent reply other threads:[~2024-02-05 12:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 18:03 [PATCH 0/4] btrfs: make test pass or skip them when using nodatacow fdmanana
2024-02-01 18:03 ` [PATCH 1/4] btrfs: require no nodatacow for tests that exercise compression fdmanana
2024-02-01 18:03 ` [PATCH 2/4] btrfs/173: make the test work when mounting with nodatacow fdmanana
2024-02-05 12:26 ` David Disseldorp
2024-02-01 18:03 ` [PATCH 3/4] btrfs/299: skip test if we were mounted " fdmanana
2024-02-01 18:03 ` [PATCH 4/4] btrfs: require no nodatacow for tests that exercise read repair fdmanana
2024-02-05 12:29 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205232946.36d91920@echidna \
--to=ddiss@suse.de \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.