From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 387EAC48286 for ; Tue, 6 Feb 2024 08:23:44 +0000 (UTC) Received: from mailout4.zoneedit.com (mailout4.zoneedit.com [64.68.198.64]) by mx.groups.io with SMTP id smtpd.web10.17240.1707207815623893888 for ; Tue, 06 Feb 2024 00:23:36 -0800 Authentication-Results: mx.groups.io; dkim=none (message not signed); spf=pass (domain: denix.org, ip: 64.68.198.64, mailfrom: denis@denix.org) Received: from localhost (localhost [127.0.0.1]) by mailout4.zoneedit.com (Postfix) with ESMTP id E5F8E400CF; Tue, 6 Feb 2024 08:23:34 +0000 (UTC) Received: from mailout4.zoneedit.com ([127.0.0.1]) by localhost (zmo14-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lwKkRGec2gbi; Tue, 6 Feb 2024 08:23:34 +0000 (UTC) Received: from mail.denix.org (pool-100-15-87-159.washdc.fios.verizon.net [100.15.87.159]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout4.zoneedit.com (Postfix) with ESMTPSA id CE27540023; Tue, 6 Feb 2024 08:23:28 +0000 (UTC) Received: by mail.denix.org (Postfix, from userid 1000) id 7BB55163E0B; Tue, 6 Feb 2024 03:23:28 -0500 (EST) Date: Tue, 6 Feb 2024 03:23:28 -0500 From: Denys Dmytriyenko To: Res Sapp Cc: rs@ti.com, detheridge@ti.com, reatmon@ti.com, denys@konsulko.com, meta-ti@lists.yoctoproject.org Subject: Re: [meta-ti][master][PATCH] cairo: remove cairo append and include Message-ID: <20240206082328.GG15614@denix.org> References: <20240206000254.2916314-1-rs@ti.com> <20240206002757.GD15614@denix.org> <4281236a-08b6-4d91-9855-21ba43fd3345@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4281236a-08b6-4d91-9855-21ba43fd3345@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 06 Feb 2024 08:23:44 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/meta-ti/message/17448 On Tue, Feb 06, 2024 at 12:18:04AM -0600, Res Sapp wrote: > On 2/5/24 18:27, Denys Dmytriyenko wrote: > >NAK > > > >On Mon, Feb 05, 2024 at 06:02:54PM -0600, Randolph Sapp via lists.yoctoproject.org wrote: > >>From: Randolph Sapp > >> > >>Cairo versions >= 1.17.8 dropped all GL render backends entirely, > >>invalidating both the opengl and glesv2 PACKAGECONFIGS. As such this > >>override is no longer necessary. > >> > >>Signed-off-by: Randolph Sapp > >>--- > >> meta-ti-bsp/recipes-graphics/cairo/cairo_%.bbappend | 1 - > >> meta-ti-bsp/recipes-graphics/cairo/pvr-cairo.inc | 5 ----- > >> 2 files changed, 6 deletions(-) > >> delete mode 100644 meta-ti-bsp/recipes-graphics/cairo/cairo_%.bbappend > >> delete mode 100644 meta-ti-bsp/recipes-graphics/cairo/pvr-cairo.inc > >> > >>diff --git a/meta-ti-bsp/recipes-graphics/cairo/cairo_%.bbappend b/meta-ti-bsp/recipes-graphics/cairo/cairo_%.bbappend > >>deleted file mode 100644 > >>index 459d8d09..00000000 > >>--- a/meta-ti-bsp/recipes-graphics/cairo/cairo_%.bbappend > >>+++ /dev/null > >>@@ -1 +0,0 @@ > >>-require ${@bb.utils.contains_any('PREFERRED_PROVIDER_virtual/gpudriver', 'ti-img-rogue-driver ti-sgx-ddk-km', 'pvr-cairo.inc', '', d)} > >>diff --git a/meta-ti-bsp/recipes-graphics/cairo/pvr-cairo.inc b/meta-ti-bsp/recipes-graphics/cairo/pvr-cairo.inc > >>deleted file mode 100644 > >>index b41f1a01..00000000 > >>--- a/meta-ti-bsp/recipes-graphics/cairo/pvr-cairo.inc > >>+++ /dev/null > >>@@ -1,5 +0,0 @@ > >>-# This is required since cairo expects the opengl distro feature to refer to > >>-# the desktop version of OpenGL. Imagination drivers only provide OpenGLES. > >>- > >>-PACKAGECONFIG:remove = "opengl" > >>-PACKAGECONFIG:append = " glesv2" > >>-- > >>2.43.0 > > Alright, what's wrong with it? Oe-core is currently using cairo > 1.18, this append currently just introduces a warning. Are you > already carrying this in a private branch? https://patchwork.yoctoproject.org/project/ti/patch/20240201173635.2591975-1-denis@denix.org/ Seems there's a bit of a backlog for master... -- Denys