From: Florian Westphal <fw@strlen.de>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Florian Westphal <fw@strlen.de>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, andrea.mattiazzo@suse.com
Subject: Re: [PATCH net] netfilter: nf_tables: fix pointer math issue in nft_byteorder_eval()
Date: Tue, 6 Feb 2024 12:11:12 +0100 [thread overview]
Message-ID: <20240206111112.GD17626@breakpoint.cc> (raw)
In-Reply-To: <20240206104336.ctigqpkunom2ufmn@lion.mk-sys.cz>
Michal Kubecek <mkubecek@suse.cz> wrote:
> I stumbled upon this when the issue got a CVE id (sigh) and I share
> Andrea's (Cc-ed) concern that the fix is incomplete. While the fix,
> commit c301f0981fdd ("netfilter: nf_tables: fix pointer math issue in
> nft_byteorder_eval()") now, fixes the destination side, src is still
> a pointer to u32, i.e. we are reading 64-bit values with relative
> offsets which are multiples of 32 bits.
>
> Shouldn't we fix this as well, e.g. like indicated below?
No, please remove multi-elem support instead, nothing uses this feature.
next prev parent reply other threads:[~2024-02-06 11:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 6:42 [PATCH net] netfilter: nf_tables: fix pointer math issue in nft_byteorder_eval() Dan Carpenter
2023-11-03 9:18 ` Florian Westphal
2023-11-03 9:45 ` Pablo Neira Ayuso
2023-11-03 10:25 ` Florian Westphal
2024-02-06 10:43 ` Michal Kubecek
2024-02-06 11:04 ` Dan Carpenter
2024-02-06 11:09 ` Michal Kubecek
2024-02-06 11:11 ` Florian Westphal [this message]
2024-02-06 11:29 ` Pablo Neira Ayuso
2024-02-06 11:30 ` [netfilter-core] " Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240206111112.GD17626@breakpoint.cc \
--to=fw@strlen.de \
--cc=andrea.mattiazzo@suse.com \
--cc=coreteam@netfilter.org \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kadlec@netfilter.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.