From: Petr Vorel <pvorel@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] settimeofday02:Simplify test using TST_ macros
Date: Tue, 6 Feb 2024 12:18:49 +0100 [thread overview]
Message-ID: <20240206111849.GD270992@pevik> (raw)
In-Reply-To: <20240203051901.3000-2-xuyang2018.jy@fujitsu.com>
Hi Yang Xu,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
LGTM
nit: subject could be "settimeofday02: Simplify test using TST_ macros"
(missing space behind : - readability)
nit: git metadata as you as author have \ escapes:
Yang Xu \(Fujitsu\) <xuyang2018.jy@fujitsu.com>
It looks like you had it long time ago:
https://patchwork.ozlabs.org/project/ltp/list/?submitter=81371&state=*
Could you fix it as it breaks also credit counting before next release?
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-02-06 11:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 5:19 [LTP] [PATCH 1/2] settimeofday01: Convert doc to docparse Yang Xu via ltp
2024-02-03 5:19 ` [LTP] [PATCH 2/2] settimeofday02:Simplify test using TST_ macros Yang Xu via ltp
2024-02-06 11:18 ` Petr Vorel [this message]
2024-02-08 6:53 ` Yang Xu (Fujitsu) via ltp
2024-02-08 8:46 ` Petr Vorel
2024-02-08 8:56 ` Petr Vorel
2024-02-06 11:20 ` [LTP] [PATCH 1/2] settimeofday01: Convert doc to docparse Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240206111849.GD270992@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.