From: Simon Horman <horms@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>, Liang Li <liali@redhat.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH net] selftests: bonding: fix macvlan2's namespace name
Date: Tue, 6 Feb 2024 15:35:15 +0000 [thread overview]
Message-ID: <20240206153515.GE1104779@kernel.org> (raw)
In-Reply-To: <20240204083828.1511334-1-liuhangbin@gmail.com>
On Sun, Feb 04, 2024 at 04:38:28PM +0800, Hangbin Liu wrote:
> The m2's ns name should be m2-xxxxxx, not m1.
>
> Fixes: 246af950b940 ("selftests: bonding: add macvlan over bond testing")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Hi Hangbin Liu,
I agree this is a nice change.
But it is not clear to me that this is fixing a bug.
> ---
> tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh b/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh
> index dc99e4ac262e..969bf9af1b94 100755
> --- a/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh
> +++ b/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh
> @@ -7,7 +7,7 @@ lib_dir=$(dirname "$0")
> source ${lib_dir}/bond_topo_2d1c.sh
>
> m1_ns="m1-$(mktemp -u XXXXXX)"
> -m2_ns="m1-$(mktemp -u XXXXXX)"
> +m2_ns="m2-$(mktemp -u XXXXXX)"
> m1_ip4="192.0.2.11"
> m1_ip6="2001:db8::11"
> m2_ip4="192.0.2.12"
> --
> 2.43.0
>
>
next prev parent reply other threads:[~2024-02-06 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 8:38 [PATCH net] selftests: bonding: fix macvlan2's namespace name Hangbin Liu
2024-02-06 15:35 ` Simon Horman [this message]
2024-02-07 1:21 ` Jakub Kicinski
2024-02-07 1:45 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240206153515.GE1104779@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=kuba@kernel.org \
--cc=liali@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.