Re: [PATCH] net: ethernet: remove duplicated CONFIG_SUNGEM_PHY entry

[Simon Horman <horms@kernel.org>]

On Sun, Feb 04, 2024 at 09:31:51PM +0900, Masahiro Yamada wrote:
> Both drivers/net/Kconfig and drivers/net/ethernet/Kconfig contain the
> same config entry:
> 
>   config SUNGEM_PHY
>           tristate
> 
> Commit f860b0522f65 ("drivers/net: Kconfig and Makefile cleanup") moved
> SUNGEM_PHY from drivers/net/Kconfig to drivers/net/ethernet/Kconfig.
> 
> Shortly after it was applied, commit 19e2f6fe9601 ("net: Fix sungem_phy
> sharing.") added the second one to drivers/net/Kconfig.
> 
> I kept the one in drivers/net/Kconfig because this CONFIG option controls
> the compilation of drivers/net/sungem_phy.c.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Thanks Yamada-san,

This looks good to me as-is,
but I guess a follow-up question is if sungem_phy.c
should move to drivers/net/phy.

Reviewed-by: Simon Horman <horms@kernel.org>

> ---
> 
>  drivers/net/ethernet/Kconfig | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/Kconfig b/drivers/net/ethernet/Kconfig
> index 5a274b99f299..6a19b5393ed1 100644
> --- a/drivers/net/ethernet/Kconfig
> +++ b/drivers/net/ethernet/Kconfig
> @@ -15,9 +15,6 @@ if ETHERNET
>  config MDIO
>  	tristate
>  
> -config SUNGEM_PHY
> -	tristate
> -
>  source "drivers/net/ethernet/3com/Kconfig"
>  source "drivers/net/ethernet/actions/Kconfig"
>  source "drivers/net/ethernet/adaptec/Kconfig"
> -- 
> 2.40.1
> 
>