From: Simon Horman <horms@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Jon Maloy <jmaloy@redhat.com>,
Ying Xue <ying.xue@windriver.com>,
linux-kernel@vger.kernel.org,
tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH] net: tipc: remove redundant 'bool' from CONFIG_TIPC_{MEDIA_UDP,CRYPTO}
Date: Tue, 6 Feb 2024 17:56:14 +0000 [thread overview]
Message-ID: <20240206175614.GG1104779@kernel.org> (raw)
In-Reply-To: <20240204131226.57865-1-masahiroy@kernel.org>
On Sun, Feb 04, 2024 at 10:12:26PM +0900, Masahiro Yamada wrote:
> The 'bool' is already specified for these options.
>
> The second 'bool' under the help message is redundant.
>
> While I am here, I moved 'default y' above, as it is common to place
> the help text last.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Thanks Yamada-san,
this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-02-06 17:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 13:12 [PATCH] net: tipc: remove redundant 'bool' from CONFIG_TIPC_{MEDIA_UDP,CRYPTO} Masahiro Yamada
2024-02-04 15:43 ` Randy Dunlap
2024-02-06 17:56 ` Simon Horman [this message]
2024-02-07 13:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240206175614.GG1104779@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jmaloy@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.