From: Simon Horman <horms@kernel.org>
To: Amit Cohen <amcohen@nvidia.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, daniel@iogearbox.net, mlxsw@nvidia.com,
Ido Schimmel <idosch@nvidia.com>, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next] net: Do not return value from init_dummy_netdev()
Date: Tue, 6 Feb 2024 20:46:22 +0000 [thread overview]
Message-ID: <20240206204622.GJ1104779@kernel.org> (raw)
In-Reply-To: <20240205103022.440946-1-amcohen@nvidia.com>
On Mon, Feb 05, 2024 at 12:30:22PM +0200, Amit Cohen wrote:
> init_dummy_netdev() always returns zero and all the callers do not check
> the returned value. Set the function to not return value, as it is not
> really used today.
>
> Signed-off-by: Amit Cohen <amcohen@nvidia.com>
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-02-06 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 10:30 [PATCH net-next] net: Do not return value from init_dummy_netdev() Amit Cohen
2024-02-06 20:46 ` Simon Horman [this message]
2024-02-07 17:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240206204622.GJ1104779@kernel.org \
--to=horms@kernel.org \
--cc=amcohen@nvidia.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.