From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Nicolin Chen <nicolinc@nvidia.com>
Cc: Yi Liu <yi.l.liu@intel.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Longfang Liu <liulongfang@huawei.com>,
Yan Zhao <yan.y.zhao@intel.com>,
Joel Granados <j.granados@samsung.com>,
iommu@lists.linux.dev, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, Lu Baolu <baolu.lu@linux.intel.com>,
Jason Gunthorpe <jgg@nvidia.com>
Subject: [PATCH v12 03/16] iommu: Remove unrecoverable fault data
Date: Wed, 7 Feb 2024 09:33:12 +0800 [thread overview]
Message-ID: <20240207013325.95182-4-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20240207013325.95182-1-baolu.lu@linux.intel.com>
The unrecoverable fault data is not used anywhere. Remove it to avoid
dead code.
Suggested-by: Kevin Tian <kevin.tian@intel.com>
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Tested-by: Yan Zhao <yan.y.zhao@intel.com>
Tested-by: Longfang Liu <liulongfang@huawei.com>
---
include/linux/iommu.h | 72 ++-----------------------------------------
1 file changed, 2 insertions(+), 70 deletions(-)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 472a8ce029b1..c960c4fae3bc 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -50,67 +50,7 @@ struct iommu_dma_cookie;
/* Generic fault types, can be expanded IRQ remapping fault */
enum iommu_fault_type {
- IOMMU_FAULT_DMA_UNRECOV = 1, /* unrecoverable fault */
- IOMMU_FAULT_PAGE_REQ, /* page request fault */
-};
-
-enum iommu_fault_reason {
- IOMMU_FAULT_REASON_UNKNOWN = 0,
-
- /* Could not access the PASID table (fetch caused external abort) */
- IOMMU_FAULT_REASON_PASID_FETCH,
-
- /* PASID entry is invalid or has configuration errors */
- IOMMU_FAULT_REASON_BAD_PASID_ENTRY,
-
- /*
- * PASID is out of range (e.g. exceeds the maximum PASID
- * supported by the IOMMU) or disabled.
- */
- IOMMU_FAULT_REASON_PASID_INVALID,
-
- /*
- * An external abort occurred fetching (or updating) a translation
- * table descriptor
- */
- IOMMU_FAULT_REASON_WALK_EABT,
-
- /*
- * Could not access the page table entry (Bad address),
- * actual translation fault
- */
- IOMMU_FAULT_REASON_PTE_FETCH,
-
- /* Protection flag check failed */
- IOMMU_FAULT_REASON_PERMISSION,
-
- /* access flag check failed */
- IOMMU_FAULT_REASON_ACCESS,
-
- /* Output address of a translation stage caused Address Size fault */
- IOMMU_FAULT_REASON_OOR_ADDRESS,
-};
-
-/**
- * struct iommu_fault_unrecoverable - Unrecoverable fault data
- * @reason: reason of the fault, from &enum iommu_fault_reason
- * @flags: parameters of this fault (IOMMU_FAULT_UNRECOV_* values)
- * @pasid: Process Address Space ID
- * @perm: requested permission access using by the incoming transaction
- * (IOMMU_FAULT_PERM_* values)
- * @addr: offending page address
- * @fetch_addr: address that caused a fetch abort, if any
- */
-struct iommu_fault_unrecoverable {
- __u32 reason;
-#define IOMMU_FAULT_UNRECOV_PASID_VALID (1 << 0)
-#define IOMMU_FAULT_UNRECOV_ADDR_VALID (1 << 1)
-#define IOMMU_FAULT_UNRECOV_FETCH_ADDR_VALID (1 << 2)
- __u32 flags;
- __u32 pasid;
- __u32 perm;
- __u64 addr;
- __u64 fetch_addr;
+ IOMMU_FAULT_PAGE_REQ = 1, /* page request fault */
};
/**
@@ -142,19 +82,11 @@ struct iommu_fault_page_request {
/**
* struct iommu_fault - Generic fault data
* @type: fault type from &enum iommu_fault_type
- * @padding: reserved for future use (should be zero)
- * @event: fault event, when @type is %IOMMU_FAULT_DMA_UNRECOV
* @prm: Page Request message, when @type is %IOMMU_FAULT_PAGE_REQ
- * @padding2: sets the fault size to allow for future extensions
*/
struct iommu_fault {
__u32 type;
- __u32 padding;
- union {
- struct iommu_fault_unrecoverable event;
- struct iommu_fault_page_request prm;
- __u8 padding2[56];
- };
+ struct iommu_fault_page_request prm;
};
/**
--
2.34.1
next prev parent reply other threads:[~2024-02-07 1:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 1:33 [PATCH v12 00/16] iommu: Prepare to deliver page faults to user space Lu Baolu
2024-02-07 1:33 ` [PATCH v12 01/16] iommu: Move iommu fault data to linux/iommu.h Lu Baolu
2024-02-07 1:33 ` [PATCH v12 02/16] iommu/arm-smmu-v3: Remove unrecoverable faults reporting Lu Baolu
2024-02-07 1:33 ` Lu Baolu [this message]
2024-02-07 1:33 ` [PATCH v12 04/16] iommu: Cleanup iopf data structure definitions Lu Baolu
2024-02-07 1:33 ` [PATCH v12 05/16] iommu: Merge iopf_device_param into iommu_fault_param Lu Baolu
2024-02-07 1:33 ` [PATCH v12 06/16] iommu: Remove iommu_[un]register_device_fault_handler() Lu Baolu
2024-02-07 1:33 ` [PATCH v12 07/16] iommu: Merge iommu_fault_event and iopf_fault Lu Baolu
2024-02-07 1:33 ` [PATCH v12 08/16] iommu: Prepare for separating SVA and IOPF Lu Baolu
2024-02-07 1:33 ` [PATCH v12 09/16] iommu: Make iommu_queue_iopf() more generic Lu Baolu
2024-02-07 1:33 ` [PATCH v12 10/16] iommu: Separate SVA and IOPF Lu Baolu
2024-02-07 1:33 ` [PATCH v12 11/16] iommu: Refine locking for per-device fault data management Lu Baolu
2024-02-07 1:33 ` [PATCH v12 12/16] iommu: Use refcount for fault data access Lu Baolu
2024-02-07 1:33 ` [PATCH v12 13/16] iommu: Improve iopf_queue_remove_device() Lu Baolu
2024-02-07 2:50 ` Tian, Kevin
2024-02-07 12:29 ` Baolu Lu
2024-02-07 17:59 ` Vasant Hegde
2024-02-08 1:32 ` Baolu Lu
2024-02-08 5:06 ` Vasant Hegde
2024-02-07 1:33 ` [PATCH v12 14/16] iommu: Track iopf group instead of last fault Lu Baolu
2024-02-07 1:33 ` [PATCH v12 15/16] iommu: Make iopf_group_response() return void Lu Baolu
2024-02-07 1:33 ` [PATCH v12 16/16] iommu: Make iommu_report_device_fault() " Lu Baolu
2024-02-08 9:11 ` [PATCH v12 00/16] iommu: Prepare to deliver page faults to user space Zhangfei Gao
[not found] ` <CABQgh9H02z+uHg_hYnoVZURz7PLeYW_41MwxciE6W+kPRgEHsw@mail.gmail.com>
2024-02-09 2:39 ` Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240207013325.95182-4-baolu.lu@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=j.granados@samsung.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jean-philippe@linaro.org \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liulongfang@huawei.com \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yan.y.zhao@intel.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.