From: Simon Horman <horms@kernel.org>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mlx5: remove redundant assignment to variable object_range
Date: Wed, 7 Feb 2024 09:48:08 +0000 [thread overview]
Message-ID: <20240207094808.GO1104779@kernel.org> (raw)
In-Reply-To: <20240206165815.2420951-1-colin.i.king@gmail.com>
On Tue, Feb 06, 2024 at 04:58:15PM +0000, Colin Ian King wrote:
> The variable object_range to log_header_modify_argument_granularity
> is being assigned a value that is never read, the following statement
> assigns object_range to the max of log_header_modify_argument_granularity
> and DR_ICM_MODIFY_HDR_GRANULARITY_4K, so clearly the initial
> assignment is redundant. Remove it.
>
> Cleans up clang-scan build warning:
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_arg.c:42:2: warning:
> Value stored to 'object_range' is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Thanks Colin,
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2024-02-07 9:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 16:58 [PATCH] net/mlx5: remove redundant assignment to variable object_range Colin Ian King
2024-02-07 9:48 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240207094808.GO1104779@kernel.org \
--to=horms@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.