From: Jakub Kicinski <kuba@kernel.org>
To: Elad Nachman <enachman@marvell.com>
Cc: "Köry Maincent" <kory.maincent@bootlin.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Taras Chornyi" <taras.chornyi@plvision.eu>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>
Subject: Re: [EXT] Prestera driver fail to probe twice
Date: Wed, 7 Feb 2024 10:31:35 -0800 [thread overview]
Message-ID: <20240207103135.33e01d2d@kernel.org> (raw)
In-Reply-To: <BN9PR18MB42516CB6F1DA53D8BAD47B17DB452@BN9PR18MB4251.namprd18.prod.outlook.com>
On Wed, 7 Feb 2024 15:06:34 +0000 Elad Nachman wrote:
> MAGIC value is cleared after FW is downloaded to RAM, just before it is executed.
> So checking the MAGIC value to determine if the firmware is running is useless.
>
> You will get the MAGIC value read correctly only when firmware is
> during the download process, which does not help you implementing the
> logic you want.
I'm not aware of other networking drivers which cannot be reloaded /
rebound. I think it's part of base expectations for upstream drivers.
Could you work on fixing this?
IIRC we have enum devlink_param_reset_dev_on_drv_probe_value to control
whether device is always reset on driver load. You can make resetting
an opt-in if you're concerned about backward compatibility.
next prev parent reply other threads:[~2024-02-07 18:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 15:54 Prestera driver fail to probe twice Köry Maincent
2024-02-06 18:30 ` [EXT] " Elad Nachman
2024-02-07 10:22 ` Köry Maincent
2024-02-07 10:56 ` Elad Nachman
2024-02-07 11:28 ` Köry Maincent
2024-02-07 12:24 ` Elad Nachman
2024-02-07 14:31 ` Köry Maincent
2024-02-07 15:06 ` Elad Nachman
2024-02-07 18:31 ` Jakub Kicinski [this message]
2024-02-08 7:36 ` Elad Nachman
2024-02-08 15:37 ` Jakub Kicinski
2024-02-13 0:29 ` Jakub Kicinski
2024-02-07 23:32 ` Andrew Lunn
2024-02-08 9:10 ` Köry Maincent
2024-02-08 14:56 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240207103135.33e01d2d@kernel.org \
--to=kuba@kernel.org \
--cc=enachman@marvell.com \
--cc=kory.maincent@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=taras.chornyi@plvision.eu \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.