From: Lee Jones <lee@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, linux-leds@vger.kernel.org
Subject: Re: (subset) [PATCH] leds: trigger: stop exporting trigger_list
Date: Thu, 8 Feb 2024 10:45:55 +0000 [thread overview]
Message-ID: <20240208104555.GH689448@google.com> (raw)
In-Reply-To: <648b58db-6fb0-4b9e-8d63-ecf193f2e38a@gmail.com>
On Thu, 08 Feb 2024, Heiner Kallweit wrote:
> On 08.02.2024 11:23, Lee Jones wrote:
> > On Thu, 08 Feb 2024, Lee Jones wrote:
> >
> >> On Wed, 31 Jan 2024 15:30:53 +0100, Heiner Kallweit wrote:
> >>> 682e98564ffb ("leds: trigger: panic: Simplify led_trigger_set_panic")
> >>> removed the last external user of variable trigger_list. So stop
> >>> exporting it.
> >>> If in future a need should arise again to access this variable, I think
> >>> we better add some accessor instead of exporting the variable directly.
> >>>
> >>>
> >>> [...]
> >>
> >> Applied, thanks!
> >>
> >> [1/1] leds: trigger: stop exporting trigger_list
> >> commit: 6171582edb46889769d994cca81cf0f0fdd8c66f
> >
> > I fixed the chechpatch.pl error for you and changed the subject line to
> > match the format expected by the LED subsystem. Please correct these
> > yourself in subsequent contributions. Thanks.
> >
> Sure. What was wrong with subject line?
Descriptions after the `leds: <device>:` start with an uppercase char.
It's nitty, but consistency helps me sleep at night! :)
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-02-08 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 14:30 [PATCH] leds: trigger: stop exporting trigger_list Heiner Kallweit
2024-02-08 10:22 ` (subset) " Lee Jones
2024-02-08 10:23 ` Lee Jones
2024-02-08 10:43 ` Heiner Kallweit
2024-02-08 10:45 ` Lee Jones [this message]
2024-02-08 10:51 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240208104555.GH689448@google.com \
--to=lee@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.