From: Jakub Kicinski <kuba@kernel.org>
To: Sai Krishna <saikrishnag@marvell.com>
Cc: <richardcochran@gmail.com>, <horms@kernel.org>,
<vinicius.gomes@intel.com>, <vadim.fedorenko@linux.dev>,
<davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <sgoutham@marvell.com>,
<gakula@marvell.com>, <lcherian@marvell.com>,
<hkelam@marvell.com>, <sbhatta@marvell.com>,
Naveen Mamindlapalli <naveenm@marvell.com>
Subject: Re: [net-next PATCH v2] octeontx2: Add PTP clock driver for Octeon PTM clock.
Date: Thu, 8 Feb 2024 18:51:30 -0800 [thread overview]
Message-ID: <20240208185130.23509cb3@kernel.org> (raw)
In-Reply-To: <20240206181009.1143910-1-saikrishnag@marvell.com>
On Tue, 6 Feb 2024 23:40:09 +0530 Sai Krishna wrote:
> The PCIe PTM(Precision time measurement) protocol provides precise
> coordination of events across multiple components like PCIe host
> clock, PCIe EP PHC local clocks of PCIe devices. This patch adds
> support for ptp clock based PTM clock. We can use this PTP device
> to sync the PTM time with CLOCK_REALTIME or other PTP PHC
> devices using phc2sys.
A bit of an odd driver, somewhat similar to what Amazon described.
You register a PTP clock but there's no PTP involved. Also you call
pci_get_device() instead of binding to a proper bus.
Please repost this, add linux-pci and the PCI maintainers to the CC.
It'd be great to get their acks (in addition to Richard's).
--
pw-bot: cr
next prev parent reply other threads:[~2024-02-09 2:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 18:10 [net-next PATCH v2] octeontx2: Add PTP clock driver for Octeon PTM clock Sai Krishna
2024-02-09 2:51 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-02-14 13:08 Sai Krishna
2024-02-14 17:28 ` Bjorn Helgaas
2024-02-26 15:40 ` Sai Krishna Gajula
2024-02-26 17:00 ` Bjorn Helgaas
2024-02-28 12:37 ` Sai Krishna Gajula
2024-02-28 16:08 ` Bjorn Helgaas
2024-02-29 4:57 ` Sai Krishna Gajula
2024-02-29 15:03 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240208185130.23509cb3@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=horms@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveenm@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=saikrishnag@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.