From: Jakub Kicinski <kuba@kernel.org>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<brett.creeley@amd.com>, <drivers@pensando.io>
Subject: Re: [PATCH v2 net-next 01/10] ionic: minimal work with 0 budget
Date: Fri, 9 Feb 2024 14:09:35 -0800 [thread overview]
Message-ID: <20240209140935.4230d626@kernel.org> (raw)
In-Reply-To: <20240208005725.65134-2-shannon.nelson@amd.com>
On Wed, 7 Feb 2024 16:57:16 -0800 Shannon Nelson wrote:
> We should be doing as little as possible besides freeing Tx
> space when our napi routines are called with budget of 0, so
> jump out before doing anything besides Tx cleaning.
>
> See commit afbed3f74830 ("net/mlx5e: do as little as possible in napi
> poll when budget is 0") for more info.
Unfortunately to commit you quote proves that this is a real bug which
can crash a non trivial number of machines if kernel printks meet an XDP
workload :( This really should go to net.
next prev parent reply other threads:[~2024-02-09 22:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 0:57 [PATCH v2 net-next 00/10] ionic: add XDP support Shannon Nelson
2024-02-08 0:57 ` [PATCH v2 net-next 01/10] ionic: minimal work with 0 budget Shannon Nelson
2024-02-09 22:09 ` Jakub Kicinski [this message]
2024-02-09 23:33 ` Nelson, Shannon
2024-02-08 0:57 ` [PATCH v2 net-next 02/10] ionic: set adminq irq affinity Shannon Nelson
2024-02-08 0:57 ` [PATCH v2 net-next 03/10] ionic: add helpers for accessing buffer info Shannon Nelson
2024-02-08 0:57 ` [PATCH v2 net-next 04/10] ionic: use dma range APIs Shannon Nelson
2024-02-08 0:57 ` [PATCH v2 net-next 05/10] ionic: add initial framework for XDP support Shannon Nelson
2024-02-08 0:57 ` [PATCH v2 net-next 06/10] ionic: Add XDP packet headroom Shannon Nelson
2024-02-08 0:57 ` [PATCH v2 net-next 07/10] ionic: Add XDP_TX support Shannon Nelson
2024-02-08 0:57 ` [PATCH v2 net-next 08/10] ionic: Add XDP_REDIRECT support Shannon Nelson
2024-02-08 0:57 ` [PATCH v2 net-next 09/10] ionic: add ndo_xdp_xmit Shannon Nelson
2024-02-08 0:57 ` [PATCH v2 net-next 10/10] ionic: implement xdp frags support Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209140935.4230d626@kernel.org \
--to=kuba@kernel.org \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.