From: kernel test robot <lkp@intel.com>
To: Anna-Maria Behnsen <anna-maria@linutronix.de>
Cc: oe-kbuild-all@lists.linux.dev, Frederic Weisbecker <frederic@kernel.org>
Subject: [frederic-dynticks:timers/anna 23/29] kernel/time/timer_migration.c:1379: warning: Function parameter or struct member 'nextevt' not described in 'tmigr_quick_check'
Date: Sat, 10 Feb 2024 13:09:14 +0800 [thread overview]
Message-ID: <202402101310.rPIZXVPJ-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git timers/anna
head: 9a654aebd02182bcaff7e5a26b632ee20a1536ad
commit: a7631399e1db94d34d3cc5bae11e1bfcbb02db30 [23/29] do not forget quick check
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20240210/202402101310.rPIZXVPJ-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240210/202402101310.rPIZXVPJ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402101310.rPIZXVPJ-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> kernel/time/timer_migration.c:1379: warning: Function parameter or struct member 'nextevt' not described in 'tmigr_quick_check'
>> kernel/time/timer_migration.c:1379: warning: Excess function parameter 'nextexp' description in 'tmigr_quick_check'
vim +1379 kernel/time/timer_migration.c
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1359
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1360 /**
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1361 * tmigr_quick_check() - Quick forecast of next tmigr event when CPU wants to
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1362 * go idle
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1363 * @nextexp: The next global timer expiry of the current CPU
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1364 *
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1365 * Return:
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1366 * * KTIME_MAX - when it is probable that nothing has to be done (not
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1367 * the only one in the level 0 group; and if it is the
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1368 * only one in level 0 group, but there are more than a
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1369 * single group active on the way to top level)
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1370 * * nextevt - when CPU is offline and has to handle timer on his own
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1371 * or when on the way to top in every group only a single
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1372 * child is active and but @nextevt is before next_expiry
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1373 * of top level group
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1374 * * next_expiry (top) - value of top level group, when on the way to top in
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1375 * every group only a single child is active and @nextevt
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1376 * is after this value active child.
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1377 */
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1378 u64 tmigr_quick_check(u64 nextevt)
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 @1379 {
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1380 struct tmigr_cpu *tmc = this_cpu_ptr(&tmigr_cpu);
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1381 struct tmigr_group *group = tmc->tmgroup;
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1382
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1383 if (tmigr_is_not_available(tmc))
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1384 return nextevt;
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1385
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1386 if (WARN_ON_ONCE(tmc->idle))
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1387 return nextevt;
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1388
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1389 if (!tmigr_check_migrator_and_lonely(tmc->tmgroup, tmc->childmask))
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1390 return KTIME_MAX;
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1391
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1392 do {
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1393 if (!tmigr_check_lonely(group)) {
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1394 return KTIME_MAX;
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1395 } else if (!group->parent) {
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1396 u64 first_global = READ_ONCE(group->next_expiry);
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1397 return min_t(u64, nextevt, first_global);
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1398 }
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1399 group = group->parent;
a7631399e1db94 Anna-Maria Behnsen 2024-02-09 1400 } while (group);
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1401
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1402 return KTIME_MAX;
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1403 }
0a3bafadcf1c9d Anna-Maria Behnsen 2024-02-09 1404
:::::: The code at line 1379 was first introduced by commit
:::::: 0a3bafadcf1c9d0de98b840e6e906e8f86167a12 timers: Implement the hierarchical pull model
:::::: TO: Anna-Maria Behnsen <anna-maria@linutronix.de>
:::::: CC: Frederic Weisbecker <frederic@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-02-10 5:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202402101310.rPIZXVPJ-lkp@intel.com \
--to=lkp@intel.com \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.