From: Jonathan Cameron <jic23@kernel.org>
To: Alisa-Dariana Roman <alisadariana@gmail.com>
Cc: alexandru.tachici@analog.com, alisa.roman@analog.com,
conor+dt@kernel.org, devicetree@vger.kernel.org,
dlechner@baylibre.com, krzysztof.kozlowski+dt@linaro.org,
krzysztof.kozlowski@linaro.org, lars@metafoo.de,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
michael.hennerich@analog.com, robh+dt@kernel.org
Subject: Re: [PATCH v3 3/5] iio: adc: ad7192: Use standard attribute
Date: Sat, 10 Feb 2024 15:52:26 +0000 [thread overview]
Message-ID: <20240210155226.5e509845@jic23-huawei> (raw)
In-Reply-To: <20240208172459.280189-4-alisa.roman@analog.com>
On Thu, 8 Feb 2024 19:24:57 +0200
Alisa-Dariana Roman <alisadariana@gmail.com> wrote:
> Replace custom attribute filter_low_pass_3db_frequency_available with
> standard attribute.
>
> Store the available values in ad7192_state struct.
>
> The function that used to compute those values replaced by
> ad7192_update_filter_freq_avail().
>
> Function ad7192_show_filter_avail() is no longer needed.
>
> Note that the initial available values are hardcoded.
>
> Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com>
Looks good. Thanks for tidying this up.
I've nothing to add to other reviews that have already come in for v3.
Thanks,
Jonathan
next prev parent reply other threads:[~2024-02-10 15:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 17:24 [PATCH v3 0/5] iio: adc: ad7192: Add support for AD7194 Alisa-Dariana Roman
2024-02-08 17:24 ` [PATCH v3 1/5] iio: adc: ad7192: Use device api Alisa-Dariana Roman
2024-02-08 18:20 ` Andy Shevchenko
2024-02-08 17:24 ` [PATCH v3 2/5] iio: adc: ad7192: Pass state directly Alisa-Dariana Roman
2024-02-08 17:24 ` [PATCH v3 3/5] iio: adc: ad7192: Use standard attribute Alisa-Dariana Roman
2024-02-10 15:52 ` Jonathan Cameron [this message]
2024-02-08 17:24 ` [PATCH v3 4/5] dt-bindings: iio: adc: ad7192: Add AD7194 support Alisa-Dariana Roman
2024-02-08 18:03 ` Conor Dooley
2024-02-15 12:13 ` Alisa-Dariana Roman
2024-02-15 12:52 ` Conor Dooley
2024-02-08 21:02 ` David Lechner
2024-02-08 17:24 ` [PATCH v3 5/5] " Alisa-Dariana Roman
2024-02-08 22:27 ` David Lechner
2024-02-15 13:22 ` Alisa-Dariana Roman
2024-02-15 17:13 ` David Lechner
2024-02-16 14:21 ` Jonathan Cameron
2024-02-16 16:57 ` David Lechner
2024-02-17 16:25 ` Jonathan Cameron
2024-02-19 16:10 ` David Lechner
2024-02-19 16:33 ` David Lechner
2024-02-19 19:30 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240210155226.5e509845@jic23-huawei \
--to=jic23@kernel.org \
--cc=alexandru.tachici@analog.com \
--cc=alisa.roman@analog.com \
--cc=alisadariana@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.