All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/heimdal: Fix build with autoconf-2.72
Date: Sun, 11 Feb 2024 22:46:21 +0100	[thread overview]
Message-ID: <20240211224621.32d6eb40@windsurf> (raw)
In-Reply-To: <20240210103634.3502847-1-bernd@kuhls.net>

On Sat, 10 Feb 2024 11:36:34 +0100
Bernd Kuhls <bernd@kuhls.net> wrote:

> +-if test "$enable_largefile" != no -a "$ac_cv_sys_file_offset_bits" != no; then
> ++if test "$enable_largefile" != no -a "$ac_cv_sys_file_offset_bits" != no && test -n "$ac_cv_sys_file_offset_bits"; then

Could you provide more details? I don't see the relation ship between
this change and the build failure.

Also, you're using && while the rest of the test is using -a. And
you're testing if the strong is non empty *after* testing if it's
different from no.

We really need more details.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-02-11 21:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-10 10:36 [Buildroot] [PATCH 1/1] package/heimdal: Fix build with autoconf-2.72 Bernd Kuhls
2024-02-11 21:46 ` Thomas Petazzoni via buildroot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-03-01 15:24 Lance Fredrickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240211224621.32d6eb40@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bernd@kuhls.net \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.