From: kernel test robot <lkp@intel.com>
To: Perry Yuan <perry.yuan@amd.com>,
rafael.j.wysocki@intel.com, Mario.Limonciello@amd.com,
viresh.kumar@linaro.org, Ray.Huang@amd.com,
gautham.shenoy@amd.com, Borislav.Petkov@amd.com
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Alexander.Deucher@amd.com, Xinmei.Huang@amd.com,
Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] cpufreq: amd-pstate: initialize new core precision boost state
Date: Mon, 12 Feb 2024 02:19:37 +0800 [thread overview]
Message-ID: <202402120216.mjdQyGCs-lkp@intel.com> (raw)
In-Reply-To: <0409d40c500eeb8d4d84ecb028b73f2eee147822.1706255676.git.perry.yuan@amd.com>
Hi Perry,
kernel test robot noticed the following build errors:
[auto build test ERROR on rafael-pm/acpi-bus]
[also build test ERROR on v6.8-rc3]
[cannot apply to rafael-pm/linux-next linus/master rafael-pm/devprop next-20240209]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Perry-Yuan/cpufreq-amd-pstate-remove-set_boost-callback-for-passive-mode/20240126-171412
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git acpi-bus
patch link: https://lore.kernel.org/r/0409d40c500eeb8d4d84ecb028b73f2eee147822.1706255676.git.perry.yuan%40amd.com
patch subject: [PATCH 2/7] cpufreq: amd-pstate: initialize new core precision boost state
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240212/202402120216.mjdQyGCs-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240212/202402120216.mjdQyGCs-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402120216.mjdQyGCs-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/cpufreq/amd-pstate-ut.c:229:16: error: no member named 'boost_supported' in 'struct amd_cpudata'
229 | if (cpudata->boost_supported) {
| ~~~~~~~ ^
1 error generated.
vim +229 drivers/cpufreq/amd-pstate-ut.c
14eb1c96e3a3fd Meng Li 2022-08-17 193
14eb1c96e3a3fd Meng Li 2022-08-17 194 /*
14eb1c96e3a3fd Meng Li 2022-08-17 195 * Check if frequency values are reasonable.
14eb1c96e3a3fd Meng Li 2022-08-17 196 * max_freq >= nominal_freq > lowest_nonlinear_freq > min_freq > 0
14eb1c96e3a3fd Meng Li 2022-08-17 197 * check max freq when set support boost mode.
14eb1c96e3a3fd Meng Li 2022-08-17 198 */
14eb1c96e3a3fd Meng Li 2022-08-17 199 static void amd_pstate_ut_check_freq(u32 index)
14eb1c96e3a3fd Meng Li 2022-08-17 200 {
14eb1c96e3a3fd Meng Li 2022-08-17 201 int cpu = 0;
14eb1c96e3a3fd Meng Li 2022-08-17 202 struct cpufreq_policy *policy = NULL;
14eb1c96e3a3fd Meng Li 2022-08-17 203 struct amd_cpudata *cpudata = NULL;
14eb1c96e3a3fd Meng Li 2022-08-17 204
14eb1c96e3a3fd Meng Li 2022-08-17 205 for_each_possible_cpu(cpu) {
14eb1c96e3a3fd Meng Li 2022-08-17 206 policy = cpufreq_cpu_get(cpu);
14eb1c96e3a3fd Meng Li 2022-08-17 207 if (!policy)
14eb1c96e3a3fd Meng Li 2022-08-17 208 break;
14eb1c96e3a3fd Meng Li 2022-08-17 209 cpudata = policy->driver_data;
14eb1c96e3a3fd Meng Li 2022-08-17 210
14eb1c96e3a3fd Meng Li 2022-08-17 211 if (!((cpudata->max_freq >= cpudata->nominal_freq) &&
14eb1c96e3a3fd Meng Li 2022-08-17 212 (cpudata->nominal_freq > cpudata->lowest_nonlinear_freq) &&
14eb1c96e3a3fd Meng Li 2022-08-17 213 (cpudata->lowest_nonlinear_freq > cpudata->min_freq) &&
14eb1c96e3a3fd Meng Li 2022-08-17 214 (cpudata->min_freq > 0))) {
14eb1c96e3a3fd Meng Li 2022-08-17 215 amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
14eb1c96e3a3fd Meng Li 2022-08-17 216 pr_err("%s cpu%d max=%d >= nominal=%d > lowest_nonlinear=%d > min=%d > 0, the formula is incorrect!\n",
14eb1c96e3a3fd Meng Li 2022-08-17 217 __func__, cpu, cpudata->max_freq, cpudata->nominal_freq,
14eb1c96e3a3fd Meng Li 2022-08-17 218 cpudata->lowest_nonlinear_freq, cpudata->min_freq);
60dd283804479c Swapnil Sapkal 2023-08-18 219 goto skip_test;
14eb1c96e3a3fd Meng Li 2022-08-17 220 }
14eb1c96e3a3fd Meng Li 2022-08-17 221
14eb1c96e3a3fd Meng Li 2022-08-17 222 if (cpudata->min_freq != policy->min) {
14eb1c96e3a3fd Meng Li 2022-08-17 223 amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
14eb1c96e3a3fd Meng Li 2022-08-17 224 pr_err("%s cpu%d cpudata_min_freq=%d policy_min=%d, they should be equal!\n",
14eb1c96e3a3fd Meng Li 2022-08-17 225 __func__, cpu, cpudata->min_freq, policy->min);
60dd283804479c Swapnil Sapkal 2023-08-18 226 goto skip_test;
14eb1c96e3a3fd Meng Li 2022-08-17 227 }
14eb1c96e3a3fd Meng Li 2022-08-17 228
14eb1c96e3a3fd Meng Li 2022-08-17 @229 if (cpudata->boost_supported) {
14eb1c96e3a3fd Meng Li 2022-08-17 230 if ((policy->max == cpudata->max_freq) ||
14eb1c96e3a3fd Meng Li 2022-08-17 231 (policy->max == cpudata->nominal_freq))
14eb1c96e3a3fd Meng Li 2022-08-17 232 amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_PASS;
14eb1c96e3a3fd Meng Li 2022-08-17 233 else {
14eb1c96e3a3fd Meng Li 2022-08-17 234 amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
14eb1c96e3a3fd Meng Li 2022-08-17 235 pr_err("%s cpu%d policy_max=%d should be equal cpu_max=%d or cpu_nominal=%d !\n",
14eb1c96e3a3fd Meng Li 2022-08-17 236 __func__, cpu, policy->max, cpudata->max_freq,
14eb1c96e3a3fd Meng Li 2022-08-17 237 cpudata->nominal_freq);
60dd283804479c Swapnil Sapkal 2023-08-18 238 goto skip_test;
14eb1c96e3a3fd Meng Li 2022-08-17 239 }
14eb1c96e3a3fd Meng Li 2022-08-17 240 } else {
14eb1c96e3a3fd Meng Li 2022-08-17 241 amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
14eb1c96e3a3fd Meng Li 2022-08-17 242 pr_err("%s cpu%d must support boost!\n", __func__, cpu);
60dd283804479c Swapnil Sapkal 2023-08-18 243 goto skip_test;
14eb1c96e3a3fd Meng Li 2022-08-17 244 }
60dd283804479c Swapnil Sapkal 2023-08-18 245 cpufreq_cpu_put(policy);
14eb1c96e3a3fd Meng Li 2022-08-17 246 }
14eb1c96e3a3fd Meng Li 2022-08-17 247
14eb1c96e3a3fd Meng Li 2022-08-17 248 amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_PASS;
60dd283804479c Swapnil Sapkal 2023-08-18 249 return;
60dd283804479c Swapnil Sapkal 2023-08-18 250 skip_test:
60dd283804479c Swapnil Sapkal 2023-08-18 251 cpufreq_cpu_put(policy);
14eb1c96e3a3fd Meng Li 2022-08-17 252 }
14eb1c96e3a3fd Meng Li 2022-08-17 253
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-02-11 18:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 8:08 [PATCH 0/7] AMD Pstate Driver Core Performance Boost Perry Yuan
2024-01-26 8:08 ` [PATCH 1/7] cpufreq: amd-pstate: remove set_boost callback for passive mode Perry Yuan
2024-01-26 15:45 ` Mario Limonciello
2024-01-29 4:46 ` Yuan, Perry
2024-01-26 8:08 ` [PATCH 2/7] cpufreq: amd-pstate: initialize new core precision boost state Perry Yuan
2024-01-26 16:01 ` Mario Limonciello
2024-01-27 19:01 ` kernel test robot
2024-02-11 18:19 ` kernel test robot [this message]
2024-02-14 6:37 ` Gautham R. Shenoy
2024-01-26 8:08 ` [PATCH 3/7] cpufreq: amd-pstate: implement cpb_boost sysfs entry for boost control Perry Yuan
2024-01-26 15:56 ` Mario Limonciello
2024-01-29 5:22 ` Yuan, Perry
2024-01-26 8:08 ` [PATCH 4/7] cpufreq: amd-pstate: fix max_perf calculation for amd_get_max_freq() Perry Yuan
2024-01-26 15:54 ` Mario Limonciello
2024-01-29 5:16 ` Yuan, Perry
2024-01-26 8:08 ` [PATCH 5/7] cpufreq: amd-pstate: fix the MSR highest perf will be reset issue while cpb boost off Perry Yuan
2024-01-26 8:08 ` [PATCH 6/7] cpufreq:amd-pstate: add suspend and resume callback for passive mode Perry Yuan
2024-01-26 15:52 ` Mario Limonciello
2024-01-26 8:08 ` [PATCH 7/7] Documentation: cpufreq: amd-pstate: introduce the new cpu boost control method Perry Yuan
2024-01-26 15:47 ` Mario Limonciello
2024-01-29 5:07 ` Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202402120216.mjdQyGCs-lkp@intel.com \
--to=lkp@intel.com \
--cc=Alexander.Deucher@amd.com \
--cc=Borislav.Petkov@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=Xinmei.Huang@amd.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=perry.yuan@amd.com \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.