All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Simha BN <simhavcs@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Michael Walle <mwalle@kernel.org>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 03/10] dt-bindings: display: bridge: tc358775: Add support for tc358765
Date: Mon, 12 Feb 2024 10:17:44 +0200	[thread overview]
Message-ID: <20240212081744.GE5299@atomide.com> (raw)
In-Reply-To: <adeb3ebb-76ed-4f00-8b46-a1b9c36cfc64@linaro.org>

* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [240212 08:06]:
> On 11/02/2024 10:51, Tony Lindgren wrote:
> > The tc358765 is similar to tc358775. The tc358765 just an earlier version
> > of the hardware, and it's pin and register compatible with tc358775 for
> > most part.
> > 
> > From the binding point of view the only difference is that the tc358765
> > does not have stdby-gpios.
> > 
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > ---
> 
> It does not look like you tested the bindings, at least after quick
> look. Please run `make dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
> Maybe you need to update your dtschema and yamllint.

I did.. But I did not notice that this no longer works:

$ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml
  LINT    Documentation/devicetree/bindings
usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR ...]
yamllint: error: one of the arguments FILE_OR_DIR - is required
  CHKDT   Documentation/devicetree/bindings/processed-schema.json
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json

After removing the ">2&1" from the Makefile, there's some more info:

yamllint: error: one of the arguments FILE_OR_DIR - is required

Where DT_SCHEMA_FILES ends up empty. I guess dt_binding_check needs
to be now run with just:

$ make dt_binding_check DT_SCHEMA_FILES=toshiba,tc358775.yaml

Regards,

Tony

  reply	other threads:[~2024-02-12  8:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-11  9:51 [PATCH v3 00/10] Improvments for tc358775 with support for tc358765 Tony Lindgren
2024-02-11  9:51 ` [PATCH v3 01/10] dt-bindings: display: bridge: tc358775: make stby gpio optional Tony Lindgren
2024-02-12  8:04   ` Krzysztof Kozlowski
2024-02-11  9:51 ` [PATCH v3 02/10] dt-bindings: display: bridge: tc358775: Add data-lanes Tony Lindgren
2024-02-12  8:05   ` Krzysztof Kozlowski
2024-02-11  9:51 ` [PATCH v3 03/10] dt-bindings: display: bridge: tc358775: Add support for tc358765 Tony Lindgren
2024-02-11 14:31   ` Rob Herring
2024-02-12  3:36   ` kernel test robot
2024-02-12  8:06   ` Krzysztof Kozlowski
2024-02-12  8:17     ` Tony Lindgren [this message]
2024-02-12 11:30       ` Krzysztof Kozlowski
2024-02-12 13:51         ` Rob Herring
2024-02-13  6:13           ` Tony Lindgren
2024-02-11  9:51 ` [PATCH v3 04/10] drm/bridge: tc358775: fix support for jeida-18 and jeida-24 Tony Lindgren
2024-02-11  9:51 ` [PATCH v3 05/10] drm/bridge: tc358775: make standby GPIO optional Tony Lindgren
2024-02-11  9:51 ` [PATCH v3 06/10] drm/bridge: tc358775: Get bridge data lanes instead of the DSI host lanes Tony Lindgren
2024-02-11  9:51 ` [PATCH v3 07/10] drm/bridge: tc358775: Add burst and low-power modes Tony Lindgren
2024-02-11  9:51 ` [PATCH v3 08/10] drm/bridge: tc358775: Enable pre_enable_prev_first flag Tony Lindgren
2024-02-11  9:51 ` [PATCH v3 09/10] drm/bridge: tc358775: Add support for tc358765 Tony Lindgren
2024-02-11  9:51 ` [PATCH v3 10/10] drm/bridge: tc358775: Configure hs_rate and lp_rate Tony Lindgren
2024-02-12 11:26   ` Michael Walle
  -- strict thread matches above, loose matches on Subject: below --
2024-02-11 22:05 [PATCH v3 03/10] dt-bindings: display: bridge: tc358775: Add support for tc358765 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240212081744.GE5299@atomide.com \
    --to=tony@atomide.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=mwalle@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=simhavcs@gmail.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.