From: Stephen Hemminger <stephen@networkplumber.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com
Subject: Re: [PATCH iproute2] tc: u32: check return value from snprintf
Date: Mon, 12 Feb 2024 08:53:58 -0800 [thread overview]
Message-ID: <20240212085358.22be1db6@hermes.local> (raw)
In-Reply-To: <ZcnHwRCr6s3T8VXt@Laptop-X1>
On Mon, 12 Feb 2024 15:24:49 +0800
Hangbin Liu <liuhangbin@gmail.com> wrote:
> On Sat, Feb 10, 2024 at 05:04:23PM -0800, Stephen Hemminger wrote:
> > Add assertion to check for case of snprintf failing (bad format?)
> > or buffer getting full.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Hi Stephen,
>
> Is there a bug report or something else that we only do the assertion
> for tc/f_u32.c?
>
> Thanks
> Hangbin
No bug, it is not possible to trigger with current code.
Return of < 0 only happens with improper format string,
and the overrun would only happen if buffer was not big enough
The bsize is SPRINT_BUF() which is 64 bytes.
It is more a way to avoid some code checker complaining in future.
next prev parent reply other threads:[~2024-02-12 16:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 1:04 [PATCH iproute2] tc: u32: check return value from snprintf Stephen Hemminger
2024-02-12 7:24 ` Hangbin Liu
2024-02-12 16:53 ` Stephen Hemminger [this message]
2024-02-16 9:58 ` David Laight
2024-02-13 6:25 ` Hangbin Liu
2024-02-15 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240212085358.22be1db6@hermes.local \
--to=stephen@networkplumber.org \
--cc=jhs@mojatatu.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.