From: Jakub Kicinski <kuba@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
davem@davemloft.net, "Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Horatiu Vultur" <horatiu.vultur@microchip.com>,
"Richard Cochran" <richardcochran@gmail.com>,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com,
"Köry Maincent" <kory.maincent@bootlin.com>
Subject: Re: [PATCH net-next 1/3] net: phy: Add support for inband extensions
Date: Mon, 12 Feb 2024 17:25:11 -0800 [thread overview]
Message-ID: <20240212172511.42cd058d@kernel.org> (raw)
In-Reply-To: <20240212173307.1124120-2-maxime.chevallier@bootlin.com>
On Mon, 12 Feb 2024 18:33:04 +0100 Maxime Chevallier wrote:
> +/**
> + * PHY modes in the USXGMII family can have extensions, with data transmitted
> + * in the frame preamble.
> + * For now, only QUSGMII is supported, but other variants like USGMII and
> + * OUSGMII can be added in the future.
> + */
> +static inline bool phy_interface_has_inband_ext(phy_interface_t interface)
Spurious use of /**, it seems. You either need to use full kdoc format,
or the normal /* comment start.
--
pw-bot: cr
next prev parent reply other threads:[~2024-02-13 1:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 17:33 [PATCH net-next 0/3] Introduce support for USGMII Inband Extensions Maxime Chevallier
2024-02-12 17:33 ` [PATCH net-next 1/3] net: phy: Add support for inband extensions Maxime Chevallier
2024-02-13 1:25 ` Jakub Kicinski [this message]
2024-02-13 9:08 ` Maxime Chevallier
2024-02-13 14:03 ` Andrew Lunn
2024-02-13 16:07 ` Maxime Chevallier
2024-02-12 17:33 ` [PATCH net-next 2/3] net: lan966x: Allow using PCH extension for PTP Maxime Chevallier
2024-02-13 10:31 ` Horatiu Vultur
2024-02-13 15:57 ` Maxime Chevallier
2024-02-12 17:33 ` [PATCH net-next 3/3] net: phy: micrel: Add QUSGMII support and PCH extension Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240212172511.42cd058d@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kory.maincent@bootlin.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.