From: Greg KH <gregkh@linuxfoundation.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-usb@vger.kernel.org,
Yehezkel Bernat <YehezkelShB@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Lukas Wunner <lukas@wunner.de>,
Andreas Noever <andreas.noever@gmail.com>,
Gil Fine <gil.fine@linux.intel.com>
Subject: Re: [PATCH v2] thunderbolt: Add trace events support for the control channel
Date: Mon, 12 Feb 2024 11:00:17 +0100 [thread overview]
Message-ID: <2024021220-nullify-enslave-6747@gregkh> (raw)
In-Reply-To: <20240212090604.2551237-1-mika.westerberg@linux.intel.com>
On Mon, Feb 12, 2024 at 11:06:04AM +0200, Mika Westerberg wrote:
> @@ -22,6 +24,7 @@
> /**
> * struct tb_ctl - Thunderbolt control channel
> * @nhi: Pointer to the NHI structure
> + * @index: Domain number. This will be output with the trace record.
> * @tx: Transmit ring
> * @rx: Receive ring
> * @frame_pool: DMA pool for control messages
> @@ -35,6 +38,7 @@
> */
> struct tb_ctl {
> struct tb_nhi *nhi;
> + int index;
> struct tb_ring *tx;
> struct tb_ring *rx;
Did you mean to put a "hole" in the structure like this? If not, please
move it around a bit.
thanks,
greg k-h
prev parent reply other threads:[~2024-02-12 10:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 9:06 [PATCH v2] thunderbolt: Add trace events support for the control channel Mika Westerberg
2024-02-12 10:00 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024021220-nullify-enslave-6747@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=gil.fine@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.