From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <kch@nvidia.com>
Cc: linux-nvme@lists.infradead.org, kbusch@kernel.org, hch@lst.de,
sagi@grimberg.me
Subject: Re: [PATCH] nvme-fabrics: fix I/O connect error handling
Date: Tue, 13 Feb 2024 06:53:05 +0100 [thread overview]
Message-ID: <20240213055305.GA22378@lst.de> (raw)
In-Reply-To: <20240208113125.50498-1-kch@nvidia.com>
On Thu, Feb 08, 2024 at 03:31:25AM -0800, Chaitanya Kulkarni wrote:
> In nvmf_connect_io_queue(), if connect I/O command fails, we log the
> error and continue for authentication. This overrides error captured
> from __nvme_submit_sync_cmd(), causing wrong return value.
>
> Add goto out_free_data after logging connect error to fix the issue.
>
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
> ---
>
> blktests is passing with this patch :-
Does this imply it didn't before? In general a Fixes tag would be
more useful than a test log..
next prev parent reply other threads:[~2024-02-13 5:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 11:31 [PATCH] nvme-fabrics: fix I/O connect error handling Chaitanya Kulkarni
2024-02-13 5:53 ` Christoph Hellwig [this message]
2024-02-13 10:32 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240213055305.GA22378@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.