All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: [l1k:spdm-future 11/18] drivers/pci/cma.c:200:11-12: WARNING opportunity for min()
Date: Tue, 13 Feb 2024 09:13:36 +0800	[thread overview]
Message-ID: <202402130928.VApcSvtm-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Lukas Wunner <lukas@wunner.de>

tree:   https://github.com/l1k/linux spdm-future
head:   cfa69b23f279ca186df9fe36692ccb6ee8650d33
commit: a767893788f626221854db85d7266d280627d797 [11/18] PCI/CMA: Reauthenticate devices on reset and resume
:::::: branch date: 14 hours ago
:::::: commit date: 14 hours ago
config: arc-randconfig-r063-20240213 (https://download.01.org/0day-ci/archive/20240213/202402130928.VApcSvtm-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202402130928.VApcSvtm-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/pci/cma.c:200:11-12: WARNING opportunity for min()

vim +200 drivers/pci/cma.c

a767893788f626 Lukas Wunner     2023-01-16  188  
a767893788f626 Lukas Wunner     2023-01-16  189  int pci_cma_reauthenticate(struct pci_dev *pdev)
a767893788f626 Lukas Wunner     2023-01-16  190  {
a767893788f626 Lukas Wunner     2023-01-16  191  	int rc;
a767893788f626 Lukas Wunner     2023-01-16  192  
a767893788f626 Lukas Wunner     2023-01-16  193  	if (!pdev->cma_capable)
a767893788f626 Lukas Wunner     2023-01-16  194  		return -ENOTTY;
a767893788f626 Lukas Wunner     2023-01-16  195  
a767893788f626 Lukas Wunner     2023-01-16  196  	rc = spdm_authenticate(pdev->spdm_state);
a767893788f626 Lukas Wunner     2023-01-16  197  	if (rc >= 0)
a767893788f626 Lukas Wunner     2023-01-16  198  		pci_info(pdev, "authenticated with certificate slot %d\n", rc);
a767893788f626 Lukas Wunner     2023-01-16  199  
a767893788f626 Lukas Wunner     2023-01-16 @200  	return rc < 0 ? rc : 0;
5f24e7f0eed935 Jonathan Cameron 2022-09-06  201  }
5f24e7f0eed935 Jonathan Cameron 2022-09-06  202  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-02-13  1:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202402130928.VApcSvtm-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=julia.lawall@inria.fr \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.