From: Stefano Brivio <sbrivio@redhat.com>
To: Florian Westphal <fw@strlen.de>
Cc: <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH v2 nf-next 0/4] netfilter: nft_set_pipapo: speed up bulk element insertions
Date: Tue, 13 Feb 2024 17:07:59 +0100 [thread overview]
Message-ID: <20240213170759.6c3a9f60@elisabeth> (raw)
In-Reply-To: <20240213152345.10590-1-fw@strlen.de>
On Tue, 13 Feb 2024 16:23:36 +0100
Florian Westphal <fw@strlen.de> wrote:
> v2: addressed comments from Stefano, see patches for details.
>
> Bulk insertions into pipapo set type take a very long time, each new
> element allocates space for elem+1 elements, then copies all existing
> elements and appends the new element.
>
> Alloc extra slack space to reduce the realloc overhead to speed this up.
>
> While at it, shrink a few data structures, in may cases a much smaller
> type can be used.
>
> Florian Westphal (4):
> netfilter: nft_set_pipapo: constify lookup fn args where possible
> netfilter: nft_set_pipapo: do not rely on ZERO_SIZE_PTR
> netfilter: nft_set_pipapo: shrink data structures
> netfilter: nft_set_pipapo: speed up bulk element insertions
For the series,
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
prev parent reply other threads:[~2024-02-13 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 15:23 [PATCH v2 nf-next 0/4] netfilter: nft_set_pipapo: speed up bulk element insertions Florian Westphal
2024-02-13 15:23 ` [PATCH v2 nf-next 1/4] netfilter: nft_set_pipapo: constify lookup fn args where possible Florian Westphal
2024-02-13 15:23 ` [PATCH v2 nf-next 2/4] netfilter: nft_set_pipapo: do not rely on ZERO_SIZE_PTR Florian Westphal
2024-02-15 8:38 ` Florian Westphal
2024-02-13 15:23 ` [PATCH v2 nf-next 3/4] netfilter: nft_set_pipapo: shrink data structures Florian Westphal
2024-02-13 15:23 ` [PATCH v2 nf-next 4/4] netfilter: nft_set_pipapo: speed up bulk element insertions Florian Westphal
2024-02-13 16:07 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240213170759.6c3a9f60@elisabeth \
--to=sbrivio@redhat.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.