From: Jakub Kicinski <kuba@kernel.org>
To: Russell King <linux@armlinux.org.uk>, Andrew Lunn <andrew@lunn.ch>
Cc: Paolo Abeni <pabeni@redhat.com>,
Daniil Dulov <d.dulov@aladdin.ru>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] net: sfp: remove redundant NULL check
Date: Tue, 13 Feb 2024 17:26:25 -0800 [thread overview]
Message-ID: <20240213172625.73643a36@kernel.org> (raw)
In-Reply-To: <cae5b4d55770da3a1dc9678ffa55c9afb9c81723.camel@redhat.com>
On Tue, 13 Feb 2024 13:43:57 +0100 Paolo Abeni wrote:
> On Sun, 2024-02-11 at 07:08 -0800, Daniil Dulov wrote:
> > bus->upstream_ops in sfp_register_bus() cannot be NULL. So remove
> > redundant NULL check.
>
> I'm unsure about that?!? in theory drivers could call
> sfp_bus_add_upstream()/phy_sfp_probe() with NULL ops, even it that very
> likely doesn't make any sense.
>
> @Russel, @Andrew: WDYT?
Since Russell is AFK let me discard this instead of queuing.
We'll resurrect if any of the maintainers sends review tags or alike.
next prev parent reply other threads:[~2024-02-14 1:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 15:08 [PATCH] net: sfp: remove redundant NULL check Daniil Dulov
2024-02-13 12:43 ` Paolo Abeni
2024-02-14 1:26 ` Jakub Kicinski [this message]
2024-02-15 16:02 ` Russell King (Oracle)
2024-02-15 17:32 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240213172625.73643a36@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=d.dulov@aladdin.ru \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.