diff for duplicates of <20240213222808.GA2490812-robh@kernel.org> diff --git a/a/1.txt b/N1/1.txt index ca132ae..20734dc 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -19,7 +19,7 @@ right? > > I'm presenting a revised version of the eSPI device driver patch series found at the following link: > -> https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang at aspeedtech.com/ +> https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang@aspeedtech.com/ > > This update addresses the issues identified during the review process. > @@ -192,7 +192,7 @@ Is this really a separate sub-block? > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/ast2600-clock.h> > + -> + espi: espi at 1e6ee000 { +> + espi: espi@1e6ee000 { > + compatible = "aspeed,ast2600-espi", "simple-mfd", "syscon"; > + reg = <0x1e6ee000 0x1000>; > + @@ -200,14 +200,14 @@ Is this really a separate sub-block? > + #size-cells = <1>; > + ranges = <0x0 0x1e6ee000 0x1000>; > + -> + espi_ctrl: espi-ctrl at 0 { +> + espi_ctrl: espi-ctrl@0 { > + compatible = "aspeed,ast2600-espi-ctrl"; > + reg = <0x0 0x800>; > + interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&syscon ASPEED_CLK_GATE_ESPICLK>; > + }; > + -> + espi_mmbi: espi-mmbi at 800 { +> + espi_mmbi: espi-mmbi@800 { > + compatible = "aspeed,ast2600-espi-mmbi"; > + reg = <0x800 0x50>; > + interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; @@ -217,18 +217,18 @@ Is this really a separate sub-block? > index c4d1faade8be..08d7a2689086 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi -> @@ -453,7 +453,21 @@ video: video at 1e700000 { +> @@ -453,7 +453,21 @@ video: video@1e700000 { > interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; > status = "disabled"; > }; > - -> + espi: espi at 1e6ee000 { +> + espi: espi@1e6ee000 { > + compatible = "aspeed,ast2600-espi", "simple-mfd", "syscon"; > + reg = <0x1e6ee000 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x1e6ee000 0x1000>; -> + espi_ctrl: espi-ctrl at 0 { +> + espi_ctrl: espi-ctrl@0 { > + compatible = "aspeed,ast2600-espi-ctrl"; > + reg = <0x0 0x800>,<0x0 0x4000000>; > + reg-names = "espi_ctrl","espi_flash"; @@ -240,6 +240,10 @@ Is this really a separate sub-block? Wrong indentation. > + }; -> gpio0: gpio at 1e780000 { +> gpio0: gpio@1e780000 { > #gpio-cells = <2>; > gpio-controller; + +______________________________________________________ +Linux MTD discussion mailing list +http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/a/content_digest b/N1/content_digest index c3df52f..77ab40d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,26 @@ "ref\020240213-espi_driver-v1-1-92741c812843@gmail.com\0" "From\0Rob Herring <robh@kernel.org>\0" - "Subject\0[PATCH] Add eSPI device driver (flash channel)\0" + "Subject\0Re: [PATCH] Add eSPI device driver (flash channel)\0" "Date\0Tue, 13 Feb 2024 16:28:08 -0600\0" - "To\0linux-aspeed@lists.ozlabs.org\0" + "To\0Manojkiran Eda <manojkiran.eda@gmail.com>\0" + "Cc\0Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>" + Conor Dooley <conor+dt@kernel.org> + Joel Stanley <joel@jms.id.au> + Andrew Jeffery <andrew@codeconstruct.com.au> + Miquel Raynal <miquel.raynal@bootlin.com> + Richard Weinberger <richard@nod.at> + Vignesh Raghavendra <vigneshr@ti.com> + jk@codeconstruct.com.au + Patrick Rudolph <patrick.rudolph@9elements.com> + Chia-Wei Wang <chiawei_wang@aspeedtech.com> + Ryan Chen <ryan_chen@aspeedtech.com> + devicetree@vger.kernel.org + linux-arm-kernel@lists.infradead.org + linux-aspeed@lists.ozlabs.org + linux-kernel@vger.kernel.org + linux-mtd@lists.infradead.org + openbmc@lists.ozlabs.org + " zev@bewilderbeest.net\0" "\00:1\0" "b\0" "On Tue, Feb 13, 2024 at 08:06:08PM +0530, Manojkiran Eda wrote:\n" @@ -26,7 +44,7 @@ "> \n" "> I'm presenting a revised version of the eSPI device driver patch series found at the following link:\n" "> \n" - "> https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang at aspeedtech.com/ \n" + "> https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang@aspeedtech.com/ \n" "> \n" "> This update addresses the issues identified during the review process.\n" "> \n" @@ -199,7 +217,7 @@ "> + #include <dt-bindings/interrupt-controller/arm-gic.h>\n" "> + #include <dt-bindings/clock/ast2600-clock.h>\n" "> +\n" - "> + espi: espi at 1e6ee000 {\n" + "> + espi: espi@1e6ee000 {\n" "> + compatible = \"aspeed,ast2600-espi\", \"simple-mfd\", \"syscon\";\n" "> + reg = <0x1e6ee000 0x1000>;\n" "> +\n" @@ -207,14 +225,14 @@ "> + #size-cells = <1>;\n" "> + ranges = <0x0 0x1e6ee000 0x1000>;\n" "> +\n" - "> + espi_ctrl: espi-ctrl at 0 {\n" + "> + espi_ctrl: espi-ctrl@0 {\n" "> + compatible = \"aspeed,ast2600-espi-ctrl\";\n" "> + reg = <0x0 0x800>;\n" "> + interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;\n" "> + clocks = <&syscon ASPEED_CLK_GATE_ESPICLK>;\n" "> + };\n" "> +\n" - "> + espi_mmbi: espi-mmbi at 800 {\n" + "> + espi_mmbi: espi-mmbi@800 {\n" "> + compatible = \"aspeed,ast2600-espi-mmbi\";\n" "> + reg = <0x800 0x50>;\n" "> + interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;\n" @@ -224,18 +242,18 @@ "> index c4d1faade8be..08d7a2689086 100644\n" "> --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi\n" "> +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi\n" - "> @@ -453,7 +453,21 @@ video: video at 1e700000 {\n" + "> @@ -453,7 +453,21 @@ video: video@1e700000 {\n" "> \t\t\t\tinterrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;\n" "> \t\t\t\tstatus = \"disabled\";\n" "> \t\t\t};\n" "> -\n" - "> +\t\t\tespi: espi at 1e6ee000 {\n" + "> +\t\t\tespi: espi@1e6ee000 {\n" "> +\t\t\t\tcompatible = \"aspeed,ast2600-espi\", \"simple-mfd\", \"syscon\";\n" "> +\t\t\t\treg = <0x1e6ee000 0x1000>;\n" "> +\t\t\t\t#address-cells = <1>;\n" "> +\t\t\t\t#size-cells = <1>;\n" "> +\t\t\t\tranges = <0x0 0x1e6ee000 0x1000>;\n" - "> +\t\t\t\tespi_ctrl: espi-ctrl at 0 {\n" + "> +\t\t\t\tespi_ctrl: espi-ctrl@0 {\n" "> +\t\t\t\t\t\tcompatible = \"aspeed,ast2600-espi-ctrl\";\n" "> +\t\t\t\t\t\treg = <0x0 0x800>,<0x0 0x4000000>;\n" "> +\t\t\t\t\t\treg-names = \"espi_ctrl\",\"espi_flash\";\n" @@ -247,8 +265,12 @@ "Wrong indentation.\n" "\n" "> +\t\t\t};\n" - "> \t\t\tgpio0: gpio at 1e780000 {\n" + "> \t\t\tgpio0: gpio@1e780000 {\n" "> \t\t\t\t#gpio-cells = <2>;\n" - "> \t\t\t\tgpio-controller;" + "> \t\t\t\tgpio-controller;\n" + "\n" + "______________________________________________________\n" + "Linux MTD discussion mailing list\n" + http://lists.infradead.org/mailman/listinfo/linux-mtd/ -4148fb78eecdf953f20e5e79a706ca0c99078f1c701c0424e5cb92b66499d77b +2bde8b67998d77bfb8388ecfaf955769b279f90450694131aa10fdfbcbd542da
diff --git a/a/1.txt b/N2/1.txt index ca132ae..5a64242 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -19,7 +19,7 @@ right? > > I'm presenting a revised version of the eSPI device driver patch series found at the following link: > -> https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang at aspeedtech.com/ +> https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang@aspeedtech.com/ > > This update addresses the issues identified during the review process. > @@ -192,7 +192,7 @@ Is this really a separate sub-block? > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/ast2600-clock.h> > + -> + espi: espi at 1e6ee000 { +> + espi: espi@1e6ee000 { > + compatible = "aspeed,ast2600-espi", "simple-mfd", "syscon"; > + reg = <0x1e6ee000 0x1000>; > + @@ -200,14 +200,14 @@ Is this really a separate sub-block? > + #size-cells = <1>; > + ranges = <0x0 0x1e6ee000 0x1000>; > + -> + espi_ctrl: espi-ctrl at 0 { +> + espi_ctrl: espi-ctrl@0 { > + compatible = "aspeed,ast2600-espi-ctrl"; > + reg = <0x0 0x800>; > + interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&syscon ASPEED_CLK_GATE_ESPICLK>; > + }; > + -> + espi_mmbi: espi-mmbi at 800 { +> + espi_mmbi: espi-mmbi@800 { > + compatible = "aspeed,ast2600-espi-mmbi"; > + reg = <0x800 0x50>; > + interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; @@ -217,18 +217,18 @@ Is this really a separate sub-block? > index c4d1faade8be..08d7a2689086 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi -> @@ -453,7 +453,21 @@ video: video at 1e700000 { +> @@ -453,7 +453,21 @@ video: video@1e700000 { > interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; > status = "disabled"; > }; > - -> + espi: espi at 1e6ee000 { +> + espi: espi@1e6ee000 { > + compatible = "aspeed,ast2600-espi", "simple-mfd", "syscon"; > + reg = <0x1e6ee000 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x1e6ee000 0x1000>; -> + espi_ctrl: espi-ctrl at 0 { +> + espi_ctrl: espi-ctrl@0 { > + compatible = "aspeed,ast2600-espi-ctrl"; > + reg = <0x0 0x800>,<0x0 0x4000000>; > + reg-names = "espi_ctrl","espi_flash"; @@ -240,6 +240,6 @@ Is this really a separate sub-block? Wrong indentation. > + }; -> gpio0: gpio at 1e780000 { +> gpio0: gpio@1e780000 { > #gpio-cells = <2>; > gpio-controller; diff --git a/a/content_digest b/N2/content_digest index c3df52f..d9c99a5 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,8 +1,25 @@ "ref\020240213-espi_driver-v1-1-92741c812843@gmail.com\0" "From\0Rob Herring <robh@kernel.org>\0" - "Subject\0[PATCH] Add eSPI device driver (flash channel)\0" + "Subject\0Re: [PATCH] Add eSPI device driver (flash channel)\0" "Date\0Tue, 13 Feb 2024 16:28:08 -0600\0" - "To\0linux-aspeed@lists.ozlabs.org\0" + "To\0Manojkiran Eda <manojkiran.eda@gmail.com>\0" + "Cc\0linux-arm-kernel@lists.infradead.org" + devicetree@vger.kernel.org + Conor Dooley <conor+dt@kernel.org> + zev@bewilderbeest.net + Ryan Chen <ryan_chen@aspeedtech.com> + Vignesh Raghavendra <vigneshr@ti.com> + linux-aspeed@lists.ozlabs.org + Richard Weinberger <richard@nod.at> + Chia-Wei Wang <chiawei_wang@aspeedtech.com> + linux-kernel@vger.kernel.org + linux-mtd@lists.infradead.org + Joel Stanley <joel@jms.id.au> + Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> + Miquel Raynal <miquel.raynal@bootlin.com> + jk@codeconstruct.com.au + openbmc@lists.ozlabs.org + " Patrick Rudolph <patrick.rudolph@9elements.com>\0" "\00:1\0" "b\0" "On Tue, Feb 13, 2024 at 08:06:08PM +0530, Manojkiran Eda wrote:\n" @@ -26,7 +43,7 @@ "> \n" "> I'm presenting a revised version of the eSPI device driver patch series found at the following link:\n" "> \n" - "> https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang at aspeedtech.com/ \n" + "> https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang@aspeedtech.com/ \n" "> \n" "> This update addresses the issues identified during the review process.\n" "> \n" @@ -199,7 +216,7 @@ "> + #include <dt-bindings/interrupt-controller/arm-gic.h>\n" "> + #include <dt-bindings/clock/ast2600-clock.h>\n" "> +\n" - "> + espi: espi at 1e6ee000 {\n" + "> + espi: espi@1e6ee000 {\n" "> + compatible = \"aspeed,ast2600-espi\", \"simple-mfd\", \"syscon\";\n" "> + reg = <0x1e6ee000 0x1000>;\n" "> +\n" @@ -207,14 +224,14 @@ "> + #size-cells = <1>;\n" "> + ranges = <0x0 0x1e6ee000 0x1000>;\n" "> +\n" - "> + espi_ctrl: espi-ctrl at 0 {\n" + "> + espi_ctrl: espi-ctrl@0 {\n" "> + compatible = \"aspeed,ast2600-espi-ctrl\";\n" "> + reg = <0x0 0x800>;\n" "> + interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;\n" "> + clocks = <&syscon ASPEED_CLK_GATE_ESPICLK>;\n" "> + };\n" "> +\n" - "> + espi_mmbi: espi-mmbi at 800 {\n" + "> + espi_mmbi: espi-mmbi@800 {\n" "> + compatible = \"aspeed,ast2600-espi-mmbi\";\n" "> + reg = <0x800 0x50>;\n" "> + interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;\n" @@ -224,18 +241,18 @@ "> index c4d1faade8be..08d7a2689086 100644\n" "> --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi\n" "> +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi\n" - "> @@ -453,7 +453,21 @@ video: video at 1e700000 {\n" + "> @@ -453,7 +453,21 @@ video: video@1e700000 {\n" "> \t\t\t\tinterrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;\n" "> \t\t\t\tstatus = \"disabled\";\n" "> \t\t\t};\n" "> -\n" - "> +\t\t\tespi: espi at 1e6ee000 {\n" + "> +\t\t\tespi: espi@1e6ee000 {\n" "> +\t\t\t\tcompatible = \"aspeed,ast2600-espi\", \"simple-mfd\", \"syscon\";\n" "> +\t\t\t\treg = <0x1e6ee000 0x1000>;\n" "> +\t\t\t\t#address-cells = <1>;\n" "> +\t\t\t\t#size-cells = <1>;\n" "> +\t\t\t\tranges = <0x0 0x1e6ee000 0x1000>;\n" - "> +\t\t\t\tespi_ctrl: espi-ctrl at 0 {\n" + "> +\t\t\t\tespi_ctrl: espi-ctrl@0 {\n" "> +\t\t\t\t\t\tcompatible = \"aspeed,ast2600-espi-ctrl\";\n" "> +\t\t\t\t\t\treg = <0x0 0x800>,<0x0 0x4000000>;\n" "> +\t\t\t\t\t\treg-names = \"espi_ctrl\",\"espi_flash\";\n" @@ -247,8 +264,8 @@ "Wrong indentation.\n" "\n" "> +\t\t\t};\n" - "> \t\t\tgpio0: gpio at 1e780000 {\n" + "> \t\t\tgpio0: gpio@1e780000 {\n" "> \t\t\t\t#gpio-cells = <2>;\n" "> \t\t\t\tgpio-controller;" -4148fb78eecdf953f20e5e79a706ca0c99078f1c701c0424e5cb92b66499d77b +ec91672324da879ae4b48a511370540b3b517f74458ba7049affc5226e577796
diff --git a/a/1.txt b/N3/1.txt index ca132ae..63fc875 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -19,7 +19,7 @@ right? > > I'm presenting a revised version of the eSPI device driver patch series found at the following link: > -> https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang at aspeedtech.com/ +> https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang@aspeedtech.com/ > > This update addresses the issues identified during the review process. > @@ -192,7 +192,7 @@ Is this really a separate sub-block? > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/ast2600-clock.h> > + -> + espi: espi at 1e6ee000 { +> + espi: espi@1e6ee000 { > + compatible = "aspeed,ast2600-espi", "simple-mfd", "syscon"; > + reg = <0x1e6ee000 0x1000>; > + @@ -200,14 +200,14 @@ Is this really a separate sub-block? > + #size-cells = <1>; > + ranges = <0x0 0x1e6ee000 0x1000>; > + -> + espi_ctrl: espi-ctrl at 0 { +> + espi_ctrl: espi-ctrl@0 { > + compatible = "aspeed,ast2600-espi-ctrl"; > + reg = <0x0 0x800>; > + interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&syscon ASPEED_CLK_GATE_ESPICLK>; > + }; > + -> + espi_mmbi: espi-mmbi at 800 { +> + espi_mmbi: espi-mmbi@800 { > + compatible = "aspeed,ast2600-espi-mmbi"; > + reg = <0x800 0x50>; > + interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; @@ -217,18 +217,18 @@ Is this really a separate sub-block? > index c4d1faade8be..08d7a2689086 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi -> @@ -453,7 +453,21 @@ video: video at 1e700000 { +> @@ -453,7 +453,21 @@ video: video@1e700000 { > interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; > status = "disabled"; > }; > - -> + espi: espi at 1e6ee000 { +> + espi: espi@1e6ee000 { > + compatible = "aspeed,ast2600-espi", "simple-mfd", "syscon"; > + reg = <0x1e6ee000 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x1e6ee000 0x1000>; -> + espi_ctrl: espi-ctrl at 0 { +> + espi_ctrl: espi-ctrl@0 { > + compatible = "aspeed,ast2600-espi-ctrl"; > + reg = <0x0 0x800>,<0x0 0x4000000>; > + reg-names = "espi_ctrl","espi_flash"; @@ -240,6 +240,11 @@ Is this really a separate sub-block? Wrong indentation. > + }; -> gpio0: gpio at 1e780000 { +> gpio0: gpio@1e780000 { > #gpio-cells = <2>; > gpio-controller; + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N3/content_digest index c3df52f..08b14d2 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -1,8 +1,26 @@ "ref\020240213-espi_driver-v1-1-92741c812843@gmail.com\0" "From\0Rob Herring <robh@kernel.org>\0" - "Subject\0[PATCH] Add eSPI device driver (flash channel)\0" + "Subject\0Re: [PATCH] Add eSPI device driver (flash channel)\0" "Date\0Tue, 13 Feb 2024 16:28:08 -0600\0" - "To\0linux-aspeed@lists.ozlabs.org\0" + "To\0Manojkiran Eda <manojkiran.eda@gmail.com>\0" + "Cc\0Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>" + Conor Dooley <conor+dt@kernel.org> + Joel Stanley <joel@jms.id.au> + Andrew Jeffery <andrew@codeconstruct.com.au> + Miquel Raynal <miquel.raynal@bootlin.com> + Richard Weinberger <richard@nod.at> + Vignesh Raghavendra <vigneshr@ti.com> + jk@codeconstruct.com.au + Patrick Rudolph <patrick.rudolph@9elements.com> + Chia-Wei Wang <chiawei_wang@aspeedtech.com> + Ryan Chen <ryan_chen@aspeedtech.com> + devicetree@vger.kernel.org + linux-arm-kernel@lists.infradead.org + linux-aspeed@lists.ozlabs.org + linux-kernel@vger.kernel.org + linux-mtd@lists.infradead.org + openbmc@lists.ozlabs.org + " zev@bewilderbeest.net\0" "\00:1\0" "b\0" "On Tue, Feb 13, 2024 at 08:06:08PM +0530, Manojkiran Eda wrote:\n" @@ -26,7 +44,7 @@ "> \n" "> I'm presenting a revised version of the eSPI device driver patch series found at the following link:\n" "> \n" - "> https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang at aspeedtech.com/ \n" + "> https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang@aspeedtech.com/ \n" "> \n" "> This update addresses the issues identified during the review process.\n" "> \n" @@ -199,7 +217,7 @@ "> + #include <dt-bindings/interrupt-controller/arm-gic.h>\n" "> + #include <dt-bindings/clock/ast2600-clock.h>\n" "> +\n" - "> + espi: espi at 1e6ee000 {\n" + "> + espi: espi@1e6ee000 {\n" "> + compatible = \"aspeed,ast2600-espi\", \"simple-mfd\", \"syscon\";\n" "> + reg = <0x1e6ee000 0x1000>;\n" "> +\n" @@ -207,14 +225,14 @@ "> + #size-cells = <1>;\n" "> + ranges = <0x0 0x1e6ee000 0x1000>;\n" "> +\n" - "> + espi_ctrl: espi-ctrl at 0 {\n" + "> + espi_ctrl: espi-ctrl@0 {\n" "> + compatible = \"aspeed,ast2600-espi-ctrl\";\n" "> + reg = <0x0 0x800>;\n" "> + interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;\n" "> + clocks = <&syscon ASPEED_CLK_GATE_ESPICLK>;\n" "> + };\n" "> +\n" - "> + espi_mmbi: espi-mmbi at 800 {\n" + "> + espi_mmbi: espi-mmbi@800 {\n" "> + compatible = \"aspeed,ast2600-espi-mmbi\";\n" "> + reg = <0x800 0x50>;\n" "> + interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;\n" @@ -224,18 +242,18 @@ "> index c4d1faade8be..08d7a2689086 100644\n" "> --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi\n" "> +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi\n" - "> @@ -453,7 +453,21 @@ video: video at 1e700000 {\n" + "> @@ -453,7 +453,21 @@ video: video@1e700000 {\n" "> \t\t\t\tinterrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;\n" "> \t\t\t\tstatus = \"disabled\";\n" "> \t\t\t};\n" "> -\n" - "> +\t\t\tespi: espi at 1e6ee000 {\n" + "> +\t\t\tespi: espi@1e6ee000 {\n" "> +\t\t\t\tcompatible = \"aspeed,ast2600-espi\", \"simple-mfd\", \"syscon\";\n" "> +\t\t\t\treg = <0x1e6ee000 0x1000>;\n" "> +\t\t\t\t#address-cells = <1>;\n" "> +\t\t\t\t#size-cells = <1>;\n" "> +\t\t\t\tranges = <0x0 0x1e6ee000 0x1000>;\n" - "> +\t\t\t\tespi_ctrl: espi-ctrl at 0 {\n" + "> +\t\t\t\tespi_ctrl: espi-ctrl@0 {\n" "> +\t\t\t\t\t\tcompatible = \"aspeed,ast2600-espi-ctrl\";\n" "> +\t\t\t\t\t\treg = <0x0 0x800>,<0x0 0x4000000>;\n" "> +\t\t\t\t\t\treg-names = \"espi_ctrl\",\"espi_flash\";\n" @@ -247,8 +265,13 @@ "Wrong indentation.\n" "\n" "> +\t\t\t};\n" - "> \t\t\tgpio0: gpio at 1e780000 {\n" + "> \t\t\tgpio0: gpio@1e780000 {\n" "> \t\t\t\t#gpio-cells = <2>;\n" - "> \t\t\t\tgpio-controller;" + "> \t\t\t\tgpio-controller;\n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -4148fb78eecdf953f20e5e79a706ca0c99078f1c701c0424e5cb92b66499d77b +9e67b3e82a7cb567d91bdd56e6690c359a9b0a9a67aa8c0cdcc4c48feff4939e
diff --git a/a/1.txt b/N4/1.txt index ca132ae..5a64242 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -19,7 +19,7 @@ right? > > I'm presenting a revised version of the eSPI device driver patch series found at the following link: > -> https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang at aspeedtech.com/ +> https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang@aspeedtech.com/ > > This update addresses the issues identified during the review process. > @@ -192,7 +192,7 @@ Is this really a separate sub-block? > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/ast2600-clock.h> > + -> + espi: espi at 1e6ee000 { +> + espi: espi@1e6ee000 { > + compatible = "aspeed,ast2600-espi", "simple-mfd", "syscon"; > + reg = <0x1e6ee000 0x1000>; > + @@ -200,14 +200,14 @@ Is this really a separate sub-block? > + #size-cells = <1>; > + ranges = <0x0 0x1e6ee000 0x1000>; > + -> + espi_ctrl: espi-ctrl at 0 { +> + espi_ctrl: espi-ctrl@0 { > + compatible = "aspeed,ast2600-espi-ctrl"; > + reg = <0x0 0x800>; > + interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&syscon ASPEED_CLK_GATE_ESPICLK>; > + }; > + -> + espi_mmbi: espi-mmbi at 800 { +> + espi_mmbi: espi-mmbi@800 { > + compatible = "aspeed,ast2600-espi-mmbi"; > + reg = <0x800 0x50>; > + interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; @@ -217,18 +217,18 @@ Is this really a separate sub-block? > index c4d1faade8be..08d7a2689086 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi -> @@ -453,7 +453,21 @@ video: video at 1e700000 { +> @@ -453,7 +453,21 @@ video: video@1e700000 { > interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; > status = "disabled"; > }; > - -> + espi: espi at 1e6ee000 { +> + espi: espi@1e6ee000 { > + compatible = "aspeed,ast2600-espi", "simple-mfd", "syscon"; > + reg = <0x1e6ee000 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x1e6ee000 0x1000>; -> + espi_ctrl: espi-ctrl at 0 { +> + espi_ctrl: espi-ctrl@0 { > + compatible = "aspeed,ast2600-espi-ctrl"; > + reg = <0x0 0x800>,<0x0 0x4000000>; > + reg-names = "espi_ctrl","espi_flash"; @@ -240,6 +240,6 @@ Is this really a separate sub-block? Wrong indentation. > + }; -> gpio0: gpio at 1e780000 { +> gpio0: gpio@1e780000 { > #gpio-cells = <2>; > gpio-controller; diff --git a/a/content_digest b/N4/content_digest index c3df52f..dfe927f 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -1,8 +1,26 @@ "ref\020240213-espi_driver-v1-1-92741c812843@gmail.com\0" "From\0Rob Herring <robh@kernel.org>\0" - "Subject\0[PATCH] Add eSPI device driver (flash channel)\0" + "Subject\0Re: [PATCH] Add eSPI device driver (flash channel)\0" "Date\0Tue, 13 Feb 2024 16:28:08 -0600\0" - "To\0linux-aspeed@lists.ozlabs.org\0" + "To\0Manojkiran Eda <manojkiran.eda@gmail.com>\0" + "Cc\0Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>" + Conor Dooley <conor+dt@kernel.org> + Joel Stanley <joel@jms.id.au> + Andrew Jeffery <andrew@codeconstruct.com.au> + Miquel Raynal <miquel.raynal@bootlin.com> + Richard Weinberger <richard@nod.at> + Vignesh Raghavendra <vigneshr@ti.com> + jk@codeconstruct.com.au + Patrick Rudolph <patrick.rudolph@9elements.com> + Chia-Wei Wang <chiawei_wang@aspeedtech.com> + Ryan Chen <ryan_chen@aspeedtech.com> + devicetree@vger.kernel.org + linux-arm-kernel@lists.infradead.org + linux-aspeed@lists.ozlabs.org + linux-kernel@vger.kernel.org + linux-mtd@lists.infradead.org + openbmc@lists.ozlabs.org + " zev@bewilderbeest.net\0" "\00:1\0" "b\0" "On Tue, Feb 13, 2024 at 08:06:08PM +0530, Manojkiran Eda wrote:\n" @@ -26,7 +44,7 @@ "> \n" "> I'm presenting a revised version of the eSPI device driver patch series found at the following link:\n" "> \n" - "> https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang at aspeedtech.com/ \n" + "> https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang@aspeedtech.com/ \n" "> \n" "> This update addresses the issues identified during the review process.\n" "> \n" @@ -199,7 +217,7 @@ "> + #include <dt-bindings/interrupt-controller/arm-gic.h>\n" "> + #include <dt-bindings/clock/ast2600-clock.h>\n" "> +\n" - "> + espi: espi at 1e6ee000 {\n" + "> + espi: espi@1e6ee000 {\n" "> + compatible = \"aspeed,ast2600-espi\", \"simple-mfd\", \"syscon\";\n" "> + reg = <0x1e6ee000 0x1000>;\n" "> +\n" @@ -207,14 +225,14 @@ "> + #size-cells = <1>;\n" "> + ranges = <0x0 0x1e6ee000 0x1000>;\n" "> +\n" - "> + espi_ctrl: espi-ctrl at 0 {\n" + "> + espi_ctrl: espi-ctrl@0 {\n" "> + compatible = \"aspeed,ast2600-espi-ctrl\";\n" "> + reg = <0x0 0x800>;\n" "> + interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;\n" "> + clocks = <&syscon ASPEED_CLK_GATE_ESPICLK>;\n" "> + };\n" "> +\n" - "> + espi_mmbi: espi-mmbi at 800 {\n" + "> + espi_mmbi: espi-mmbi@800 {\n" "> + compatible = \"aspeed,ast2600-espi-mmbi\";\n" "> + reg = <0x800 0x50>;\n" "> + interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;\n" @@ -224,18 +242,18 @@ "> index c4d1faade8be..08d7a2689086 100644\n" "> --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi\n" "> +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi\n" - "> @@ -453,7 +453,21 @@ video: video at 1e700000 {\n" + "> @@ -453,7 +453,21 @@ video: video@1e700000 {\n" "> \t\t\t\tinterrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;\n" "> \t\t\t\tstatus = \"disabled\";\n" "> \t\t\t};\n" "> -\n" - "> +\t\t\tespi: espi at 1e6ee000 {\n" + "> +\t\t\tespi: espi@1e6ee000 {\n" "> +\t\t\t\tcompatible = \"aspeed,ast2600-espi\", \"simple-mfd\", \"syscon\";\n" "> +\t\t\t\treg = <0x1e6ee000 0x1000>;\n" "> +\t\t\t\t#address-cells = <1>;\n" "> +\t\t\t\t#size-cells = <1>;\n" "> +\t\t\t\tranges = <0x0 0x1e6ee000 0x1000>;\n" - "> +\t\t\t\tespi_ctrl: espi-ctrl at 0 {\n" + "> +\t\t\t\tespi_ctrl: espi-ctrl@0 {\n" "> +\t\t\t\t\t\tcompatible = \"aspeed,ast2600-espi-ctrl\";\n" "> +\t\t\t\t\t\treg = <0x0 0x800>,<0x0 0x4000000>;\n" "> +\t\t\t\t\t\treg-names = \"espi_ctrl\",\"espi_flash\";\n" @@ -247,8 +265,8 @@ "Wrong indentation.\n" "\n" "> +\t\t\t};\n" - "> \t\t\tgpio0: gpio at 1e780000 {\n" + "> \t\t\tgpio0: gpio@1e780000 {\n" "> \t\t\t\t#gpio-cells = <2>;\n" "> \t\t\t\tgpio-controller;" -4148fb78eecdf953f20e5e79a706ca0c99078f1c701c0424e5cb92b66499d77b +a31cd5b5ee41857024882b53d8ae7865b8b57cd4cb8f2991118ff793e1c45d05
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.