All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [jlayton:dir-deleg 12/12] fs/namei.c:4103: warning: Function parameter or struct member 'delegated_inode' not described in 'vfs_mkdir'
Date: Wed, 14 Feb 2024 00:48:07 +0800	[thread overview]
Message-ID: <202402140044.JisAKFFn-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git dir-deleg
head:   bc750b374b938c02896586cd7fa7d3b8f66b89d2
commit: bc750b374b938c02896586cd7fa7d3b8f66b89d2 [12/12] vfs: allow mkdir to wait for delegation break on parent
config: parisc-defconfig (https://download.01.org/0day-ci/archive/20240214/202402140044.JisAKFFn-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240214/202402140044.JisAKFFn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402140044.JisAKFFn-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/namei.c:4103: warning: Function parameter or struct member 'delegated_inode' not described in 'vfs_mkdir'


vim +4103 fs/namei.c

5590ff0d5528b6 Ulrich Drepper        2006-01-18  4085  
6521f891708292 Christian Brauner     2021-01-21  4086  /**
6521f891708292 Christian Brauner     2021-01-21  4087   * vfs_mkdir - create directory
abf08576afe315 Christian Brauner     2023-01-13  4088   * @idmap:	idmap of the mount the inode was found from
6521f891708292 Christian Brauner     2021-01-21  4089   * @dir:	inode of @dentry
6521f891708292 Christian Brauner     2021-01-21  4090   * @dentry:	pointer to dentry of the base directory
6521f891708292 Christian Brauner     2021-01-21  4091   * @mode:	mode of the new directory
6521f891708292 Christian Brauner     2021-01-21  4092   *
6521f891708292 Christian Brauner     2021-01-21  4093   * Create a directory.
6521f891708292 Christian Brauner     2021-01-21  4094   *
abf08576afe315 Christian Brauner     2023-01-13  4095   * If the inode has been found through an idmapped mount the idmap of
abf08576afe315 Christian Brauner     2023-01-13  4096   * the vfsmount must be passed through @idmap. This function will then take
abf08576afe315 Christian Brauner     2023-01-13  4097   * care to map the inode according to @idmap before checking permissions.
6521f891708292 Christian Brauner     2021-01-21  4098   * On non-idmapped mounts or if permission checking is to be performed on the
376870aa234439 Alexander Mikhalitsyn 2023-12-15  4099   * raw inode simply pass @nop_mnt_idmap.
6521f891708292 Christian Brauner     2021-01-21  4100   */
abf08576afe315 Christian Brauner     2023-01-13  4101  int vfs_mkdir(struct mnt_idmap *idmap, struct inode *dir,
bc750b374b938c Jeff Layton           2024-02-12  4102  	      struct dentry *dentry, umode_t mode, struct inode **delegated_inode)
^1da177e4c3f41 Linus Torvalds        2005-04-16 @4103  {
abf08576afe315 Christian Brauner     2023-01-13  4104  	int error;
8de52778798fe3 Al Viro               2012-02-06  4105  	unsigned max_links = dir->i_sb->s_max_links;
^1da177e4c3f41 Linus Torvalds        2005-04-16  4106  
4609e1f18e19c3 Christian Brauner     2023-01-13  4107  	error = may_create(idmap, dir, dentry);
^1da177e4c3f41 Linus Torvalds        2005-04-16  4108  	if (error)
^1da177e4c3f41 Linus Torvalds        2005-04-16  4109  		return error;
^1da177e4c3f41 Linus Torvalds        2005-04-16  4110  
acfa4380efe77e Al Viro               2008-12-04  4111  	if (!dir->i_op->mkdir)
^1da177e4c3f41 Linus Torvalds        2005-04-16  4112  		return -EPERM;
^1da177e4c3f41 Linus Torvalds        2005-04-16  4113  
9452e93e6dae86 Christian Brauner     2023-01-13  4114  	mode = vfs_prepare_mode(idmap, dir, mode, S_IRWXUGO | S_ISVTX, 0);
^1da177e4c3f41 Linus Torvalds        2005-04-16  4115  	error = security_inode_mkdir(dir, dentry, mode);
^1da177e4c3f41 Linus Torvalds        2005-04-16  4116  	if (error)
^1da177e4c3f41 Linus Torvalds        2005-04-16  4117  		return error;
^1da177e4c3f41 Linus Torvalds        2005-04-16  4118  
8de52778798fe3 Al Viro               2012-02-06  4119  	if (max_links && dir->i_nlink >= max_links)
8de52778798fe3 Al Viro               2012-02-06  4120  		return -EMLINK;
8de52778798fe3 Al Viro               2012-02-06  4121  
c54bd91e9eaba4 Christian Brauner     2023-01-13  4122  	error = dir->i_op->mkdir(idmap, dir, dentry, mode);
a74574aafea3a6 Stephen Smalley       2005-09-09  4123  	if (!error)
f38aa94224c551 Amy Griffis           2005-11-03  4124  		fsnotify_mkdir(dir, dentry);
^1da177e4c3f41 Linus Torvalds        2005-04-16  4125  	return error;
^1da177e4c3f41 Linus Torvalds        2005-04-16  4126  }
4d359507346a15 Al Viro               2014-03-14  4127  EXPORT_SYMBOL(vfs_mkdir);
^1da177e4c3f41 Linus Torvalds        2005-04-16  4128  

:::::: The code at line 4103 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-02-13 16:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202402140044.JisAKFFn-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=jlayton@kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.