From: Tony Lindgren <tony@atomide.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Petr Mladek" <pmladek@suse.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"John Ogness" <john.ogness@linutronix.de>,
"Sergey Senozhatsky" <senozhatsky@chromium.org>,
"David S . Miller" <davem@davemloft.net>,
"Dhruva Gole" <d-gole@ti.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Johan Hovold" <johan@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v6 1/6] printk: Save console options for add_preferred_console_match()
Date: Wed, 14 Feb 2024 10:51:38 +0200 [thread overview]
Message-ID: <20240214085138.GQ52537@atomide.com> (raw)
In-Reply-To: <20240214084905.GP52537@atomide.com>
* Tony Lindgren <tony@atomide.com> [240214 10:49]:
> * Andy Shevchenko <andriy.shevchenko@linux.intel.com> [240213 16:42]:
> > strscpy(con->name, str, namelen);
> > strscpy(con->opt, opt, optlen); // not sure if emptying opt is okay
>
> The strings above now get terminated too sort with the + 1 removed,
> I suggest we use what we already do for brl_opt:
>
> strscpy(con->name, str, CONSOLE_NAME_MAX);
> strscpy(con->opt, opt, CONSOLE_OPT_MAX);
>
Heh but that won't work for str and CONSOLE_NAME_MAX..
Tony
next prev parent reply other threads:[~2024-02-14 8:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 8:45 [PATCH v6 0/6] Add support for DEVNAME:0.0 style hardware based addressing Tony Lindgren
2024-02-13 8:45 ` [PATCH v6 1/6] printk: Save console options for add_preferred_console_match() Tony Lindgren
2024-02-13 16:41 ` Andy Shevchenko
2024-02-14 7:59 ` Tony Lindgren
2024-02-14 8:49 ` Tony Lindgren
2024-02-14 8:51 ` Tony Lindgren [this message]
2024-02-13 8:45 ` [PATCH v6 2/6] printk: Don't try to parse DEVNAME:0.0 console options Tony Lindgren
2024-02-13 8:45 ` [PATCH v6 3/6] printk: Flag register_console() if console is set on command line Tony Lindgren
2024-02-13 8:45 ` [PATCH v6 4/6] serial: core: Add support for DEVNAME:0.0 style naming for kernel console Tony Lindgren
2024-02-13 15:53 ` Andy Shevchenko
2024-02-14 6:02 ` Tony Lindgren
2024-02-13 23:58 ` Sebastian Reichel
2024-02-14 7:08 ` Tony Lindgren
2024-02-14 9:00 ` Dan Carpenter
2024-02-14 9:03 ` Tony Lindgren
2024-02-13 8:45 ` [PATCH v6 5/6] serial: core: Handle serial console options Tony Lindgren
2024-02-13 15:56 ` Andy Shevchenko
2024-02-13 8:45 ` [PATCH v6 6/6] serial: 8250: Add preferred console in serial8250_isa_init_ports() Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240214085138.GQ52537@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=d-gole@ti.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.