All of lore.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>, Niklas Cassel <cassel@kernel.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	linux-ide@vger.kernel.org
Subject: [PATCH v2 3/4] ahci: drop unused board_ahci_noncq
Date: Wed, 14 Feb 2024 14:00:11 +0100	[thread overview]
Message-ID: <20240214130015.952685-4-cassel@kernel.org> (raw)
In-Reply-To: <20240214130015.952685-1-cassel@kernel.org>

Since commit 66a7cbc303f4 ("ahci: disable MSI instead of NCQ on Samsung
pci-e SSDs on macbooks") there is not a single entry in ahci_pci_tbl
which uses board_ahci_noncq.

Since this is dead code, let's remove it.
We cannot remove AHCI_HFLAG_NO_NCQ, as this flag is still used by other
boards.

Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
 drivers/ata/ahci.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index d8e5b26524f6..9bff90fb0591 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -52,7 +52,6 @@ enum board_ids {
 	board_ahci_ign_iferr,
 	board_ahci_no_debounce_delay,
 	board_ahci_nomsi,
-	board_ahci_noncq,
 	/*
 	 * board_ahci_pcs_quirk is for legacy Intel platforms.
 	 * Modern Intel platforms should use board_ahci instead.
@@ -159,13 +158,6 @@ static const struct ata_port_info ahci_port_info[] = {
 		.udma_mask	= ATA_UDMA6,
 		.port_ops	= &ahci_ops,
 	},
-	[board_ahci_noncq] = {
-		AHCI_HFLAGS	(AHCI_HFLAG_NO_NCQ),
-		.flags		= AHCI_FLAG_COMMON,
-		.pio_mask	= ATA_PIO4,
-		.udma_mask	= ATA_UDMA6,
-		.port_ops	= &ahci_ops,
-	},
 	[board_ahci_pcs_quirk] = {
 		AHCI_HFLAGS	(AHCI_HFLAG_INTEL_PCS_QUIRK),
 		.flags		= AHCI_FLAG_COMMON,
-- 
2.43.0


  parent reply	other threads:[~2024-02-14 13:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-14 13:00 [PATCH v2 0/4] ahci minor quirk cleanups Niklas Cassel
2024-02-14 13:00 ` [PATCH v2 1/4] ahci: rename board_ahci_nosntf Niklas Cassel
2024-02-15 22:32   ` Damien Le Moal
2024-02-14 13:00 ` [PATCH v2 2/4] ahci: clean up ahci_broken_devslp quirk Niklas Cassel
2024-02-15 22:34   ` Damien Le Moal
2024-02-14 13:00 ` Niklas Cassel [this message]
2024-02-15 22:35   ` [PATCH v2 3/4] ahci: drop unused board_ahci_noncq Damien Le Moal
2024-02-14 13:00 ` [PATCH v2 4/4] ahci: rename board_ahci_nomsi Niklas Cassel
2024-02-15 22:36   ` Damien Le Moal
2024-02-16 11:19 ` [PATCH v2 0/4] ahci minor quirk cleanups Mika Westerberg
2024-02-19  9:12 ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240214130015.952685-4-cassel@kernel.org \
    --to=cassel@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dlemoal@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.