From: Oleg Nesterov <oleg@redhat.com>
To: Tycho Andersen <tycho@tycho.pizza>
Cc: coverity-bot <keescook@chromium.org>,
Christian Brauner <brauner@kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Peng Zhang <zhangpeng.00@bytedance.com>,
Ard Biesheuvel <ardb@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Suren Baghdasaryan <surenb@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Mateusz Guzik <mjguzik@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Tycho Andersen <tandersen@netflix.com>,
Mike Christie <michael.christie@oracle.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: Coverity: __do_sys_pidfd_send_signal(): UNINIT
Date: Wed, 14 Feb 2024 20:18:01 +0100 [thread overview]
Message-ID: <20240214191801.GA27799@redhat.com> (raw)
In-Reply-To: <Zc0Ca5te+QFBZ1U6@tycho.pizza>
On 02/14, Tycho Andersen wrote:
>
> On Wed, Feb 14, 2024 at 06:55:55PM +0100, Oleg Nesterov wrote:
> >
> > We want to check the "flags" argument at the start, we do not want to
> > delay the "case 0:" check until we have f.file (so that we can check
> > f.file->f_flags).
>
> Fair point. I was thinking delaying it would make it simpler, but then
> you have to free the file and it's less fast in the EINVAL case.
plus we do not want to return, say, -EBADF if the "flags" argument is wrong.
> I also don't have a strong opinion here.
Neither me.
Oleg.
next prev parent reply other threads:[~2024-02-14 19:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 23:59 Coverity: __do_sys_pidfd_send_signal(): UNINIT coverity-bot
2024-02-14 0:18 ` Tycho Andersen
2024-02-14 9:03 ` Oleg Nesterov
2024-02-14 9:06 ` Oleg Nesterov
2024-02-14 14:18 ` Tycho Andersen
2024-02-14 17:55 ` Oleg Nesterov
2024-02-14 18:11 ` Tycho Andersen
2024-02-14 19:18 ` Oleg Nesterov [this message]
2024-02-16 12:37 ` Christian Brauner
2024-02-14 18:51 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240214191801.GA27799@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=brauner@kernel.org \
--cc=dvyukov@google.com \
--cc=gustavo@embeddedor.com \
--cc=hca@linux.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=michael.christie@oracle.com \
--cc=mjguzik@gmail.com \
--cc=npiggin@gmail.com \
--cc=paulmck@kernel.org \
--cc=surenb@google.com \
--cc=tandersen@netflix.com \
--cc=tglx@linutronix.de \
--cc=tycho@tycho.pizza \
--cc=zhangpeng.00@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.