All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Joel Fernandes (Google)" <joel@joelfernandes.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [jfern:dlserver-feb-fixes 1/9] kernel/sched/deadline.c:2293:28: warning: 'pick_task_dl' defined but not used
Date: Wed, 14 Feb 2024 20:19:38 +0800	[thread overview]
Message-ID: <202402142010.v2iLoCSc-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git dlserver-feb-fixes
head:   a81d7e41130fa46e91bde4dd820f673250934286
commit: 60503246d2cf0d7b91d18325cb21c24c13f1d40d [1/9] sched/core: Add clearing of ->dl_server in put_prev_task_balance()
config: csky-randconfig-r081-20240214 (https://download.01.org/0day-ci/archive/20240214/202402142010.v2iLoCSc-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240214/202402142010.v2iLoCSc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402142010.v2iLoCSc-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from kernel/sched/build_policy.c:53:
   kernel/sched/deadline.c: In function 'dl_server_init':
   kernel/sched/deadline.c:1563:16: error: 'struct sched_dl_entity' has no member named 'server_pick_next'; did you mean 'server_pick'?
    1563 |         dl_se->server_pick_next = pick_next;
         |                ^~~~~~~~~~~~~~~~
         |                server_pick
   kernel/sched/deadline.c:1564:16: error: 'struct sched_dl_entity' has no member named 'server_pick_task'; did you mean 'server_has_tasks'?
    1564 |         dl_se->server_pick_task = pick_task;
         |                ^~~~~~~~~~~~~~~~
         |                server_has_tasks
   kernel/sched/deadline.c: In function 'pick_task_dl_next':
   kernel/sched/deadline.c:2278:28: error: 'struct sched_dl_entity' has no member named 'server_pick_next'; did you mean 'server_pick'?
    2278 |                 p = dl_se->server_pick_next(dl_se);
         |                            ^~~~~~~~~~~~~~~~
         |                            server_pick
   kernel/sched/deadline.c: In function 'pick_task_dl':
   kernel/sched/deadline.c:2307:28: error: 'struct sched_dl_entity' has no member named 'server_pick_task'; did you mean 'server_has_tasks'?
    2307 |                 p = dl_se->server_pick_task(dl_se);
         |                            ^~~~~~~~~~~~~~~~
         |                            server_has_tasks
   kernel/sched/deadline.c: At top level:
>> kernel/sched/deadline.c:2293:28: warning: 'pick_task_dl' defined but not used [-Wunused-function]
    2293 | static struct task_struct *pick_task_dl(struct rq *rq)
         |                            ^~~~~~~~~~~~
   In file included from kernel/sched/build_policy.c:45:
   kernel/sched/rt.c:968:13: warning: '__disable_runtime' defined but not used [-Wunused-function]
     968 | static void __disable_runtime(struct rq *rq) { }
         |             ^~~~~~~~~~~~~~~~~
   kernel/sched/rt.c:967:13: warning: '__enable_runtime' defined but not used [-Wunused-function]
     967 | static void __enable_runtime(struct rq *rq) { }
         |             ^~~~~~~~~~~~~~~~


vim +/pick_task_dl +2293 kernel/sched/deadline.c

  2263	
  2264	static struct task_struct *pick_task_dl_next(struct rq *rq)
  2265	{
  2266		struct sched_dl_entity *dl_se;
  2267		struct dl_rq *dl_rq = &rq->dl;
  2268		struct task_struct *p;
  2269	
  2270	again:
  2271		if (!sched_dl_runnable(rq))
  2272			return NULL;
  2273	
  2274		dl_se = pick_next_dl_entity(dl_rq);
  2275		BUG_ON(!dl_se);
  2276	
  2277		if (dl_server(dl_se)) {
  2278			p = dl_se->server_pick_next(dl_se);
  2279			if (!p) {
  2280				WARN_ON_ONCE(1);
  2281				dl_se->dl_yielded = 1;
  2282				update_curr_dl_se(rq, dl_se, 0);
  2283				goto again;
  2284			}
  2285			p->dl_server = dl_se;
  2286		} else {
  2287			p = dl_task_of(dl_se);
  2288			p->dl_server = NULL;
  2289		}
  2290	
  2291		return p;
  2292	}
> 2293	static struct task_struct *pick_task_dl(struct rq *rq)
  2294	{
  2295		struct sched_dl_entity *dl_se;
  2296		struct dl_rq *dl_rq = &rq->dl;
  2297		struct task_struct *p;
  2298	
  2299	again:
  2300		if (!sched_dl_runnable(rq))
  2301			return NULL;
  2302	
  2303		dl_se = pick_next_dl_entity(dl_rq);
  2304		WARN_ON_ONCE(!dl_se);
  2305	
  2306		if (dl_server(dl_se)) {
  2307			p = dl_se->server_pick_task(dl_se);
  2308			if (!p) {
  2309				WARN_ON_ONCE(1);
  2310				goto again;
  2311			}
  2312	
  2313			/* Set after ->server_pick_task() since that may clear it. */
  2314			p->dl_server = dl_se;
  2315		} else {
  2316			p = dl_task_of(dl_se);
  2317		}
  2318	
  2319		return p;
  2320	}
  2321	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-02-14 12:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202402142010.v2iLoCSc-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=joel@joelfernandes.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.