From mboxrd@z Thu Jan 1 00:00:00 1970 From: Conor Dooley Date: Thu, 15 Feb 2024 17:12:50 +0000 Subject: =?utf-8?B?5Zue6KaG?= =?utf-8?Q?=3A?= [PATCH] Add eSPI device driver (flash channel) In-Reply-To: References: <20240213-espi_driver-v1-1-92741c812843@gmail.com> <20240214-yoyo-platinum-dcd0e7e16a22@spud> Message-ID: <20240215-probable-gimmick-83d5dcbc4729@spud> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Feb 15, 2024 at 01:56:00AM +0000, ChiaWei Wang wrote: > > > > On Wed, Feb 14, 2024 at 11:34:31AM +0000, ChiaWei Wang wrote: > > > We appreciate that you are willing to help on the open source contribution. > > > However, please co-work with Aspeed before submitting drivers of Aspeed > > HW. > > > Otherwise, a misleading driver on the community are going to bring tons of > > customer issues to Aspeed. > > > > It may not apply in this particular case as Aspeed did write the original driver > > and it is polite to work with previous authors when respinning a patchset, but in > > general there is no need to work with a hardware vendor before writing drivers > > for their hardware. > > > > Blocking a driver because that company might receive more support requests > > is not the kernel's problem. > > I agree with that and Aspeed will not refuse to support. > > However, in this case, the authors, IBM, and Aspeed already have discussion (at least 4 times) before and foresee "issues" on practical eSPI SAFS use. > If there is already a known issue of the driver, why ignoring the previous discussion and push it? > A compromise is to ask for driver renaming to espi-mafs to avoid confusion. > Otherwise we need to explain, again, why the driver does not fulfill the SAFS expectation. To be clear, in case you misunderstood, I was making a general point and not about this particular patchset. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFF99C48BC4 for ; Thu, 15 Feb 2024 17:13:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JGmGSve3A3sm2Y7heBr5Jb6RGwZCtrV4BgkvWCfNHhs=; b=aH2D8HtVo2dsG3fa2YMTOSJrl8 TH/iCkhg6GO0aouTyqud754d/Px0n1vuFtQOuGIsBjR8SanKBPq4RtV+IyyDL2ZK0ihH4Lw0H4KLl h0IkGEyhzSIlV6/Mctcbx9viLq1xoD5yRG584Q5HpblR2/SGR2kY35JFMXoMNFs5nAcD0jEZwxjxD PHMNtu/UzvEVln5HkhjA8YeYL0fvVqP5ZXHjtnSWGGSbjqGP0oUjUworJKkS6EnaZexhPt9JPYOg9 +w3YfaOHsmeUOV4Of1H3kEInn5qeT+gSsAGbi7dcJNMrpx5gTTp2Yhpulr1xBZsdJndvH1KCq4IsE qopWk4ZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rafIF-0000000H84s-26GS; Thu, 15 Feb 2024 17:13:03 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rafIB-0000000H840-0c2b; Thu, 15 Feb 2024 17:13:00 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 3694BCE27B2; Thu, 15 Feb 2024 17:12:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA9E1C433F1; Thu, 15 Feb 2024 17:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708017176; bh=pk5Mt+RImQXUgBvMKAZepH41L3RMj9FKexYkzEU54nI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TRi71hB4J37HDQh3t1ZfohcSCokTMBTIWFlXk8unUCZGAcnbgcFAYuiLZDhQSHFXj hxT+sMSSa2T7IKUkyx7sMVbr5h3zjN/ggkblR69V4kg7xZzVEX0XWnHoIpww+EM64f A/IKw8J0A4lekCriXehJQD7MMFAJLD5unYXKPBQw7v1i5jMUSFLktChLwDH/olDmr6 CSUZZqPuqBvJ7A4Wk6rpL/Vmhtlp2D1ikj2A+r1ja3TPU7uhZn0ER6svRLkWUeWRSX tp1lzO4k5PRCYHeyCQPLN1SV82Rn1Ywh92tYhNObqXrzSMmHq0Ei9DTSfRNleeWcss 5jDYkHp02pV+Q== Date: Thu, 15 Feb 2024 17:12:50 +0000 From: Conor Dooley To: ChiaWei Wang Cc: Manojkiran Eda , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , "jk@codeconstruct.com.au" , Patrick Rudolph , Ryan Chen , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "openbmc@lists.ozlabs.org" , "zev@bewilderbeest.net" Subject: Re: =?utf-8?B?5Zue6KaG?= =?utf-8?Q?=3A?= [PATCH] Add eSPI device driver (flash channel) Message-ID: <20240215-probable-gimmick-83d5dcbc4729@spud> References: <20240213-espi_driver-v1-1-92741c812843@gmail.com> <20240214-yoyo-platinum-dcd0e7e16a22@spud> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240215_091259_561112_319282AD X-CRM114-Status: GOOD ( 21.10 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3494119693595254560==" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org --===============3494119693595254560== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jYXpxHj7B0OPYCKZ" Content-Disposition: inline --jYXpxHj7B0OPYCKZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 15, 2024 at 01:56:00AM +0000, ChiaWei Wang wrote: > >=20 > > On Wed, Feb 14, 2024 at 11:34:31AM +0000, ChiaWei Wang wrote: > > > We appreciate that you are willing to help on the open source contrib= ution. > > > However, please co-work with Aspeed before submitting drivers of Aspe= ed > > HW. > > > Otherwise, a misleading driver on the community are going to bring to= ns of > > customer issues to Aspeed. > >=20 > > It may not apply in this particular case as Aspeed did write the origin= al driver > > and it is polite to work with previous authors when respinning a patchs= et, but in > > general there is no need to work with a hardware vendor before writing = drivers > > for their hardware. > >=20 > > Blocking a driver because that company might receive more support reque= sts > > is not the kernel's problem. >=20 > I agree with that and Aspeed will not refuse to support. >=20 > However, in this case, the authors, IBM, and Aspeed already have discussi= on (at least 4 times) before and foresee "issues" on practical eSPI SAFS us= e. > If there is already a known issue of the driver, why ignoring the previou= s discussion and push it? > A compromise is to ask for driver renaming to espi-mafs to avoid confusio= n. > Otherwise we need to explain, again, why the driver does not fulfill the = SAFS expectation. To be clear, in case you misunderstood, I was making a general point and not about this particular patchset. --jYXpxHj7B0OPYCKZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZc5GEgAKCRB4tDGHoIJi 0q6qAQCwK7ClX6/ipMYZ/2VmkvC0xZdaAiUrt57wlJ0DcnoxoAD+OADevy96or/y yayrHHRwjY2W37V1/RxOp8h0jhl17QU= =71+s -----END PGP SIGNATURE----- --jYXpxHj7B0OPYCKZ-- --===============3494119693595254560== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ --===============3494119693595254560==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCC4AC4829E for ; Thu, 15 Feb 2024 17:13:59 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=TRi71hB4; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TbM9K73TTz3dk2 for ; Fri, 16 Feb 2024 04:13:57 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=TRi71hB4; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:40e1:4800::1; helo=sin.source.kernel.org; envelope-from=conor@kernel.org; receiver=lists.ozlabs.org) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TbM8F5TXKz3cT2; Fri, 16 Feb 2024 04:13:01 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 3694BCE27B2; Thu, 15 Feb 2024 17:12:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA9E1C433F1; Thu, 15 Feb 2024 17:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708017176; bh=pk5Mt+RImQXUgBvMKAZepH41L3RMj9FKexYkzEU54nI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TRi71hB4J37HDQh3t1ZfohcSCokTMBTIWFlXk8unUCZGAcnbgcFAYuiLZDhQSHFXj hxT+sMSSa2T7IKUkyx7sMVbr5h3zjN/ggkblR69V4kg7xZzVEX0XWnHoIpww+EM64f A/IKw8J0A4lekCriXehJQD7MMFAJLD5unYXKPBQw7v1i5jMUSFLktChLwDH/olDmr6 CSUZZqPuqBvJ7A4Wk6rpL/Vmhtlp2D1ikj2A+r1ja3TPU7uhZn0ER6svRLkWUeWRSX tp1lzO4k5PRCYHeyCQPLN1SV82Rn1Ywh92tYhNObqXrzSMmHq0Ei9DTSfRNleeWcss 5jDYkHp02pV+Q== Date: Thu, 15 Feb 2024 17:12:50 +0000 From: Conor Dooley To: ChiaWei Wang Subject: Re: =?utf-8?B?5Zue6KaG?= =?utf-8?Q?=3A?= [PATCH] Add eSPI device driver (flash channel) Message-ID: <20240215-probable-gimmick-83d5dcbc4729@spud> References: <20240213-espi_driver-v1-1-92741c812843@gmail.com> <20240214-yoyo-platinum-dcd0e7e16a22@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jYXpxHj7B0OPYCKZ" Content-Disposition: inline In-Reply-To: X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Conor Dooley , "zev@bewilderbeest.net" , Ryan Chen , Vignesh Raghavendra , "linux-aspeed@lists.ozlabs.org" , Richard Weinberger , "openbmc@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Rob Herring , "linux-mtd@lists.infradead.org" , Joel Stanley , Krzysztof Kozlowski , Miquel Raynal , "jk@codeconstruct.com.au" , Patrick Rudolph , Manojkiran Eda Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" --jYXpxHj7B0OPYCKZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 15, 2024 at 01:56:00AM +0000, ChiaWei Wang wrote: > >=20 > > On Wed, Feb 14, 2024 at 11:34:31AM +0000, ChiaWei Wang wrote: > > > We appreciate that you are willing to help on the open source contrib= ution. > > > However, please co-work with Aspeed before submitting drivers of Aspe= ed > > HW. > > > Otherwise, a misleading driver on the community are going to bring to= ns of > > customer issues to Aspeed. > >=20 > > It may not apply in this particular case as Aspeed did write the origin= al driver > > and it is polite to work with previous authors when respinning a patchs= et, but in > > general there is no need to work with a hardware vendor before writing = drivers > > for their hardware. > >=20 > > Blocking a driver because that company might receive more support reque= sts > > is not the kernel's problem. >=20 > I agree with that and Aspeed will not refuse to support. >=20 > However, in this case, the authors, IBM, and Aspeed already have discussi= on (at least 4 times) before and foresee "issues" on practical eSPI SAFS us= e. > If there is already a known issue of the driver, why ignoring the previou= s discussion and push it? > A compromise is to ask for driver renaming to espi-mafs to avoid confusio= n. > Otherwise we need to explain, again, why the driver does not fulfill the = SAFS expectation. To be clear, in case you misunderstood, I was making a general point and not about this particular patchset. --jYXpxHj7B0OPYCKZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZc5GEgAKCRB4tDGHoIJi 0q6qAQCwK7ClX6/ipMYZ/2VmkvC0xZdaAiUrt57wlJ0DcnoxoAD+OADevy96or/y yayrHHRwjY2W37V1/RxOp8h0jhl17QU= =71+s -----END PGP SIGNATURE----- --jYXpxHj7B0OPYCKZ-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA733C4829E for ; Thu, 15 Feb 2024 17:13:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Z/jwvL/aLoIl0tu5mB2AcpNNMhKDEx+eDR20CmOY6+M=; b=V441pSJG/o0PvsgQfU0EFNOkwi GszpkBPz9qNv/0FH0deGCixGAmSRMZgiiCpTQyqBOYNXyHtBQ2+fLPwHYkz6RiUkCZBV5+HSgnt61 JS5m8Tt+f2pP6SordjqTfCnaiX+i2G15zFwvAjwbddb0tW1JDjRWlZBOEhmRNjLAbRbp4WeECQ34a OqbzLNGV+w/FM06eZLAPAWTNHRSQM9zFQU9MinULzRAJsgfnLU/sXB8xXXO8qR1PbnGXUg90f8V3E 6qo2xT0ILhp9rHm55RqpP+s2U2u/xk+uEV+AqfKfI0jdoHhdvdFfYRWrI2yb4Y8AGEqR22IYZh1jq wuW84hHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rafIE-0000000H84i-3X5E; Thu, 15 Feb 2024 17:13:02 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rafIB-0000000H840-0c2b; Thu, 15 Feb 2024 17:13:00 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 3694BCE27B2; Thu, 15 Feb 2024 17:12:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA9E1C433F1; Thu, 15 Feb 2024 17:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708017176; bh=pk5Mt+RImQXUgBvMKAZepH41L3RMj9FKexYkzEU54nI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TRi71hB4J37HDQh3t1ZfohcSCokTMBTIWFlXk8unUCZGAcnbgcFAYuiLZDhQSHFXj hxT+sMSSa2T7IKUkyx7sMVbr5h3zjN/ggkblR69V4kg7xZzVEX0XWnHoIpww+EM64f A/IKw8J0A4lekCriXehJQD7MMFAJLD5unYXKPBQw7v1i5jMUSFLktChLwDH/olDmr6 CSUZZqPuqBvJ7A4Wk6rpL/Vmhtlp2D1ikj2A+r1ja3TPU7uhZn0ER6svRLkWUeWRSX tp1lzO4k5PRCYHeyCQPLN1SV82Rn1Ywh92tYhNObqXrzSMmHq0Ei9DTSfRNleeWcss 5jDYkHp02pV+Q== Date: Thu, 15 Feb 2024 17:12:50 +0000 From: Conor Dooley To: ChiaWei Wang Cc: Manojkiran Eda , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , "jk@codeconstruct.com.au" , Patrick Rudolph , Ryan Chen , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "openbmc@lists.ozlabs.org" , "zev@bewilderbeest.net" Subject: Re: =?utf-8?B?5Zue6KaG?= =?utf-8?Q?=3A?= [PATCH] Add eSPI device driver (flash channel) Message-ID: <20240215-probable-gimmick-83d5dcbc4729@spud> References: <20240213-espi_driver-v1-1-92741c812843@gmail.com> <20240214-yoyo-platinum-dcd0e7e16a22@spud> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240215_091259_561112_319282AD X-CRM114-Status: GOOD ( 21.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0202903264601077020==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0202903264601077020== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jYXpxHj7B0OPYCKZ" Content-Disposition: inline --jYXpxHj7B0OPYCKZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 15, 2024 at 01:56:00AM +0000, ChiaWei Wang wrote: > >=20 > > On Wed, Feb 14, 2024 at 11:34:31AM +0000, ChiaWei Wang wrote: > > > We appreciate that you are willing to help on the open source contrib= ution. > > > However, please co-work with Aspeed before submitting drivers of Aspe= ed > > HW. > > > Otherwise, a misleading driver on the community are going to bring to= ns of > > customer issues to Aspeed. > >=20 > > It may not apply in this particular case as Aspeed did write the origin= al driver > > and it is polite to work with previous authors when respinning a patchs= et, but in > > general there is no need to work with a hardware vendor before writing = drivers > > for their hardware. > >=20 > > Blocking a driver because that company might receive more support reque= sts > > is not the kernel's problem. >=20 > I agree with that and Aspeed will not refuse to support. >=20 > However, in this case, the authors, IBM, and Aspeed already have discussi= on (at least 4 times) before and foresee "issues" on practical eSPI SAFS us= e. > If there is already a known issue of the driver, why ignoring the previou= s discussion and push it? > A compromise is to ask for driver renaming to espi-mafs to avoid confusio= n. > Otherwise we need to explain, again, why the driver does not fulfill the = SAFS expectation. To be clear, in case you misunderstood, I was making a general point and not about this particular patchset. --jYXpxHj7B0OPYCKZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZc5GEgAKCRB4tDGHoIJi 0q6qAQCwK7ClX6/ipMYZ/2VmkvC0xZdaAiUrt57wlJ0DcnoxoAD+OADevy96or/y yayrHHRwjY2W37V1/RxOp8h0jhl17QU= =71+s -----END PGP SIGNATURE----- --jYXpxHj7B0OPYCKZ-- --===============0202903264601077020== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0202903264601077020==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F24F712882C; Thu, 15 Feb 2024 17:12:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708017177; cv=none; b=HRvmRyk0l0nNbG5Iwe/7U42AnM40ebMieKSZNxABhgixVVzbbwc51h+OiYRg20tIO19QEp1DVgy7igqMtHMGWN0XVtysavwY0OjYt91xyf/6RUBv4GksWM20eXDWWqckvLqkTVeLAERfMtRoS4uV4JObd17UnkhnftEanPhUnzc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708017177; c=relaxed/simple; bh=pk5Mt+RImQXUgBvMKAZepH41L3RMj9FKexYkzEU54nI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BVWB7rkkaJrrt+1WpkuBqw94fuji9yl0bqYsnyz/83ezx92euzLHpbhRksCWjFdENdEFk2W4OskNm4XkDmio7im3/NpifaOJaGeir4Fx5lHRpb40ZDuuh6BhAuRz/FaJx+b/pmLpnPx+TXpbfrHmMfoZyzxZ53eoxeo/d/oPSMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TRi71hB4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TRi71hB4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA9E1C433F1; Thu, 15 Feb 2024 17:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708017176; bh=pk5Mt+RImQXUgBvMKAZepH41L3RMj9FKexYkzEU54nI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TRi71hB4J37HDQh3t1ZfohcSCokTMBTIWFlXk8unUCZGAcnbgcFAYuiLZDhQSHFXj hxT+sMSSa2T7IKUkyx7sMVbr5h3zjN/ggkblR69V4kg7xZzVEX0XWnHoIpww+EM64f A/IKw8J0A4lekCriXehJQD7MMFAJLD5unYXKPBQw7v1i5jMUSFLktChLwDH/olDmr6 CSUZZqPuqBvJ7A4Wk6rpL/Vmhtlp2D1ikj2A+r1ja3TPU7uhZn0ER6svRLkWUeWRSX tp1lzO4k5PRCYHeyCQPLN1SV82Rn1Ywh92tYhNObqXrzSMmHq0Ei9DTSfRNleeWcss 5jDYkHp02pV+Q== Date: Thu, 15 Feb 2024 17:12:50 +0000 From: Conor Dooley To: ChiaWei Wang Cc: Manojkiran Eda , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , "jk@codeconstruct.com.au" , Patrick Rudolph , Ryan Chen , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "openbmc@lists.ozlabs.org" , "zev@bewilderbeest.net" Subject: Re: =?utf-8?B?5Zue6KaG?= =?utf-8?Q?=3A?= [PATCH] Add eSPI device driver (flash channel) Message-ID: <20240215-probable-gimmick-83d5dcbc4729@spud> References: <20240213-espi_driver-v1-1-92741c812843@gmail.com> <20240214-yoyo-platinum-dcd0e7e16a22@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jYXpxHj7B0OPYCKZ" Content-Disposition: inline In-Reply-To: --jYXpxHj7B0OPYCKZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 15, 2024 at 01:56:00AM +0000, ChiaWei Wang wrote: > >=20 > > On Wed, Feb 14, 2024 at 11:34:31AM +0000, ChiaWei Wang wrote: > > > We appreciate that you are willing to help on the open source contrib= ution. > > > However, please co-work with Aspeed before submitting drivers of Aspe= ed > > HW. > > > Otherwise, a misleading driver on the community are going to bring to= ns of > > customer issues to Aspeed. > >=20 > > It may not apply in this particular case as Aspeed did write the origin= al driver > > and it is polite to work with previous authors when respinning a patchs= et, but in > > general there is no need to work with a hardware vendor before writing = drivers > > for their hardware. > >=20 > > Blocking a driver because that company might receive more support reque= sts > > is not the kernel's problem. >=20 > I agree with that and Aspeed will not refuse to support. >=20 > However, in this case, the authors, IBM, and Aspeed already have discussi= on (at least 4 times) before and foresee "issues" on practical eSPI SAFS us= e. > If there is already a known issue of the driver, why ignoring the previou= s discussion and push it? > A compromise is to ask for driver renaming to espi-mafs to avoid confusio= n. > Otherwise we need to explain, again, why the driver does not fulfill the = SAFS expectation. To be clear, in case you misunderstood, I was making a general point and not about this particular patchset. --jYXpxHj7B0OPYCKZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZc5GEgAKCRB4tDGHoIJi 0q6qAQCwK7ClX6/ipMYZ/2VmkvC0xZdaAiUrt57wlJ0DcnoxoAD+OADevy96or/y yayrHHRwjY2W37V1/RxOp8h0jhl17QU= =71+s -----END PGP SIGNATURE----- --jYXpxHj7B0OPYCKZ--