From: Jason Xing <kerneljasonxing@gmail.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, dsahern@kernel.org, kuniyu@amazon.com
Cc: netdev@vger.kernel.org, kerneljasonxing@gmail.com,
Jason Xing <kernelxing@tencent.com>
Subject: [PATCH net-next v5 10/11] tcp: make dropreason in tcp_child_process() work
Date: Thu, 15 Feb 2024 09:20:26 +0800 [thread overview]
Message-ID: <20240215012027.11467-11-kerneljasonxing@gmail.com> (raw)
In-Reply-To: <20240215012027.11467-1-kerneljasonxing@gmail.com>
From: Jason Xing <kernelxing@tencent.com>
It's time to let it work right now. We've already prepared for this:)
Signed-off-by: Jason Xing <kernelxing@tencent.com>
---
net/ipv4/tcp_ipv4.c | 16 ++++++++++------
net/ipv6/tcp_ipv6.c | 16 ++++++++++------
2 files changed, 20 insertions(+), 12 deletions(-)
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index c79e25549972..c886c671fae9 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -1917,7 +1917,8 @@ int tcp_v4_do_rcv(struct sock *sk, struct sk_buff *skb)
if (!nsk)
return 0;
if (nsk != sk) {
- if (tcp_child_process(sk, nsk, skb)) {
+ reason = tcp_child_process(sk, nsk, skb);
+ if (reason) {
rsk = nsk;
goto reset;
}
@@ -2276,12 +2277,15 @@ int tcp_v4_rcv(struct sk_buff *skb)
if (nsk == sk) {
reqsk_put(req);
tcp_v4_restore_cb(skb);
- } else if (tcp_child_process(sk, nsk, skb)) {
- tcp_v4_send_reset(nsk, skb);
- goto discard_and_relse;
} else {
- sock_put(sk);
- return 0;
+ drop_reason = tcp_child_process(sk, nsk, skb);
+ if (drop_reason) {
+ tcp_v4_send_reset(nsk, skb);
+ goto discard_and_relse;
+ } else {
+ sock_put(sk);
+ return 0;
+ }
}
}
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index b13eb4985152..4b2afb9fe293 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -1654,7 +1654,8 @@ int tcp_v6_do_rcv(struct sock *sk, struct sk_buff *skb)
struct sock *nsk = tcp_v6_cookie_check(sk, skb);
if (nsk && nsk != sk) {
- if (tcp_child_process(sk, nsk, skb))
+ reason = tcp_child_process(sk, nsk, skb);
+ if (reason)
goto reset;
}
if (opt_skb)
@@ -1854,12 +1855,15 @@ INDIRECT_CALLABLE_SCOPE int tcp_v6_rcv(struct sk_buff *skb)
if (nsk == sk) {
reqsk_put(req);
tcp_v6_restore_cb(skb);
- } else if (tcp_child_process(sk, nsk, skb)) {
- tcp_v6_send_reset(nsk, skb);
- goto discard_and_relse;
} else {
- sock_put(sk);
- return 0;
+ drop_reason = tcp_child_process(sk, nsk, skb);
+ if (drop_reason) {
+ tcp_v6_send_reset(nsk, skb);
+ goto discard_and_relse;
+ } else {
+ sock_put(sk);
+ return 0;
+ }
}
}
--
2.37.3
next prev parent reply other threads:[~2024-02-15 1:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 1:20 [PATCH net-next v5 00/11] introduce drop reasons for tcp receive path Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 01/11] tcp: add a dropreason definitions and prepare for cookie check Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 02/11] tcp: directly drop skb in cookie check for ipv4 Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 03/11] tcp: use drop reasons " Jason Xing
2024-02-15 21:09 ` Kuniyuki Iwashima
2024-02-16 1:28 ` Jason Xing
2024-02-16 3:03 ` Kuniyuki Iwashima
2024-02-16 3:50 ` Jason Xing
2024-02-16 4:11 ` Kuniyuki Iwashima
2024-02-16 4:41 ` Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 04/11] tcp: directly drop skb in cookie check for ipv6 Jason Xing
2024-02-15 11:08 ` Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 05/11] tcp: use drop reasons " Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 06/11] tcp: introduce dropreasons in receive path Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 07/11] tcp: add more specific possible drop reasons in tcp_rcv_synsent_state_process() Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 08/11] tcp: add dropreasons in tcp_rcv_state_process() Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 09/11] tcp: make the dropreason really work when calling tcp_rcv_state_process() Jason Xing
2024-02-15 1:20 ` Jason Xing [this message]
2024-02-15 1:20 ` [PATCH net-next v5 11/11] tcp: get rid of NOT_SPECIFIED reason in tcp_v4/6_do_rcv Jason Xing
2024-02-15 10:12 ` [PATCH net-next v5 00/11] introduce drop reasons for tcp receive path Paolo Abeni
2024-02-15 11:10 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215012027.11467-11-kerneljasonxing@gmail.com \
--to=kerneljasonxing@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.