From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Davide Caratti <dcaratti@redhat.com>,
jhs@mojatatu.com, xiyou.wangcong@gmail.com,
shmulik.ladkani@gmail.com
Subject: Re: [PATCH net v2 1/2] net/sched: act_mirred: use the backlog for mirred ingress
Date: Thu, 15 Feb 2024 06:37:14 -0800 [thread overview]
Message-ID: <20240215063714.58fd742a@kernel.org> (raw)
In-Reply-To: <789d5cc3c38b320d61867290115acafb060ca752.camel@redhat.com>
On Thu, 15 Feb 2024 13:56:12 +0100 Paolo Abeni wrote:
> > Sorry I'm not sure what you're asking.
> >
> > We can't redirect traffic back to ourselves because we can end up
> > trying to take the socket lock for a socket that is generating
> > the packet.
> >
> > Or are you asking how we can get the stats from the packet
> > asynchronously? We could build a local async scheme but I'd rather
> > not go there unless someone actually cares about these stats.
>
> I *guess* Jiri is suggesting to expand the commit message describing
> how the fix implemented by this patch works.
The irony... ;]
v3 with more words:
https://lore.kernel.org/all/20240215143346.1715054-1-kuba@kernel.org/
prev parent reply other threads:[~2024-02-15 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 3:38 [PATCH net v2 1/2] net/sched: act_mirred: use the backlog for mirred ingress Jakub Kicinski
2024-02-14 3:38 ` [PATCH net v2 2/2] net/sched: act_mirred: don't override retval if we already lost the skb Jakub Kicinski
2024-02-15 8:18 ` Michal Swiatkowski
2024-02-14 8:51 ` [PATCH net v2 1/2] net/sched: act_mirred: use the backlog for mirred ingress Jiri Pirko
2024-02-14 15:04 ` Jakub Kicinski
2024-02-15 12:56 ` Paolo Abeni
2024-02-15 13:11 ` Jiri Pirko
2024-02-15 14:37 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215063714.58fd742a@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shmulik.ladkani@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.