All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: shuah@kernel.org, keescook@chromium.org
Cc: linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
	jakub@cloudflare.com, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next v2 4/4] selftests: ip_local_port_range: use XFAIL instead of SKIP
Date: Thu, 15 Feb 2024 16:26:19 -0800	[thread overview]
Message-ID: <20240216002619.1999225-5-kuba@kernel.org> (raw)
In-Reply-To: <20240216002619.1999225-1-kuba@kernel.org>

SCTP does not support IP_LOCAL_PORT_RANGE and we know it,
so use XFAIL instead of SKIP.

Reviewed-by: Kees Cook <keescook@chromium.org>
Tested-by: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 tools/testing/selftests/net/ip_local_port_range.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/ip_local_port_range.c b/tools/testing/selftests/net/ip_local_port_range.c
index 6ebd58869a63..d4f789f524e5 100644
--- a/tools/testing/selftests/net/ip_local_port_range.c
+++ b/tools/testing/selftests/net/ip_local_port_range.c
@@ -366,7 +366,7 @@ TEST_F(ip_local_port_range, late_bind)
 	__u16 port;
 
 	if (variant->so_protocol == IPPROTO_SCTP)
-		SKIP(return, "SCTP doesn't support IP_BIND_ADDRESS_NO_PORT");
+		XFAIL(return, "SCTP doesn't support IP_BIND_ADDRESS_NO_PORT");
 
 	fd = socket(variant->so_domain, variant->so_type, 0);
 	ASSERT_GE(fd, 0) TH_LOG("socket failed");
-- 
2.43.0


  parent reply	other threads:[~2024-02-16  0:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-16  0:26 [PATCH net-next v2 0/4] selftests: kselftest_harness: support using xfail Jakub Kicinski
2024-02-16  0:26 ` [PATCH net-next v2 1/4] selftests: kselftest_harness: pass step via shared memory Jakub Kicinski
2024-02-16  0:26 ` [PATCH net-next v2 2/4] selftests: kselftest_harness: use KSFT_* exit codes Jakub Kicinski
2024-02-16  0:26 ` [PATCH net-next v2 3/4] selftests: kselftest_harness: support using xfail Jakub Kicinski
2024-02-16  0:26 ` Jakub Kicinski [this message]
2024-02-17  1:40 ` [PATCH net-next v2 0/4] " Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240216002619.1999225-5-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=jakub@cloudflare.com \
    --cc=keescook@chromium.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.