From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: David Wei <dw@davidwei.uk>, Jiri Pirko <jiri@resnulli.us>,
Sabrina Dubroca <sd@queasysnail.net>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next v11 0/3] netdevsim: link and forward skbs between ports
Date: Fri, 16 Feb 2024 06:44:13 -0800 [thread overview]
Message-ID: <20240216064413.7315e041@kernel.org> (raw)
In-Reply-To: <ea379c684c8dbab360dce3e9add3b3a33a00143f.camel@redhat.com>
On Fri, 16 Feb 2024 11:38:17 +0100 Paolo Abeni wrote:
> On Thu, 2024-02-15 at 11:43 -0800, David Wei wrote:
> > This patchset adds the ability to link two netdevsim ports together and
> > forward skbs between them, similar to veth. The goal is to use netdevsim
> > for testing features e.g. zero copy Rx using io_uring.
> >
> > This feature was tested locally on QEMU, and a selftest is included.
>
> this apparently causes rtnetlink.sh self-tests failures:
>
> https://netdev.bots.linux.dev/flakes.html?tn-needle=rtnetlink-sh
>
> example failure:
>
> https://netdev-3.bots.linux.dev/vmksft-net/results/467721/18-rtnetlink-sh/stdout
>
> the ipsec_offload test (using netdevsim) fails.
>
> @Jakub: it looks like the rtnetlink.sh test is currently ignored by
> patchwork, skimming over the recent failures they are roughly
> correlated to this series submission: the test looks otherwise
> reasonably stable to me.
Wow, great detective work! This is what the diff says:
# 1c1
# < SA count=2 tx=0
# ---
# > SA count=2 tx=3
I'm guessing that because we clear IFF_NOARP and ipsec code doesn't
connect any peer it can't transmit? Any suggestions how to fix it?
Insert a neigh entry manually?
next prev parent reply other threads:[~2024-02-16 14:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 19:43 [PATCH net-next v11 0/3] netdevsim: link and forward skbs between ports David Wei
2024-02-15 19:43 ` [PATCH net-next v11 1/3] netdevsim: allow two netdevsim ports to be connected David Wei
2024-02-17 1:46 ` Jakub Kicinski
2024-02-17 2:53 ` David Wei
2024-02-15 19:43 ` [PATCH net-next v11 2/3] netdevsim: forward skbs from one connected port to another David Wei
2024-02-15 19:43 ` [PATCH net-next v11 3/3] netdevsim: add selftest for forwarding skb between connected ports David Wei
2024-02-16 10:38 ` [PATCH net-next v11 0/3] netdevsim: link and forward skbs between ports Paolo Abeni
2024-02-16 14:44 ` Jakub Kicinski [this message]
2024-02-16 19:13 ` David Wei
2024-02-17 1:47 ` Jakub Kicinski
2024-02-17 2:52 ` David Wei
2024-02-17 1:48 ` Jakub Kicinski
2024-02-17 3:27 ` David Wei
2024-02-19 19:20 ` Jakub Kicinski
2024-02-20 3:42 ` David Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240216064413.7315e041@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.