From: Stephen Hemminger <stephen@networkplumber.org>
To: Breno Leitao <leitao@debian.org>
Cc: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, horms@kernel.org,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH net-next v2] net: sysfs: Do not create sysfs for non BQL device
Date: Fri, 16 Feb 2024 09:29:05 -0800 [thread overview]
Message-ID: <20240216092905.4e2d3c7c@hermes.local> (raw)
In-Reply-To: <20240216094154.3263843-1-leitao@debian.org>
On Fri, 16 Feb 2024 01:41:52 -0800
Breno Leitao <leitao@debian.org> wrote:
> +static bool netdev_uses_bql(const struct net_device *dev)
> +{
> + if (dev->features & NETIF_F_LLTX ||
> + dev->priv_flags & IFF_NO_QUEUE)
> + return false;
> +
> + return IS_ENABLED(CONFIG_BQL);
> +}
Various compilers will warn about missing parens in that expression.
It is valid but mixing & and || can be bug trap.
if ((dev->features & NETIF_F_LLTX) || (dev->priv_flags & IFF_NO_QUEUE))
return false;
Not all drivers will be using bql, it requires driver to have that code.
So really it means driver could be using BQL.
Not sure if there is a way to find out if driver has the required BQL bits.
next prev parent reply other threads:[~2024-02-16 17:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 9:41 [PATCH net-next v2] net: sysfs: Do not create sysfs for non BQL device Breno Leitao
2024-02-16 17:29 ` Stephen Hemminger [this message]
2024-02-16 18:41 ` Florian Fainelli
2024-02-16 18:45 ` Eric Dumazet
2024-02-19 9:46 ` Breno Leitao
2024-06-09 4:47 ` Jason Xing
2024-06-09 13:19 ` Jason Xing
2024-02-19 10:46 ` Simon Horman
2024-02-19 20:16 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240216092905.4e2d3c7c@hermes.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.