From: Christoph Hellwig <hch@lst.de>
To: Daniel Wagner <dwagner@suse.de>
Cc: James Smart <james.smart@broadcom.com>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v0 4/6] nvme-fabrics: introduce ref counting for nvmf_ctrl_options
Date: Fri, 16 Feb 2024 10:50:13 +0100 [thread overview]
Message-ID: <20240216095013.GD19961@lst.de> (raw)
In-Reply-To: <20240216084526.14133-5-dwagner@suse.de>
On Fri, Feb 16, 2024 at 09:45:24AM +0100, Daniel Wagner wrote:
> The FC transport is offloading the connect attempt to a workqueue. When
> the attempt fails the transport is starting to cleanup resources. It is
> possible for user space to trigger a crash because nvmf_ctrl_options are
> exposed to sysfs.
Eww. I think the async offload is the real problem here..
next prev parent reply other threads:[~2024-02-16 9:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 8:45 [PATCH v0 0/6] nvme-fc: fix blktests nvme/041 Daniel Wagner
2024-02-16 8:45 ` [PATCH v0 1/6] nvme-fabrics: introduce connect_sync option Daniel Wagner
2024-02-16 9:49 ` Christoph Hellwig
2024-02-16 16:44 ` Daniel Wagner
2024-02-20 6:51 ` Christoph Hellwig
2024-02-17 16:27 ` Hannes Reinecke
2024-02-16 8:45 ` [PATCH v0 2/6] nvme-fc: rename free_ctrl callback to match name pattern Daniel Wagner
2024-02-16 9:49 ` Christoph Hellwig
2024-02-16 8:45 ` [PATCH v0 3/6] nvme-fc: do not retry when auth fails or connection is refused Daniel Wagner
2024-02-16 9:49 ` Christoph Hellwig
2024-02-16 8:45 ` [PATCH v0 4/6] nvme-fabrics: introduce ref counting for nvmf_ctrl_options Daniel Wagner
2024-02-16 9:50 ` Christoph Hellwig [this message]
2024-02-16 8:45 ` [PATCH v0 5/6] nvme-fc: redesign locking and refcounting Daniel Wagner
2024-02-16 9:51 ` Christoph Hellwig
2024-02-16 11:09 ` Hannes Reinecke
2024-02-16 12:40 ` Daniel Wagner
2024-02-16 8:45 ` [PATCH v0 6/6] nvme-fc: wait for connect attempt to finish Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240216095013.GD19961@lst.de \
--to=hch@lst.de \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.