From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 657F51BF50; Fri, 16 Feb 2024 11:25:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708082744; cv=none; b=L35oJjaMbTx5Qa3KAQlvdI3WUoUTg9Zc1dkJ7GIUGeYnGxiBRCag5OJIwsArRvyLZSCWG4X8QM8jrUyRbLpQkOEKAW1mUO4j/RD+4Nz1YUhH/C72F+vZaY0zukny5yb0q7D6DRj56487gGn0000MvMqX0+frZVPabQlb9O5PZ2A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708082744; c=relaxed/simple; bh=irTs/3hjqvC4IGIEj4U/Sb544ZHhGyYlJaKX6Qhdn+M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ryurle55UEUQHhTK3sN8Dx9yjPv/36AiSgHLC/V/BexmX5nsLWYVKfrDvnznTTJiWWGs39kcjEQhYwnbPnN29fmNoRYYTMBG4k1hF2DXiWq+KXiJ/wOCLrEExNMRTnRMdkCvmYeevtlYtpU7kgO3upbX7GFjX1V18e5lopTmKY0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=f9Hr8kSp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="f9Hr8kSp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAD0AC433C7; Fri, 16 Feb 2024 11:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708082743; bh=irTs/3hjqvC4IGIEj4U/Sb544ZHhGyYlJaKX6Qhdn+M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f9Hr8kSpQ3k1fF39QRvvME6Mk2/doRfaMNhgqWXiMfU9/dYZViGnmhMlYTTEi/S3D p/NhBnh86rSKu5V11Ip5AEbIESUFOIj0NyTXjbHojGGCt940e8sC7jAMfJGWA0aQBy LlRoSTch0Bh6lCeBocKAqycKpcnVX+NTVr7JstIwF1Fc5t7KhAQpkcMVry3Ieax+u6 HNYcf8/PV5dHGuGii7+hF0UNNwSA78XFZuQ81z/wY1JMJlkqeF8lDyMEv2ATmvAbd9 fq5CEnqBhPLLlXOrdMUhTZMe9d3dRuNpPsMi0iIJQgn+fWItYZxeUWIz236g2QEj08 S9BMhiNUAT4bg== Date: Fri, 16 Feb 2024 16:55:31 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Srikanth Thokala , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Jon Mason , Dave Jiang , Allen Hubbe , Manivannan Sadhasivam , Kishon Vijay Abraham I , Damien Le Moal , Frank Li , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org, ntb@lists.linux.dev Subject: Re: [PATCH 1/2] PCI: endpoint: Clean up hardware description for BARs Message-ID: <20240216112531.GD2559@thinkpad> References: <20240210012634.600301-1-cassel@kernel.org> <20240210012634.600301-2-cassel@kernel.org> <20240216111908.GC2559@thinkpad> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240216111908.GC2559@thinkpad> On Fri, Feb 16, 2024 at 04:49:08PM +0530, Manivannan Sadhasivam wrote: > On Sat, Feb 10, 2024 at 02:26:25AM +0100, Niklas Cassel wrote: > > The hardware description for BARs is scattered in many different variables > > in pci_epc_features. Some of these things are mutually exclusive, so it > > can create confusion over which variable that has precedence over another. > > > > Improve the situation by creating a struct pci_epc_bar_desc, and a new > > enum pci_epc_bar_type, and convert the endpoint controller drivers to use > > this more well defined format. > > > > Signed-off-by: Niklas Cassel > > --- > > drivers/pci/controller/dwc/pci-imx6.c | 3 +- > > drivers/pci/controller/dwc/pci-keystone.c | 12 +++---- > > .../pci/controller/dwc/pci-layerscape-ep.c | 5 ++- > > drivers/pci/controller/dwc/pcie-keembay.c | 8 +++-- > > drivers/pci/controller/dwc/pcie-rcar-gen4.c | 4 ++- > > drivers/pci/controller/dwc/pcie-tegra194.c | 10 ++++-- > > drivers/pci/controller/dwc/pcie-uniphier-ep.c | 15 ++++++-- > > drivers/pci/controller/pcie-rcar-ep.c | 14 +++++--- > > drivers/pci/endpoint/functions/pci-epf-ntb.c | 4 +-- > > drivers/pci/endpoint/functions/pci-epf-test.c | 8 ++--- > > drivers/pci/endpoint/functions/pci-epf-vntb.c | 2 +- > > drivers/pci/endpoint/pci-epc-core.c | 32 +++++++++-------- > > drivers/pci/endpoint/pci-epf-core.c | 15 ++++---- > > include/linux/pci-epc.h | 34 +++++++++++++++---- > > 14 files changed, 108 insertions(+), 58 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > > index dc2c036ab28c..47a9a96484ed 100644 > > --- a/drivers/pci/controller/dwc/pci-imx6.c > > +++ b/drivers/pci/controller/dwc/pci-imx6.c > > @@ -1081,7 +1081,8 @@ static const struct pci_epc_features imx8m_pcie_epc_features = { > > .linkup_notifier = false, > > .msi_capable = true, > > .msix_capable = false, > > - .reserved_bar = 1 << BAR_1 | 1 << BAR_3, > > + .bar[BAR_1] = { .type = BAR_RESERVED, }, > > + .bar[BAR_3] = { .type = BAR_RESERVED, }, > > .align = SZ_64K, > > }; > > > > diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c > > index c0c62533a3f1..b2b93b4fa82d 100644 > > --- a/drivers/pci/controller/dwc/pci-keystone.c > > +++ b/drivers/pci/controller/dwc/pci-keystone.c > > @@ -924,12 +924,12 @@ static const struct pci_epc_features ks_pcie_am654_epc_features = { > > .linkup_notifier = false, > > .msi_capable = true, > > .msix_capable = true, > > - .reserved_bar = 1 << BAR_0 | 1 << BAR_1, > > - .bar_fixed_64bit = 1 << BAR_0, > > - .bar_fixed_size[2] = SZ_1M, > > - .bar_fixed_size[3] = SZ_64K, > > - .bar_fixed_size[4] = 256, > > - .bar_fixed_size[5] = SZ_1M, > > + .bar[BAR_0] = { .type = BAR_RESERVED, .only_64bit = true, }, > > + .bar[BAR_1] = { .type = BAR_RESERVED, }, > > + .bar[BAR_2] = { .type = BAR_FIXED, .fixed_size = SZ_1M, }, > > + .bar[BAR_3] = { .type = BAR_FIXED, .fixed_size = SZ_64K, }, > > + .bar[BAR_4] = { .type = BAR_FIXED, .fixed_size = 256, }, > > + .bar[BAR_5] = { .type = BAR_FIXED, .fixed_size = SZ_1M, }, > > .align = SZ_1M, > > }; > > > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > index 2e398494e7c0..1f6ee1460ec2 100644 > > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > @@ -250,7 +250,10 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev) > > pci->dev = dev; > > pci->ops = pcie->drvdata->dw_pcie_ops; > > > > - ls_epc->bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4); > > + ls_epc->bar[BAR_2].only_64bit = true; > > + ls_epc->bar[BAR_3].type = BAR_RESERVED; > > BAR_3 and BAR_4 were not reserved previously. > Okay, looking at patch 2 makes it clear why you have marked it as such. But it should've been mentioned in the commit message. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F920C48260 for ; Fri, 16 Feb 2024 11:26:31 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=f9Hr8kSp; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TbqPy19S8z3vXf for ; Fri, 16 Feb 2024 22:26:30 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=f9Hr8kSp; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=mani@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TbqP702hKz30f5 for ; Fri, 16 Feb 2024 22:25:46 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 437D061DE0; Fri, 16 Feb 2024 11:25:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAD0AC433C7; Fri, 16 Feb 2024 11:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708082743; bh=irTs/3hjqvC4IGIEj4U/Sb544ZHhGyYlJaKX6Qhdn+M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f9Hr8kSpQ3k1fF39QRvvME6Mk2/doRfaMNhgqWXiMfU9/dYZViGnmhMlYTTEi/S3D p/NhBnh86rSKu5V11Ip5AEbIESUFOIj0NyTXjbHojGGCt940e8sC7jAMfJGWA0aQBy LlRoSTch0Bh6lCeBocKAqycKpcnVX+NTVr7JstIwF1Fc5t7KhAQpkcMVry3Ieax+u6 HNYcf8/PV5dHGuGii7+hF0UNNwSA78XFZuQ81z/wY1JMJlkqeF8lDyMEv2ATmvAbd9 fq5CEnqBhPLLlXOrdMUhTZMe9d3dRuNpPsMi0iIJQgn+fWItYZxeUWIz236g2QEj08 S9BMhiNUAT4bg== Date: Fri, 16 Feb 2024 16:55:31 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Subject: Re: [PATCH 1/2] PCI: endpoint: Clean up hardware description for BARs Message-ID: <20240216112531.GD2559@thinkpad> References: <20240210012634.600301-1-cassel@kernel.org> <20240210012634.600301-2-cassel@kernel.org> <20240216111908.GC2559@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240216111908.GC2559@thinkpad> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Kunihiko Hayashi , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Frank Li , Minghuan Lian , Thierry Reding , Manivannan Sadhasivam , Fabio Estevam , Marek Vasut , Kishon Vijay Abraham I , Rob Herring , Dave Jiang , linux-tegra@vger.kernel.org, Jonathan Hunter , NXP Linux Team , Allen Hubbe , Richard Zhu , Srikanth Thokala , Sascha Hauer , Damien Le Moal , Bjorn Helgaas , Mingkai Hu , linux-arm-kernel@lists.infradead.org, Roy Zang , linuxppc-dev@lists.ozlabs .org, Yoshihiro Shimoda , linux-renesas-soc@vger.kernel.org, ntb@lists.linux.dev, Masami Hiramatsu , Pengutronix Kernel Team , Jon Mason , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Feb 16, 2024 at 04:49:08PM +0530, Manivannan Sadhasivam wrote: > On Sat, Feb 10, 2024 at 02:26:25AM +0100, Niklas Cassel wrote: > > The hardware description for BARs is scattered in many different variables > > in pci_epc_features. Some of these things are mutually exclusive, so it > > can create confusion over which variable that has precedence over another. > > > > Improve the situation by creating a struct pci_epc_bar_desc, and a new > > enum pci_epc_bar_type, and convert the endpoint controller drivers to use > > this more well defined format. > > > > Signed-off-by: Niklas Cassel > > --- > > drivers/pci/controller/dwc/pci-imx6.c | 3 +- > > drivers/pci/controller/dwc/pci-keystone.c | 12 +++---- > > .../pci/controller/dwc/pci-layerscape-ep.c | 5 ++- > > drivers/pci/controller/dwc/pcie-keembay.c | 8 +++-- > > drivers/pci/controller/dwc/pcie-rcar-gen4.c | 4 ++- > > drivers/pci/controller/dwc/pcie-tegra194.c | 10 ++++-- > > drivers/pci/controller/dwc/pcie-uniphier-ep.c | 15 ++++++-- > > drivers/pci/controller/pcie-rcar-ep.c | 14 +++++--- > > drivers/pci/endpoint/functions/pci-epf-ntb.c | 4 +-- > > drivers/pci/endpoint/functions/pci-epf-test.c | 8 ++--- > > drivers/pci/endpoint/functions/pci-epf-vntb.c | 2 +- > > drivers/pci/endpoint/pci-epc-core.c | 32 +++++++++-------- > > drivers/pci/endpoint/pci-epf-core.c | 15 ++++---- > > include/linux/pci-epc.h | 34 +++++++++++++++---- > > 14 files changed, 108 insertions(+), 58 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > > index dc2c036ab28c..47a9a96484ed 100644 > > --- a/drivers/pci/controller/dwc/pci-imx6.c > > +++ b/drivers/pci/controller/dwc/pci-imx6.c > > @@ -1081,7 +1081,8 @@ static const struct pci_epc_features imx8m_pcie_epc_features = { > > .linkup_notifier = false, > > .msi_capable = true, > > .msix_capable = false, > > - .reserved_bar = 1 << BAR_1 | 1 << BAR_3, > > + .bar[BAR_1] = { .type = BAR_RESERVED, }, > > + .bar[BAR_3] = { .type = BAR_RESERVED, }, > > .align = SZ_64K, > > }; > > > > diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c > > index c0c62533a3f1..b2b93b4fa82d 100644 > > --- a/drivers/pci/controller/dwc/pci-keystone.c > > +++ b/drivers/pci/controller/dwc/pci-keystone.c > > @@ -924,12 +924,12 @@ static const struct pci_epc_features ks_pcie_am654_epc_features = { > > .linkup_notifier = false, > > .msi_capable = true, > > .msix_capable = true, > > - .reserved_bar = 1 << BAR_0 | 1 << BAR_1, > > - .bar_fixed_64bit = 1 << BAR_0, > > - .bar_fixed_size[2] = SZ_1M, > > - .bar_fixed_size[3] = SZ_64K, > > - .bar_fixed_size[4] = 256, > > - .bar_fixed_size[5] = SZ_1M, > > + .bar[BAR_0] = { .type = BAR_RESERVED, .only_64bit = true, }, > > + .bar[BAR_1] = { .type = BAR_RESERVED, }, > > + .bar[BAR_2] = { .type = BAR_FIXED, .fixed_size = SZ_1M, }, > > + .bar[BAR_3] = { .type = BAR_FIXED, .fixed_size = SZ_64K, }, > > + .bar[BAR_4] = { .type = BAR_FIXED, .fixed_size = 256, }, > > + .bar[BAR_5] = { .type = BAR_FIXED, .fixed_size = SZ_1M, }, > > .align = SZ_1M, > > }; > > > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > index 2e398494e7c0..1f6ee1460ec2 100644 > > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > @@ -250,7 +250,10 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev) > > pci->dev = dev; > > pci->ops = pcie->drvdata->dw_pcie_ops; > > > > - ls_epc->bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4); > > + ls_epc->bar[BAR_2].only_64bit = true; > > + ls_epc->bar[BAR_3].type = BAR_RESERVED; > > BAR_3 and BAR_4 were not reserved previously. > Okay, looking at patch 2 makes it clear why you have marked it as such. But it should've been mentioned in the commit message. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C670C48260 for ; Fri, 16 Feb 2024 11:26:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fW6UDdiOHDBy75h4/Dp0TQGYOTgdMuhBFSdqE0FUtQs=; b=tHkiEU3Vf8ZUg2 JzJdZc3Xdd4fzpLutjLdN16zTFOSaBNPnEYW+ThRJyWc5VYGFb7AwjkBRSp+tgO6sgAckVmznhFUC 6UAa9tuUz3u+00WHTvfJuE9VujMPqrEA7oVzAiCSlzyC9IJT76efgevQ4ElmUA0AAAqb7DmF9yO9n RFmT0pj+2kBM6rXhXIhEi3sCtWw0x3H88GVWM5l3GF3lZuKbDSSZVfwGFKD+eFs0M+G27RTZ1qMy6 6uzEWp7+R63RgV40KlHHhI7j3mV4QJUR8mL6R2UUEImFG6ZNrJu5u/raF+WrcMWLjldceZWO0vGxw HW4LHR7cYjaOuHDdKvgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rawLj-000000028j3-3I6c; Fri, 16 Feb 2024 11:25:47 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rawLg-000000028gu-3i3K for linux-arm-kernel@lists.infradead.org; Fri, 16 Feb 2024 11:25:46 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 437D061DE0; Fri, 16 Feb 2024 11:25:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAD0AC433C7; Fri, 16 Feb 2024 11:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708082743; bh=irTs/3hjqvC4IGIEj4U/Sb544ZHhGyYlJaKX6Qhdn+M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f9Hr8kSpQ3k1fF39QRvvME6Mk2/doRfaMNhgqWXiMfU9/dYZViGnmhMlYTTEi/S3D p/NhBnh86rSKu5V11Ip5AEbIESUFOIj0NyTXjbHojGGCt940e8sC7jAMfJGWA0aQBy LlRoSTch0Bh6lCeBocKAqycKpcnVX+NTVr7JstIwF1Fc5t7KhAQpkcMVry3Ieax+u6 HNYcf8/PV5dHGuGii7+hF0UNNwSA78XFZuQ81z/wY1JMJlkqeF8lDyMEv2ATmvAbd9 fq5CEnqBhPLLlXOrdMUhTZMe9d3dRuNpPsMi0iIJQgn+fWItYZxeUWIz236g2QEj08 S9BMhiNUAT4bg== Date: Fri, 16 Feb 2024 16:55:31 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Srikanth Thokala , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Jon Mason , Dave Jiang , Allen Hubbe , Manivannan Sadhasivam , Kishon Vijay Abraham I , Damien Le Moal , Frank Li , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org, ntb@lists.linux.dev Subject: Re: [PATCH 1/2] PCI: endpoint: Clean up hardware description for BARs Message-ID: <20240216112531.GD2559@thinkpad> References: <20240210012634.600301-1-cassel@kernel.org> <20240210012634.600301-2-cassel@kernel.org> <20240216111908.GC2559@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240216111908.GC2559@thinkpad> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240216_032545_034728_F8729A12 X-CRM114-Status: GOOD ( 20.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBGZWIgMTYsIDIwMjQgYXQgMDQ6NDk6MDhQTSArMDUzMCwgTWFuaXZhbm5hbiBTYWRo YXNpdmFtIHdyb3RlOgo+IE9uIFNhdCwgRmViIDEwLCAyMDI0IGF0IDAyOjI2OjI1QU0gKzAxMDAs IE5pa2xhcyBDYXNzZWwgd3JvdGU6Cj4gPiBUaGUgaGFyZHdhcmUgZGVzY3JpcHRpb24gZm9yIEJB UnMgaXMgc2NhdHRlcmVkIGluIG1hbnkgZGlmZmVyZW50IHZhcmlhYmxlcwo+ID4gaW4gcGNpX2Vw Y19mZWF0dXJlcy4gU29tZSBvZiB0aGVzZSB0aGluZ3MgYXJlIG11dHVhbGx5IGV4Y2x1c2l2ZSwg c28gaXQKPiA+IGNhbiBjcmVhdGUgY29uZnVzaW9uIG92ZXIgd2hpY2ggdmFyaWFibGUgdGhhdCBo YXMgcHJlY2VkZW5jZSBvdmVyIGFub3RoZXIuCj4gPiAKPiA+IEltcHJvdmUgdGhlIHNpdHVhdGlv biBieSBjcmVhdGluZyBhIHN0cnVjdCBwY2lfZXBjX2Jhcl9kZXNjLCBhbmQgYSBuZXcKPiA+IGVu dW0gcGNpX2VwY19iYXJfdHlwZSwgYW5kIGNvbnZlcnQgdGhlIGVuZHBvaW50IGNvbnRyb2xsZXIg ZHJpdmVycyB0byB1c2UKPiA+IHRoaXMgbW9yZSB3ZWxsIGRlZmluZWQgZm9ybWF0Lgo+ID4gCj4g PiBTaWduZWQtb2ZmLWJ5OiBOaWtsYXMgQ2Fzc2VsIDxjYXNzZWxAa2VybmVsLm9yZz4KPiA+IC0t LQo+ID4gIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1pbXg2LmMgICAgICAgICB8ICAz ICstCj4gPiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWtleXN0b25lLmMgICAgIHwg MTIgKysrLS0tLQo+ID4gIC4uLi9wY2kvY29udHJvbGxlci9kd2MvcGNpLWxheWVyc2NhcGUtZXAu YyAgICB8ICA1ICsrLQo+ID4gIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUta2VlbWJh eS5jICAgICB8ICA4ICsrKy0tCj4gPiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1y Y2FyLWdlbjQuYyAgIHwgIDQgKystCj4gPiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNp ZS10ZWdyYTE5NC5jICAgIHwgMTAgKysrKy0tCj4gPiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9k d2MvcGNpZS11bmlwaGllci1lcC5jIHwgMTUgKysrKysrLS0KPiA+ICBkcml2ZXJzL3BjaS9jb250 cm9sbGVyL3BjaWUtcmNhci1lcC5jICAgICAgICAgfCAxNCArKysrKy0tLQo+ID4gIGRyaXZlcnMv cGNpL2VuZHBvaW50L2Z1bmN0aW9ucy9wY2ktZXBmLW50Yi5jICB8ICA0ICstLQo+ID4gIGRyaXZl cnMvcGNpL2VuZHBvaW50L2Z1bmN0aW9ucy9wY2ktZXBmLXRlc3QuYyB8ICA4ICsrLS0tCj4gPiAg ZHJpdmVycy9wY2kvZW5kcG9pbnQvZnVuY3Rpb25zL3BjaS1lcGYtdm50Yi5jIHwgIDIgKy0KPiA+ ICBkcml2ZXJzL3BjaS9lbmRwb2ludC9wY2ktZXBjLWNvcmUuYyAgICAgICAgICAgfCAzMiArKysr KysrKystLS0tLS0tLQo+ID4gIGRyaXZlcnMvcGNpL2VuZHBvaW50L3BjaS1lcGYtY29yZS5jICAg ICAgICAgICB8IDE1ICsrKystLS0tCj4gPiAgaW5jbHVkZS9saW51eC9wY2ktZXBjLmggICAgICAg ICAgICAgICAgICAgICAgIHwgMzQgKysrKysrKysrKysrKysrLS0tLQo+ID4gIDE0IGZpbGVzIGNo YW5nZWQsIDEwOCBpbnNlcnRpb25zKCspLCA1OCBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1pbXg2LmMgYi9kcml2ZXJzL3Bj aS9jb250cm9sbGVyL2R3Yy9wY2ktaW14Ni5jCj4gPiBpbmRleCBkYzJjMDM2YWIyOGMuLjQ3YTlh OTY0ODRlZCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1p bXg2LmMKPiA+ICsrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1pbXg2LmMKPiA+ IEBAIC0xMDgxLDcgKzEwODEsOCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHBjaV9lcGNfZmVhdHVy ZXMgaW14OG1fcGNpZV9lcGNfZmVhdHVyZXMgPSB7Cj4gPiAgCS5saW5rdXBfbm90aWZpZXIgPSBm YWxzZSwKPiA+ICAJLm1zaV9jYXBhYmxlID0gdHJ1ZSwKPiA+ICAJLm1zaXhfY2FwYWJsZSA9IGZh bHNlLAo+ID4gLQkucmVzZXJ2ZWRfYmFyID0gMSA8PCBCQVJfMSB8IDEgPDwgQkFSXzMsCj4gPiAr CS5iYXJbQkFSXzFdID0geyAudHlwZSA9IEJBUl9SRVNFUlZFRCwgfSwKPiA+ICsJLmJhcltCQVJf M10gPSB7IC50eXBlID0gQkFSX1JFU0VSVkVELCB9LAo+ID4gIAkuYWxpZ24gPSBTWl82NEssCj4g PiAgfTsKPiA+ICAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9w Y2kta2V5c3RvbmUuYyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1rZXlzdG9uZS5j Cj4gPiBpbmRleCBjMGM2MjUzM2EzZjEuLmIyYjkzYjRmYTgyZCAxMDA2NDQKPiA+IC0tLSBhL2Ry aXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1rZXlzdG9uZS5jCj4gPiArKysgYi9kcml2ZXJz L3BjaS9jb250cm9sbGVyL2R3Yy9wY2kta2V5c3RvbmUuYwo+ID4gQEAgLTkyNCwxMiArOTI0LDEy IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcGNpX2VwY19mZWF0dXJlcyBrc19wY2llX2FtNjU0X2Vw Y19mZWF0dXJlcyA9IHsKPiA+ICAJLmxpbmt1cF9ub3RpZmllciA9IGZhbHNlLAo+ID4gIAkubXNp X2NhcGFibGUgPSB0cnVlLAo+ID4gIAkubXNpeF9jYXBhYmxlID0gdHJ1ZSwKPiA+IC0JLnJlc2Vy dmVkX2JhciA9IDEgPDwgQkFSXzAgfCAxIDw8IEJBUl8xLAo+ID4gLQkuYmFyX2ZpeGVkXzY0Yml0 ID0gMSA8PCBCQVJfMCwKPiA+IC0JLmJhcl9maXhlZF9zaXplWzJdID0gU1pfMU0sCj4gPiAtCS5i YXJfZml4ZWRfc2l6ZVszXSA9IFNaXzY0SywKPiA+IC0JLmJhcl9maXhlZF9zaXplWzRdID0gMjU2 LAo+ID4gLQkuYmFyX2ZpeGVkX3NpemVbNV0gPSBTWl8xTSwKPiA+ICsJLmJhcltCQVJfMF0gPSB7 IC50eXBlID0gQkFSX1JFU0VSVkVELCAub25seV82NGJpdCA9IHRydWUsIH0sCj4gPiArCS5iYXJb QkFSXzFdID0geyAudHlwZSA9IEJBUl9SRVNFUlZFRCwgfSwKPiA+ICsJLmJhcltCQVJfMl0gPSB7 IC50eXBlID0gQkFSX0ZJWEVELCAuZml4ZWRfc2l6ZSA9IFNaXzFNLCB9LAo+ID4gKwkuYmFyW0JB Ul8zXSA9IHsgLnR5cGUgPSBCQVJfRklYRUQsIC5maXhlZF9zaXplID0gU1pfNjRLLCB9LAo+ID4g KwkuYmFyW0JBUl80XSA9IHsgLnR5cGUgPSBCQVJfRklYRUQsIC5maXhlZF9zaXplID0gMjU2LCB9 LAo+ID4gKwkuYmFyW0JBUl81XSA9IHsgLnR5cGUgPSBCQVJfRklYRUQsIC5maXhlZF9zaXplID0g U1pfMU0sIH0sCj4gPiAgCS5hbGlnbiA9IFNaXzFNLAo+ID4gIH07Cj4gPiAgCj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWxheWVyc2NhcGUtZXAuYyBiL2Ry aXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1sYXllcnNjYXBlLWVwLmMKPiA+IGluZGV4IDJl Mzk4NDk0ZTdjMC4uMWY2ZWUxNDYwZWMyIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9wY2kvY29u dHJvbGxlci9kd2MvcGNpLWxheWVyc2NhcGUtZXAuYwo+ID4gKysrIGIvZHJpdmVycy9wY2kvY29u dHJvbGxlci9kd2MvcGNpLWxheWVyc2NhcGUtZXAuYwo+ID4gQEAgLTI1MCw3ICsyNTAsMTAgQEAg c3RhdGljIGludCBfX2luaXQgbHNfcGNpZV9lcF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNl ICpwZGV2KQo+ID4gIAlwY2ktPmRldiA9IGRldjsKPiA+ICAJcGNpLT5vcHMgPSBwY2llLT5kcnZk YXRhLT5kd19wY2llX29wczsKPiA+ICAKPiA+IC0JbHNfZXBjLT5iYXJfZml4ZWRfNjRiaXQgPSAo MSA8PCBCQVJfMikgfCAoMSA8PCBCQVJfNCk7Cj4gPiArCWxzX2VwYy0+YmFyW0JBUl8yXS5vbmx5 XzY0Yml0ID0gdHJ1ZTsKPiA+ICsJbHNfZXBjLT5iYXJbQkFSXzNdLnR5cGUgPSBCQVJfUkVTRVJW RUQ7Cj4gCj4gQkFSXzMgYW5kIEJBUl80IHdlcmUgbm90IHJlc2VydmVkIHByZXZpb3VzbHkuCj4g CgpPa2F5LCBsb29raW5nIGF0IHBhdGNoIDIgbWFrZXMgaXQgY2xlYXIgd2h5IHlvdSBoYXZlIG1h cmtlZCBpdCBhcyBzdWNoLiBCdXQgaXQKc2hvdWxkJ3ZlIGJlZW4gbWVudGlvbmVkIGluIHRoZSBj b21taXQgbWVzc2FnZS4KCi0gTWFuaQoKLS0gCuCuruCuo+Cuv+CuteCuo+CvjeCuo+CuqeCvjSDg rprgrqTgrr7grprgrr/grrXgrq7gr40KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK