Re: [PATCH v3] close_range.2: Add _GNU_SOURCE and unistd.h to SYNOPSIS

[Mark Wielaard <mark@klomp.org>]

Hi Alejandro,

On Sun, Feb 18, 2024 at 02:09:48AM +0100, Alejandro Colomar wrote:
> On Mon, Feb 12, 2024 at 01:07:04PM +0100, Mark Wielaard wrote:
> > close_range is defined in unistd.h when _GNU_SOURCE is defined.
> > The linux/close_range.h include file only defines the (linux specific)
> > flags constants. The flags argument is an int, not an unsigned int, in
> > the glibc wrapper. Use the close_range library call in the example code
> > instead of syscall.
> > 
> > Fixes: 71a62d6c3c56 ("close_range.2: Glibc added a wrapper recently")
> > Fixes: c2356ba085ed ("close_range.2: Glibc 2.34 has added a close_range() wrapper")
> > 
> > Reported-by: Alexandra Hájková <ahajkova@redhat.com>
> > Signed-off-by: Mark Wielaard <mark@klomp.org>
> 
> Thanks for the patch!  I've tweaked it a little bit, and applied it:
> <https://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/?h=contrib&id=9dc4cba62c1d19ff3aa02e062e4a0c03f5299182>

Thanks.

Note that there is now one line which is > 80 chars.
You can fix that using this from the original fix,
that splits and indents the comment on two lines:

> > +.BR "#include <linux/close_range.h>" " /* Definition of " CLOSE_RANGE_* "
> > +.BR "" "                                  constants */"

Cheers,

Mark