All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maks Mishin <maks.mishinfz@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Maks Mishin <maks.mishinFZ@gmail.com>, netdev@vger.kernel.org
Subject: [PATCH] ctrl: Add check for result rtnl_dump_filter()
Date: Sun, 18 Feb 2024 22:43:09 +0300	[thread overview]
Message-ID: <20240218194309.31482-1-maks.mishinFZ@gmail.com> (raw)

Added check for result of rtnl_dump_filter() function
for catch errors linked with dump.
Found by RASU JSC.

Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
---
 genl/ctrl.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/genl/ctrl.c b/genl/ctrl.c
index aff922a4..467a2830 100644
--- a/genl/ctrl.c
+++ b/genl/ctrl.c
@@ -313,7 +313,10 @@ static int ctrl_list(int cmd, int argc, char **argv)
 			goto ctrl_done;
 		}
 
-		rtnl_dump_filter(&rth, print_ctrl2, stdout);
+		if (rtnl_dump_filter(&rth, print_ctrl2, stdout) < 0) {
+			fprintf(stderr, "Dump terminated\n");
+			exit(1);
+		}
 
 	}
 
-- 
2.30.2


             reply	other threads:[~2024-02-18 19:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-18 19:43 Maks Mishin [this message]
2024-02-19 17:51 ` [PATCH] ctrl: Add check for result rtnl_dump_filter() Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240218194309.31482-1-maks.mishinFZ@gmail.com \
    --to=maks.mishinfz@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.