Re: [net-next RFC PATCH 1/3] net: phy: detach PHY driver OPs from phy_driver struct

[kernel test robot <lkp@intel.com>]

Hi Christian,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Marangi/net-phy-detach-PHY-driver-OPs-from-phy_driver-struct/20240218-034406
base:   net-next/main
patch link:    https://lore.kernel.org/r/20240217194116.8565-2-ansuelsmth%40gmail.com
patch subject: [net-next RFC PATCH 1/3] net: phy: detach PHY driver OPs from phy_driver struct
config: i386-buildonly-randconfig-003-20240219 (https://download.01.org/0day-ci/archive/20240219/202402190743.SaQuB7x7-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240219/202402190743.SaQuB7x7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402190743.SaQuB7x7-lkp@intel.com/

All errors (new ones prefixed by >>):

>> net/ethtool/linkstate.c:38:36: error: no member named 'get_sqi' in 'struct phy_driver'
      38 |         if (!phydev->drv || !phydev->drv->get_sqi)
         |                              ~~~~~~~~~~~  ^
   net/ethtool/linkstate.c:41:22: error: no member named 'get_sqi' in 'struct phy_driver'
      41 |                 ret = phydev->drv->get_sqi(phydev);
         |                       ~~~~~~~~~~~  ^
>> net/ethtool/linkstate.c:56:36: error: no member named 'get_sqi_max' in 'struct phy_driver'
      56 |         if (!phydev->drv || !phydev->drv->get_sqi_max)
         |                              ~~~~~~~~~~~  ^
   net/ethtool/linkstate.c:59:22: error: no member named 'get_sqi_max' in 'struct phy_driver'
      59 |                 ret = phydev->drv->get_sqi_max(phydev);
         |                       ~~~~~~~~~~~  ^
   4 errors generated.
--
>> net/ethtool/ioctl.c:2481:44: error: no member named 'module_info' in 'struct phy_driver'
    2481 |         if (phydev && phydev->drv && phydev->drv->module_info)
         |                                      ~~~~~~~~~~~  ^
   net/ethtool/ioctl.c:2482:23: error: no member named 'module_info' in 'struct phy_driver'
    2482 |                 return phydev->drv->module_info(phydev, modinfo);
         |                        ~~~~~~~~~~~  ^
>> net/ethtool/ioctl.c:2518:44: error: no member named 'module_eeprom' in 'struct phy_driver'
    2518 |         if (phydev && phydev->drv && phydev->drv->module_eeprom)
         |                                      ~~~~~~~~~~~  ^
   net/ethtool/ioctl.c:2519:23: error: no member named 'module_eeprom' in 'struct phy_driver'
    2519 |                 return phydev->drv->module_eeprom(phydev, ee, data);
         |                        ~~~~~~~~~~~  ^
>> net/ethtool/ioctl.c:2762:58: error: no member named 'get_tunable' in 'struct phy_driver'
    2762 |         phy_drv_tunable = phydev && phydev->drv && phydev->drv->get_tunable;
         |                                                    ~~~~~~~~~~~  ^
   net/ethtool/ioctl.c:2775:22: error: no member named 'get_tunable' in 'struct phy_driver'
    2775 |                 ret = phydev->drv->get_tunable(phydev, &tuna, data);
         |                       ~~~~~~~~~~~  ^
   net/ethtool/ioctl.c:2801:58: error: no member named 'get_tunable' in 'struct phy_driver'
    2801 |         phy_drv_tunable = phydev && phydev->drv && phydev->drv->get_tunable;
         |                                                    ~~~~~~~~~~~  ^
>> net/ethtool/ioctl.c:2815:22: error: no member named 'set_tunable' in 'struct phy_driver'
    2815 |                 ret = phydev->drv->set_tunable(phydev, &tuna, data);
         |                       ~~~~~~~~~~~  ^
   8 errors generated.


vim +38 net/ethtool/linkstate.c

3d2b847fb99cf2 Michal Kubecek 2019-12-27  28  
8066021915924f Oleksij Rempel 2020-05-20  29  static int linkstate_get_sqi(struct net_device *dev)
8066021915924f Oleksij Rempel 2020-05-20  30  {
8066021915924f Oleksij Rempel 2020-05-20  31  	struct phy_device *phydev = dev->phydev;
8066021915924f Oleksij Rempel 2020-05-20  32  	int ret;
8066021915924f Oleksij Rempel 2020-05-20  33  
8066021915924f Oleksij Rempel 2020-05-20  34  	if (!phydev)
8066021915924f Oleksij Rempel 2020-05-20  35  		return -EOPNOTSUPP;
8066021915924f Oleksij Rempel 2020-05-20  36  
8066021915924f Oleksij Rempel 2020-05-20  37  	mutex_lock(&phydev->lock);
8066021915924f Oleksij Rempel 2020-05-20 @38  	if (!phydev->drv || !phydev->drv->get_sqi)
8066021915924f Oleksij Rempel 2020-05-20  39  		ret = -EOPNOTSUPP;
8066021915924f Oleksij Rempel 2020-05-20  40  	else
8066021915924f Oleksij Rempel 2020-05-20  41  		ret = phydev->drv->get_sqi(phydev);
8066021915924f Oleksij Rempel 2020-05-20  42  	mutex_unlock(&phydev->lock);
8066021915924f Oleksij Rempel 2020-05-20  43  
8066021915924f Oleksij Rempel 2020-05-20  44  	return ret;
8066021915924f Oleksij Rempel 2020-05-20  45  }
8066021915924f Oleksij Rempel 2020-05-20  46  
8066021915924f Oleksij Rempel 2020-05-20  47  static int linkstate_get_sqi_max(struct net_device *dev)
8066021915924f Oleksij Rempel 2020-05-20  48  {
8066021915924f Oleksij Rempel 2020-05-20  49  	struct phy_device *phydev = dev->phydev;
8066021915924f Oleksij Rempel 2020-05-20  50  	int ret;
8066021915924f Oleksij Rempel 2020-05-20  51  
8066021915924f Oleksij Rempel 2020-05-20  52  	if (!phydev)
8066021915924f Oleksij Rempel 2020-05-20  53  		return -EOPNOTSUPP;
8066021915924f Oleksij Rempel 2020-05-20  54  
8066021915924f Oleksij Rempel 2020-05-20  55  	mutex_lock(&phydev->lock);
8066021915924f Oleksij Rempel 2020-05-20 @56  	if (!phydev->drv || !phydev->drv->get_sqi_max)
8066021915924f Oleksij Rempel 2020-05-20  57  		ret = -EOPNOTSUPP;
8066021915924f Oleksij Rempel 2020-05-20  58  	else
8066021915924f Oleksij Rempel 2020-05-20  59  		ret = phydev->drv->get_sqi_max(phydev);
8066021915924f Oleksij Rempel 2020-05-20  60  	mutex_unlock(&phydev->lock);
8066021915924f Oleksij Rempel 2020-05-20  61  
8066021915924f Oleksij Rempel 2020-05-20  62  	return ret;
ecc31c60240b98 Amit Cohen     2020-06-29  63  };
ecc31c60240b98 Amit Cohen     2020-06-29  64  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki