From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Yi Liu <yi.l.liu@intel.com>, Arnd Bergmann <arnd@arndb.de>,
Kevin Tian <kevin.tian@intel.com>,
Joao Martins <joao.m.martins@oracle.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 04/10] iommu/vt-d: Update iotlb in nested domain attach
Date: Mon, 19 Feb 2024 19:15:55 +0800 [thread overview]
Message-ID: <20240219111601.96405-5-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20240219111601.96405-1-baolu.lu@linux.intel.com>
From: Yi Liu <yi.l.liu@intel.com>
Should call domain_update_iotlb() to update the has_iotlb_device flag
of the domain after attaching device to nested domain. Without it, this
flag is not set properly and would result in missing device TLB flush.
Fixes: 9838f2bb6b6b ("iommu/vt-d: Set the nested domain to a device")
Signed-off-by: Yi Liu <yi.l.liu@intel.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Link: https://lore.kernel.org/r/20240208082307.15759-5-yi.l.liu@intel.com
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
drivers/iommu/intel/iommu.h | 1 +
drivers/iommu/intel/iommu.c | 4 +---
drivers/iommu/intel/nested.c | 2 ++
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/iommu/intel/iommu.h b/drivers/iommu/intel/iommu.h
index 9b27edb73aa9..4145c04cb1c6 100644
--- a/drivers/iommu/intel/iommu.h
+++ b/drivers/iommu/intel/iommu.h
@@ -1066,6 +1066,7 @@ int qi_submit_sync(struct intel_iommu *iommu, struct qi_desc *desc,
*/
#define QI_OPT_WAIT_DRAIN BIT(0)
+void domain_update_iotlb(struct dmar_domain *domain);
int domain_attach_iommu(struct dmar_domain *domain, struct intel_iommu *iommu);
void domain_detach_iommu(struct dmar_domain *domain, struct intel_iommu *iommu);
void device_block_translation(struct device *dev);
diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index e3dbcae95975..711c3e3fe095 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -396,8 +396,6 @@ static int domain_update_device_node(struct dmar_domain *domain)
return nid;
}
-static void domain_update_iotlb(struct dmar_domain *domain);
-
/* Return the super pagesize bitmap if supported. */
static unsigned long domain_super_pgsize_bitmap(struct dmar_domain *domain)
{
@@ -1218,7 +1216,7 @@ domain_lookup_dev_info(struct dmar_domain *domain,
return NULL;
}
-static void domain_update_iotlb(struct dmar_domain *domain)
+void domain_update_iotlb(struct dmar_domain *domain)
{
struct dev_pasid_info *dev_pasid;
struct device_domain_info *info;
diff --git a/drivers/iommu/intel/nested.c b/drivers/iommu/intel/nested.c
index 6a75f6eb18f1..d5af5925a31c 100644
--- a/drivers/iommu/intel/nested.c
+++ b/drivers/iommu/intel/nested.c
@@ -65,6 +65,8 @@ static int intel_nested_attach_dev(struct iommu_domain *domain,
list_add(&info->link, &dmar_domain->devices);
spin_unlock_irqrestore(&dmar_domain->lock, flags);
+ domain_update_iotlb(dmar_domain);
+
return 0;
}
--
2.34.1
next prev parent reply other threads:[~2024-02-19 11:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 11:15 [PATCH 00/10] [PULL REQUEST] iommu/vt-d: Fixes for v6.8-rc5 Lu Baolu
2024-02-19 11:15 ` [PATCH 01/10] iommu/vt-d: Track nested domains in parent Lu Baolu
2024-02-19 11:15 ` [PATCH 02/10] iommu/vt-d: Add __iommu_flush_iotlb_psi() Lu Baolu
2024-02-19 11:15 ` [PATCH 03/10] iommu/vt-d: Add missing iotlb flush for parent domain Lu Baolu
2024-02-19 11:15 ` Lu Baolu [this message]
2024-02-19 11:15 ` [PATCH 05/10] iommu/vt-d: Add missing device " Lu Baolu
2024-02-19 11:15 ` [PATCH 06/10] iommu/vt-d: Remove domain parameter for intel_pasid_setup_dirty_tracking() Lu Baolu
2024-02-19 11:15 ` [PATCH 07/10] iommu/vt-d: Wrap the dirty tracking loop to be a helper Lu Baolu
2024-02-19 11:15 ` [PATCH 08/10] iommu/vt-d: Add missing dirty tracking set for parent domain Lu Baolu
2024-02-19 11:16 ` [PATCH 09/10] iommu/vt-d: Set SSADE when attaching to a parent with dirty tracking Lu Baolu
2024-02-19 11:16 ` [PATCH 10/10] iommu/vt-d: Fix constant-out-of-range warning Lu Baolu
2024-02-21 9:29 ` [PATCH 00/10] [PULL REQUEST] iommu/vt-d: Fixes for v6.8-rc5 Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240219111601.96405-5-baolu.lu@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=arnd@arndb.de \
--cc=iommu@lists.linux.dev \
--cc=joao.m.martins@oracle.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.