From: Simon Horman <horms@kernel.org>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: mac80211: clean up assignments to pointer cache.
Date: Mon, 19 Feb 2024 16:08:22 +0000 [thread overview]
Message-ID: <20240219160822.GF40273@kernel.org> (raw)
In-Reply-To: <20240215232151.2075483-1-colin.i.king@gmail.com>
On Thu, Feb 15, 2024 at 11:21:51PM +0000, Colin Ian King wrote:
> From: Colin Ian King <colin.i.king@intel.com>
>
> The assignment to pointer cache in function mesh_fast_tx_gc can
> be made at the declaration time rather than a later assignment.
> There are also 3 functions where pointer cache is being initialized
> at declaration time and later re-assigned again with the same
> value, these are redundant and can be removed.
>
> Cleans up code and three clang scan build warnings:
> warning: Value stored to 'cache' during its initialization is never
> read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@intel.com>
FWIIW, these changes look fine to me although I might have split the
mesh_fast_tx_gc() and mesh_fast_tx_flush_sta() changes into different
patches as they seem to address separate issues.
That notwithstanding,
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2024-02-19 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 23:21 [PATCH] wifi: mac80211: clean up assignments to pointer cache Colin Ian King
2024-02-19 16:08 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240219160822.GF40273@kernel.org \
--to=horms@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.